All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Tony Lindgren <tony@atomide.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Nishanth Menon <nm@ti.com>, linux-mmc <linux-mmc@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, "arm@kernel.org" <arm@kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: All OMAP platforms: MMC is broken
Date: Thu, 8 Oct 2015 04:43:39 +0530	[thread overview]
Message-ID: <5615A723.6090907@ti.com> (raw)
In-Reply-To: <CAPDyKFp5e_pizFSCzeYSM8sXGx6Jewgs2PRB-RQ1iWMM6WMOww@mail.gmail.com>

Hi,

On Thursday 08 October 2015 01:10 AM, Ulf Hansson wrote:
> On 7 October 2015 at 17:52, Tony Lindgren <tony@atomide.com> wrote:
>> * Ulf Hansson <ulf.hansson@linaro.org> [151007 06:46]:
>>> On 7 October 2015 at 15:26, Tony Lindgren <tony@atomide.com> wrote:
>>>>>> Good idea, how about something like the following? AFAIK that's the
>>>>>> only .config option needed as MFD_SYSCON is selected by Kconfig
>>>>>> already.
>>>
>>> Similar to MFD_SYSCON, why don't we have REGULATOR_PBIAS to be
>>> selected when omap_hsmmc is being used?
>>>
>>> It seems like that should also be a patch for the rc, right!?
>>
>> Well selecting CONFIG_REGULATOR is still optional and force selecting
>> drivers usually leads into randconfig build issues sooner or later.
>> And we'd like to make everything into loadable modules eventually.
> 
> I am not sure I get your point. Perhaps I was too vague in what I suggested.
> 
> Unless we express the dependencies via Kconfig files (or perhaps via
> updated defconfigs), how do you expect build/boot automated tools to
> handle this?

Both omap2plus_defconfig and multi_v7_defconfig has
CONFIG_PBIAS_REGULATOR enabled [1].

I think by using *depends on* in Kconfig, we'll end up in the same issue
faced by Russell (since even with that CONFIG_PBIAS_REGULATOR won't be
enabled) and using *select* can lead to randconfig errors.

[1] -> https://lkml.org/lkml/2015/9/3/119

Thanks
Kishon

WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: All OMAP platforms: MMC is broken
Date: Thu, 8 Oct 2015 04:43:39 +0530	[thread overview]
Message-ID: <5615A723.6090907@ti.com> (raw)
In-Reply-To: <CAPDyKFp5e_pizFSCzeYSM8sXGx6Jewgs2PRB-RQ1iWMM6WMOww@mail.gmail.com>

Hi,

On Thursday 08 October 2015 01:10 AM, Ulf Hansson wrote:
> On 7 October 2015 at 17:52, Tony Lindgren <tony@atomide.com> wrote:
>> * Ulf Hansson <ulf.hansson@linaro.org> [151007 06:46]:
>>> On 7 October 2015 at 15:26, Tony Lindgren <tony@atomide.com> wrote:
>>>>>> Good idea, how about something like the following? AFAIK that's the
>>>>>> only .config option needed as MFD_SYSCON is selected by Kconfig
>>>>>> already.
>>>
>>> Similar to MFD_SYSCON, why don't we have REGULATOR_PBIAS to be
>>> selected when omap_hsmmc is being used?
>>>
>>> It seems like that should also be a patch for the rc, right!?
>>
>> Well selecting CONFIG_REGULATOR is still optional and force selecting
>> drivers usually leads into randconfig build issues sooner or later.
>> And we'd like to make everything into loadable modules eventually.
> 
> I am not sure I get your point. Perhaps I was too vague in what I suggested.
> 
> Unless we express the dependencies via Kconfig files (or perhaps via
> updated defconfigs), how do you expect build/boot automated tools to
> handle this?

Both omap2plus_defconfig and multi_v7_defconfig has
CONFIG_PBIAS_REGULATOR enabled [1].

I think by using *depends on* in Kconfig, we'll end up in the same issue
faced by Russell (since even with that CONFIG_PBIAS_REGULATOR won't be
enabled) and using *select* can lead to randconfig errors.

[1] -> https://lkml.org/lkml/2015/9/3/119

Thanks
Kishon

  reply	other threads:[~2015-10-07 23:14 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24  9:00 All OMAP platforms: MMC is broken Russell King - ARM Linux
2015-09-24  9:00 ` Russell King - ARM Linux
2015-09-24 22:51 ` Grygorii Strashko
2015-09-24 22:51   ` Grygorii Strashko
2015-09-24 22:53   ` Russell King - ARM Linux
2015-09-24 22:53     ` Russell King - ARM Linux
2015-09-24 23:37 ` Tony Lindgren
2015-09-24 23:37   ` Tony Lindgren
2015-09-25  1:13   ` Tony Lindgren
2015-09-25  1:13     ` Tony Lindgren
2015-09-26  2:54     ` Nishanth Menon
2015-09-26  2:54       ` Nishanth Menon
2015-10-01  9:33   ` Russell King - ARM Linux
2015-10-01  9:33     ` Russell King - ARM Linux
2015-10-01  9:50     ` Ulf Hansson
2015-10-01  9:50       ` Ulf Hansson
2015-10-01 10:03       ` Russell King - ARM Linux
2015-10-01 10:03         ` Russell King - ARM Linux
2015-10-05 11:23         ` Tony Lindgren
2015-10-05 11:23           ` Tony Lindgren
2015-10-05 14:35           ` Tony Lindgren
2015-10-05 14:35             ` Tony Lindgren
2015-10-05 14:51             ` Tony Lindgren
2015-10-05 14:51               ` Tony Lindgren
2015-10-05 17:11               ` Tony Lindgren
2015-10-05 17:11                 ` Tony Lindgren
2015-10-05 18:38                 ` Russell King - ARM Linux
2015-10-05 18:38                   ` Russell King - ARM Linux
2015-10-06  9:00                   ` Russell King - ARM Linux
2015-10-06  9:00                     ` Russell King - ARM Linux
2015-10-06  9:44                     ` Tony Lindgren
2015-10-06  9:44                       ` Tony Lindgren
2015-10-06 10:11                       ` Ulf Hansson
2015-10-06 10:11                         ` Ulf Hansson
2015-10-06 10:36                         ` Kishon Vijay Abraham I
2015-10-06 10:36                           ` Kishon Vijay Abraham I
2015-10-06 15:07                           ` Russell King - ARM Linux
2015-10-06 15:07                             ` Russell King - ARM Linux
2015-10-06 19:29                             ` Kishon Vijay Abraham I
2015-10-06 19:29                               ` Kishon Vijay Abraham I
2015-10-06 19:57                               ` Russell King - ARM Linux
2015-10-06 19:57                                 ` Russell King - ARM Linux
2015-10-08  0:46                                 ` Kishon Vijay Abraham I
2015-10-08  0:46                                   ` Kishon Vijay Abraham I
2015-10-06 15:00                       ` Russell King - ARM Linux
2015-10-06 15:00                         ` Russell King - ARM Linux
2015-10-06 15:37                         ` Tony Lindgren
2015-10-06 15:37                           ` Tony Lindgren
2015-10-07 12:45                           ` Russell King - ARM Linux
2015-10-07 12:45                             ` Russell King - ARM Linux
2015-10-07 13:26                             ` Tony Lindgren
2015-10-07 13:26                               ` Tony Lindgren
2015-10-07 13:41                               ` Ulf Hansson
2015-10-07 13:41                                 ` Ulf Hansson
2015-10-07 15:52                                 ` Tony Lindgren
2015-10-07 15:52                                   ` Tony Lindgren
2015-10-07 19:40                                   ` Ulf Hansson
2015-10-07 19:40                                     ` Ulf Hansson
2015-10-07 23:13                                     ` Kishon Vijay Abraham I [this message]
2015-10-07 23:13                                       ` Kishon Vijay Abraham I
2015-10-08  8:40                                       ` Tony Lindgren
2015-10-08  8:40                                         ` Tony Lindgren
2015-10-08  9:35                                         ` Russell King - ARM Linux
2015-10-08  9:35                                           ` Russell King - ARM Linux
2015-10-08  9:56                                           ` Tony Lindgren
2015-10-08  9:56                                             ` Tony Lindgren
2015-10-08 10:00                                             ` Russell King - ARM Linux
2015-10-08 10:00                                               ` Russell King - ARM Linux
2015-10-07 17:53                                 ` Russell King - ARM Linux
2015-10-07 17:53                                   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5615A723.6090907@ti.com \
    --to=kishon@ti.com \
    --cc=arm@kernel.org \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.