All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3
Date: Fri, 04 Dec 2015 22:36:31 +0100	[thread overview]
Message-ID: <5617214.abxPrpfVaF@wuerfel> (raw)
In-Reply-To: <20151204184706.GO23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

On Friday 04 December 2015 10:47:07 Tony Lindgren wrote:
> > Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> writes:
> > > @@ -174,12 +182,44 @@
> > >             };
> > >  
> > >             edma: edma@49000000 {
> > > -                   compatible = "ti,edma3";
> > > -                   ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
> > > -                   reg =   <0x49000000 0x10000>,
> > > -                           <0x44e10f90 0x40>;
> > > +                   compatible = "ti,edma3-tpcc";
> > > +                   ti,hwmods = "tpcc";
> > > +                   reg =   <0x49000000 0x10000>;
> > > +                   reg-names = "edma3_cc";
> > >                     interrupts = <12 13 14>;
> > > -                   #dma-cells = <1>;
> > > +                   interrupt-names = "edma3_ccint", "emda3_mperr",
> > > +                                     "edma3_ccerrint";
> > > +                   dma-requests = <64>;
> > > +                   #dma-cells = <2>;
> > > +
> > > +                   ti,tptcs = <&edma_tptc0 7>, <&edma_tptc1 5>,
> > > +                              <&edma_tptc2 0>;
> > > +
> > > +                   ti,edma-memcpy-channels = /bits/ 16 <20 21>;
> > 
> > can you explain this property here ? Are you setting bits 20 and 21 on a
> > 16-bit field ?
> 
> I think it's an arry of u16 dma channels.. But could it be just /bits/ 8
> instead of /bits/ 16?
> 

Please just drop the /bits/ 16 and use normal cells.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3
Date: Fri, 04 Dec 2015 22:36:31 +0100	[thread overview]
Message-ID: <5617214.abxPrpfVaF@wuerfel> (raw)
In-Reply-To: <20151204184706.GO23396@atomide.com>

On Friday 04 December 2015 10:47:07 Tony Lindgren wrote:
> > Peter Ujfalusi <peter.ujfalusi@ti.com> writes:
> > > @@ -174,12 +182,44 @@
> > >             };
> > >  
> > >             edma: edma at 49000000 {
> > > -                   compatible = "ti,edma3";
> > > -                   ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
> > > -                   reg =   <0x49000000 0x10000>,
> > > -                           <0x44e10f90 0x40>;
> > > +                   compatible = "ti,edma3-tpcc";
> > > +                   ti,hwmods = "tpcc";
> > > +                   reg =   <0x49000000 0x10000>;
> > > +                   reg-names = "edma3_cc";
> > >                     interrupts = <12 13 14>;
> > > -                   #dma-cells = <1>;
> > > +                   interrupt-names = "edma3_ccint", "emda3_mperr",
> > > +                                     "edma3_ccerrint";
> > > +                   dma-requests = <64>;
> > > +                   #dma-cells = <2>;
> > > +
> > > +                   ti,tptcs = <&edma_tptc0 7>, <&edma_tptc1 5>,
> > > +                              <&edma_tptc2 0>;
> > > +
> > > +                   ti,edma-memcpy-channels = /bits/ 16 <20 21>;
> > 
> > can you explain this property here ? Are you setting bits 20 and 21 on a
> > 16-bit field ?
> 
> I think it's an arry of u16 dma channels.. But could it be just /bits/ 8
> instead of /bits/ 16?
> 

Please just drop the /bits/ 16 and use normal cells.

	Arnd

  parent reply	other threads:[~2015-12-04 21:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 10:45 [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 Peter Ujfalusi
2015-12-04 10:45 ` Peter Ujfalusi
2015-12-04 17:21 ` Felipe Balbi
2015-12-04 17:21   ` Felipe Balbi
     [not found]   ` <87wpsunn82.fsf-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-12-04 18:47     ` Tony Lindgren
2015-12-04 18:47       ` Tony Lindgren
     [not found]       ` <20151204184706.GO23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-12-04 21:36         ` Arnd Bergmann [this message]
2015-12-04 21:36           ` Arnd Bergmann
2015-12-04 21:51           ` Tony Lindgren
2015-12-04 21:51             ` Tony Lindgren
     [not found]             ` <20151204215115.GP23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-12-08  7:42               ` Peter Ujfalusi
2015-12-08  7:42                 ` Peter Ujfalusi
     [not found]                 ` <566689E2.7060907-l0cyMroinI0@public.gmane.org>
2015-12-08  9:51                   ` Arnd Bergmann
2015-12-08  9:51                     ` Arnd Bergmann
2015-12-08 10:22                     ` Peter Ujfalusi
2015-12-08 10:22                       ` Peter Ujfalusi
     [not found]                       ` <5666AF51.9080306-l0cyMroinI0@public.gmane.org>
2015-12-08 10:25                         ` Arnd Bergmann
2015-12-08 10:25                           ` Arnd Bergmann
2015-12-08 15:51                           ` Tony Lindgren
2015-12-08 15:51                             ` Tony Lindgren
     [not found] ` <1449225915-28879-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-12-08  0:19   ` Tony Lindgren
2015-12-08  0:19     ` Tony Lindgren
     [not found]     ` <20151208001943.GT23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-12-08  7:43       ` Peter Ujfalusi
2015-12-08  7:43         ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5617214.abxPrpfVaF@wuerfel \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.