All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3
Date: Tue, 8 Dec 2015 12:22:09 +0200	[thread overview]
Message-ID: <5666AF51.9080306@ti.com> (raw)
In-Reply-To: <4387766.cHF7OBX0cm@wuerfel>

On 12/08/2015 11:51 AM, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 09:42:26 Peter Ujfalusi wrote:
>> On 12/04/2015 11:51 PM, Tony Lindgren wrote:
>>>>
>>>> Please just drop the /bits/ 16 and use normal cells.
>>>
>>> Yeah agreed, makes things less confusing for sure 
>>
>> 4.4 will be the first kernel where we will have the new eDMA bindings. I have
>> chosen to use 16bit array for specifying the channels used for memcpy
>> (ti,edma-memcpy-channels) and for the reserving paRAM slots
>> (ti,edma-reserved-slot-ranges). As of now we have maximum of 64 channels and
>> 512 paRAM slots. 16bit is more than enough to store this information and it
>> even gives us enough room if ever in the future these numbers are going to
>> increase (which  they are not).
>>
>> But in order to change them to 32bit the driver needs to be changed as well.
>> Currently we do not have drivers (in 4.4) using the new bindings, 4.4 is not
>> yet out, so it might be possible to change the binding document and the driver
>> to use 32bit arrays. The driver internally uses 16bit type for these which I'm
>> not going to change, but the code parsing the DT needs to be adjusted for the
>> new data type.
>>
>> If Vinod is willing to take update for the DT binding of eDMA for 4.4-rc, I
>> can cook up the patch(es) to do so.
> 
> I hadn't realized that it was already in 4.4-rc. The change should be trivial
> enough though, so I'd still do it. If Vinod would rather not change it now,
> it's not overly important though.

But this change must be done before we have actual users of these properties,
which is the am33xx, am437x and the da850 conversion series I have sent recently.
We might want to have this changed for 4.4 since it is going to be an LTS
release...

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3
Date: Tue, 8 Dec 2015 12:22:09 +0200	[thread overview]
Message-ID: <5666AF51.9080306@ti.com> (raw)
In-Reply-To: <4387766.cHF7OBX0cm@wuerfel>

On 12/08/2015 11:51 AM, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 09:42:26 Peter Ujfalusi wrote:
>> On 12/04/2015 11:51 PM, Tony Lindgren wrote:
>>>>
>>>> Please just drop the /bits/ 16 and use normal cells.
>>>
>>> Yeah agreed, makes things less confusing for sure 
>>
>> 4.4 will be the first kernel where we will have the new eDMA bindings. I have
>> chosen to use 16bit array for specifying the channels used for memcpy
>> (ti,edma-memcpy-channels) and for the reserving paRAM slots
>> (ti,edma-reserved-slot-ranges). As of now we have maximum of 64 channels and
>> 512 paRAM slots. 16bit is more than enough to store this information and it
>> even gives us enough room if ever in the future these numbers are going to
>> increase (which  they are not).
>>
>> But in order to change them to 32bit the driver needs to be changed as well.
>> Currently we do not have drivers (in 4.4) using the new bindings, 4.4 is not
>> yet out, so it might be possible to change the binding document and the driver
>> to use 32bit arrays. The driver internally uses 16bit type for these which I'm
>> not going to change, but the code parsing the DT needs to be adjusted for the
>> new data type.
>>
>> If Vinod is willing to take update for the DT binding of eDMA for 4.4-rc, I
>> can cook up the patch(es) to do so.
> 
> I hadn't realized that it was already in 4.4-rc. The change should be trivial
> enough though, so I'd still do it. If Vinod would rather not change it now,
> it's not overly important though.

But this change must be done before we have actual users of these properties,
which is the am33xx, am437x and the da850 conversion series I have sent recently.
We might want to have this changed for 4.4 since it is going to be an LTS
release...

-- 
P?ter

  reply	other threads:[~2015-12-08 10:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 10:45 [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 Peter Ujfalusi
2015-12-04 10:45 ` Peter Ujfalusi
2015-12-04 17:21 ` Felipe Balbi
2015-12-04 17:21   ` Felipe Balbi
     [not found]   ` <87wpsunn82.fsf-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-12-04 18:47     ` Tony Lindgren
2015-12-04 18:47       ` Tony Lindgren
     [not found]       ` <20151204184706.GO23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-12-04 21:36         ` Arnd Bergmann
2015-12-04 21:36           ` Arnd Bergmann
2015-12-04 21:51           ` Tony Lindgren
2015-12-04 21:51             ` Tony Lindgren
     [not found]             ` <20151204215115.GP23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-12-08  7:42               ` Peter Ujfalusi
2015-12-08  7:42                 ` Peter Ujfalusi
     [not found]                 ` <566689E2.7060907-l0cyMroinI0@public.gmane.org>
2015-12-08  9:51                   ` Arnd Bergmann
2015-12-08  9:51                     ` Arnd Bergmann
2015-12-08 10:22                     ` Peter Ujfalusi [this message]
2015-12-08 10:22                       ` Peter Ujfalusi
     [not found]                       ` <5666AF51.9080306-l0cyMroinI0@public.gmane.org>
2015-12-08 10:25                         ` Arnd Bergmann
2015-12-08 10:25                           ` Arnd Bergmann
2015-12-08 15:51                           ` Tony Lindgren
2015-12-08 15:51                             ` Tony Lindgren
     [not found] ` <1449225915-28879-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-12-08  0:19   ` Tony Lindgren
2015-12-08  0:19     ` Tony Lindgren
     [not found]     ` <20151208001943.GT23396-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-12-08  7:43       ` Peter Ujfalusi
2015-12-08  7:43         ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5666AF51.9080306@ti.com \
    --to=peter.ujfalusi-l0cymroini0@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.