* [PATCH 1/1] x86/io_apic: suppress compiler warning
@ 2015-10-08 15:55 Andy Shevchenko
2015-10-09 2:38 ` Jiang Liu
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2015-10-08 15:55 UTC (permalink / raw)
To: linux-kernel, Thomas Gleixner, Ingo Molnar, Jiang Liu, x86
Cc: Andy Shevchenko
We have to define internally used function as static, otherwise the following
warning will be generated:
arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 5c60bb1..b5a0e3c 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
}
}
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
{
unsigned long flags;
struct irq_pin_list *entry;
--
2.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] x86/io_apic: suppress compiler warning
2015-10-08 15:55 [PATCH 1/1] x86/io_apic: suppress compiler warning Andy Shevchenko
@ 2015-10-09 2:38 ` Jiang Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jiang Liu @ 2015-10-09 2:38 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel, Thomas Gleixner, Ingo Molnar, x86
On 2015/10/8 23:55, Andy Shevchenko wrote:
> We have to define internally used function as static, otherwise the following
> warning will be generated:
>
> arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]
Hi Andy,
Thanks for fixing this.
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/kernel/apic/io_apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 5c60bb1..b5a0e3c 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
> }
> }
>
> -void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
> +static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
> {
> unsigned long flags;
> struct irq_pin_list *entry;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-09 2:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-08 15:55 [PATCH 1/1] x86/io_apic: suppress compiler warning Andy Shevchenko
2015-10-09 2:38 ` Jiang Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.