From: Richard Henderson <rth@twiddle.net>
To: Chen Gang <xili_gchen_5257@hotmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register
Date: Sat, 10 Oct 2015 09:10:34 +1100 [thread overview]
Message-ID: <56183B5A.5060808@twiddle.net> (raw)
In-Reply-To: <COL130-W508D019C5051265EB08341B9350@phx.gbl>
On 10/09/2015 09:48 AM, Chen Gang wrote:
> On 10/7/15 18:17, Chen Gang wrote:
>> On 10/7/15 17:19, Richard Henderson wrote:
>>> On 10/04/2015 10:15 PM, Chen Gang wrote:
>>>>> From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001
>>>> From: Chen Gang<gang.chen.5i5j@gmail.com>
>>>> Date: Sun, 4 Oct 2015 17:34:17 +0800
>>>> Subject: [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register
>>>>
>>>> Or it will cause issue by the dest temporary registers.
>>>>
>>>> Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
>>>> ---
>>>> target-tilegx/translate.c | 85 +++++++++++++++++++++++++----------------------
>>>> 1 file changed, 46 insertions(+), 39 deletions(-)
>>>
>>> Isn't my patch 14/14 from the last patch set sufficient?
>>>
>
> At present, all patches (include 14/14) are integrated into master tree,
> so I guess, we have to integrate this patch into master tree next, it
> fix the dest temporary registers' issue.
What issue? The prefetch instructions "load" to the zero register,
which is never written back to the register file.
r~
next prev parent reply other threads:[~2015-10-09 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 11:15 [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register Chen Gang
2015-10-07 9:19 ` Richard Henderson
2015-10-07 10:17 ` Chen Gang
[not found] ` <5616F327.5020402@hotmail.com>
2015-10-08 22:48 ` Chen Gang
2015-10-09 22:10 ` Richard Henderson [this message]
2015-10-09 22:50 ` Chen Gang
2015-10-10 16:12 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56183B5A.5060808@twiddle.net \
--to=rth@twiddle.net \
--cc=cmetcalf@ezchip.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.