All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Steve deRosier <derosier@cal-sierra.com>,
	Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Zhi Chen <zhichen@codeaurora.org>,
	John Crispin <john@phrozen.org>,
	Sebastian Gottschall <s.gottschall@newmedia-net.de>,
	Ansuel Smith <ansuelsmth@gmail.com>
Subject: Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
Date: Wed, 03 Apr 2019 15:04:10 +0200	[thread overview]
Message-ID: <5618478.dNoBKn3uCK@bentobox> (raw)
In-Reply-To: <8736mzuvbz.fsf@kamboji.qca.qualcomm.com>


[-- Attachment #1.1: Type: text/plain, Size: 1315 bytes --]

On Wednesday, 3 April 2019 14:28:16 CEST Kalle Valo wrote:
[...]
> I'm planning to apply this. I was not sure what you wanted to add to the
> commit log but I changed to now what's below. Please let me know if you
> want to change it.
> 
>     ath10k: fix incorrect multicast/broadcast rate setting
>     
>     Invalid rate code is sent to firmware when multicast rate value of 0 is
>     sent to driver indicating disabled case, causing broken mesh path.
>     so fix that.
>     
>     Tested on QCA9984 with firmware 10.4-3.6.1-00827
>     
>     Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
>     (ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
>     
>     Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
>     Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
>     Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
>     Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
>     Tested-by: Sven Eckelmann <sven@narfation.org>
>     Patchwork-Id: 10723033
>     Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

I thought you just wanted to have this information added to the "Tested on " 
line by him. So I didn't really invest time to propose a new paragraph.

The new paragraph is fine for me.

Kind regards,
	Sven

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Ansuel Smith <ansuelsmth@gmail.com>,
	Steve deRosier <derosier@cal-sierra.com>,
	Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Zhi Chen <zhichen@codeaurora.org>,
	John Crispin <john@phrozen.org>,
	Sebastian Gottschall <s.gottschall@newmedia-net.de>
Subject: Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
Date: Wed, 03 Apr 2019 15:04:10 +0200	[thread overview]
Message-ID: <5618478.dNoBKn3uCK@bentobox> (raw)
In-Reply-To: <8736mzuvbz.fsf@kamboji.qca.qualcomm.com>

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Wednesday, 3 April 2019 14:28:16 CEST Kalle Valo wrote:
[...]
> I'm planning to apply this. I was not sure what you wanted to add to the
> commit log but I changed to now what's below. Please let me know if you
> want to change it.
> 
>     ath10k: fix incorrect multicast/broadcast rate setting
>     
>     Invalid rate code is sent to firmware when multicast rate value of 0 is
>     sent to driver indicating disabled case, causing broken mesh path.
>     so fix that.
>     
>     Tested on QCA9984 with firmware 10.4-3.6.1-00827
>     
>     Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
>     (ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
>     
>     Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
>     Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
>     Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
>     Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
>     Tested-by: Sven Eckelmann <sven@narfation.org>
>     Patchwork-Id: 10723033
>     Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

I thought you just wanted to have this information added to the "Tested on " 
line by him. So I didn't really invest time to propose a new paragraph.

The new paragraph is fine for me.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-04-03 13:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  4:56 [PATCH] ath10k: fix incorrect multicast/broadcast rate setting Pradeep Kumar Chitrapu
2018-12-11  4:56 ` Pradeep Kumar Chitrapu
2018-12-11 19:22 ` Peter Oh
2018-12-11 19:22   ` Peter Oh
2019-02-07 14:42   ` Kalle Valo
2019-02-07 14:42     ` Kalle Valo
2019-02-25 20:00 ` Sven Eckelmann
2019-02-25 20:00   ` Sven Eckelmann
2019-02-26  9:23   ` Sven Eckelmann
2019-02-26  9:23     ` Sven Eckelmann
2019-04-03 12:28     ` Kalle Valo
2019-04-03 12:28       ` Kalle Valo
2019-04-03 13:04       ` Sven Eckelmann [this message]
2019-04-03 13:04         ` Sven Eckelmann
2019-04-29 14:43 ` Kalle Valo
2019-04-29 14:43 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5618478.dNoBKn3uCK@bentobox \
    --to=sven@narfation.org \
    --cc=ansuelsmth@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=derosier@cal-sierra.com \
    --cc=john@phrozen.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    --cc=s.gottschall@newmedia-net.de \
    --cc=zhichen@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.