From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: "mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"10.0"
<mesa-stable-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] nv50, nvc0: don't base decisions on available pushbuf space
Date: Sat, 10 Oct 2015 22:21:26 +0200 [thread overview]
Message-ID: <56197346.4030606@gmail.com> (raw)
In-Reply-To: <CAKb7UvhaZn2tK9ejZ7ard79gHuxoWJRi+hLU=P6+psZSqT-sZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 10/10/2015 09:58 PM, Ilia Mirkin wrote:
> On Sat, Oct 10, 2015 at 3:55 PM, Samuel Pitoiset
> <samuel.pitoiset@gmail.com> wrote:
>>
>> On 10/10/2015 09:42 PM, Ilia Mirkin wrote:
>>> On Sat, Oct 10, 2015 at 3:41 PM, Samuel Pitoiset
>>> <samuel.pitoiset@gmail.com> wrote:
>>>> This patch looks fine except that it should be a bit more normalized. I
>>>> mean, sometimes you break when PUSH_SPACE fails, sometimes not. Same for
>>>> PUSH_SPACE calls, sometimes you add it sometimes not.
>>> Meh. We need to get our error checking situation straight, but this
>>> isn't the patch to do it in.
>>
>> Yeah, but this needs to be clarified.
> What does?
I mean, we should either use PUSH_SPACE everywhere or not at all, and
always breaks (or not) when PUSH_SPACE fails.
That's really a minor issue.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2015-10-10 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 9:09 [PATCH] nv50, nvc0: don't base decisions on available pushbuf space Ilia Mirkin
2015-10-10 19:41 ` [Nouveau] " Samuel Pitoiset
[not found] ` <561969F1.9080706-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-10 19:42 ` Ilia Mirkin
[not found] ` <CAKb7UvgWEKVA1TWqU-Bcu=VmunnXot_Sqp11F7XC_mOowVqTUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-10 19:55 ` Samuel Pitoiset
[not found] ` <56196D35.2040203-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-10 19:58 ` Ilia Mirkin
[not found] ` <CAKb7UvhaZn2tK9ejZ7ard79gHuxoWJRi+hLU=P6+psZSqT-sZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-10 20:21 ` Samuel Pitoiset [this message]
[not found] ` <56197346.4030606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-10 20:17 ` Ilia Mirkin
2015-10-10 20:29 ` [Nouveau] " Samuel Pitoiset
[not found] ` <1444468187-13868-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-10-11 15:05 ` Samuel Pitoiset
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56197346.4030606@gmail.com \
--to=samuel.pitoiset-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
--cc=mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=mesa-stable-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.