From: m-karicheri2@ti.com (Murali Karicheri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document
Date: Tue, 13 Oct 2015 11:44:21 -0400 [thread overview]
Message-ID: <561D26D5.7060405@ti.com> (raw)
In-Reply-To: <CAL_Jsq+GZn0X-sxQ=oqRP7fR3bCPk5PN5CjgXzjnOxas_renzw@mail.gmail.com>
On 10/13/2015 10:42 AM, Rob Herring wrote:
> On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
>> Currently the DT bindings have details about the driver as well. This
>> patch moves this to a separate document for knav qmss driver so that
>> driver detail update can be done as needed without polluting the DT
>> bindings description.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>> Documentation/arm/keystone/knav-qmss.txt | 24 ++++++++++++++++++++++
>> .../bindings/soc/ti/keystone-navigator-qmss.txt | 20 ++++--------------
>> 2 files changed, 28 insertions(+), 16 deletions(-)
>> create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>>
>> diff --git a/Documentation/arm/keystone/knav-qmss.txt b/Documentation/arm/keystone/knav-qmss.txt
>> new file mode 100644
>> index 0000000..79946d1
>> --- /dev/null
>> +++ b/Documentation/arm/keystone/knav-qmss.txt
>> @@ -0,0 +1,24 @@
>> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> +
>> +Driver source code path
>> + drivers/soc/ti/knav_qmss.c
>> + drivers/soc/ti/knav_qmss_acc.c
>> +
>> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> +the main hardware sub system which forms the backbone of the Keystone
>> +multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> +processors(PDSP), linking RAM, descriptor pools and infrastructure
>> +Packet DMA.
>> +The Queue Manager is a hardware module that is responsible for accelerating
>> +management of the packet queues. Packets are queued/de-queued by writing or
>> +reading descriptor address to a particular memory mapped location. The PDSPs
>> +perform QMSS related functions like accumulation, QoS, or event management.
>> +Linking RAM registers are used to link the descriptors which are stored in
>> +descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> +The QMSS driver manages the PDSP setups, linking RAM regions,
>> +queue pool management (allocation, push, pop and notify) and descriptor
>> +pool management.
>> +
>> +knav qmss driver provides a set of APIs to drivers to open/close qmss queues,
>> +allocate descriptor pools, map the descriptors, push/pop to queues etc. For
>> +details of the available APIs, please refers to include/linux/soc/ti/knav_qmss.h
>> diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> index d8e8cdb..2cecea1 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> +++ b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> @@ -1,20 +1,8 @@
>> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> -
>> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> -the main hardware sub system which forms the backbone of the Keystone
>> -multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> -processors(PDSP), linking RAM, descriptor pools and infrastructure
>> -Packet DMA.
>> -The Queue Manager is a hardware module that is responsible for accelerating
>> -management of the packet queues. Packets are queued/de-queued by writing or
>> -reading descriptor address to a particular memory mapped location. The PDSPs
>> -perform QMSS related functions like accumulation, QoS, or event management.
>> -Linking RAM registers are used to link the descriptors which are stored in
>> -descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> -The QMSS driver manages the PDSP setups, linking RAM regions,
>> -queue pool management (allocation, push, pop and notify) and descriptor
>> -pool management.
>
> Only the last sentence seems to be about the driver and is rather
> obvious (a driver manages the h/w). I would leave all this as-is
> currently.
>
> Rob
>
Rob,
I promise I will fix this in my next opportunity. Also there is similar
clean up needed for knav dma DT documentation and Netcp documentations.
It is in my TODO list.
Thanks.
Murali
>> +* Texas Instruments Keystone Navigator (knav) Queue Management SubSystem driver
>> + DT bindings
>>
>> +For details of the driver, please refer to
>> +Documentation/arm/keystone/knav-qmss.txt
>>
>> Required properties:
>> - compatible : Must be "ti,keystone-navigator-qmss";
>> --
>> 1.9.1
>>
>
>
--
Murali Karicheri
Linux Kernel, Keystone
WARNING: multiple messages have this Message-ID (diff)
From: Murali Karicheri <m-karicheri2@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Santosh Shilimkar <ssantosh@kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document
Date: Tue, 13 Oct 2015 11:44:21 -0400 [thread overview]
Message-ID: <561D26D5.7060405@ti.com> (raw)
In-Reply-To: <CAL_Jsq+GZn0X-sxQ=oqRP7fR3bCPk5PN5CjgXzjnOxas_renzw@mail.gmail.com>
On 10/13/2015 10:42 AM, Rob Herring wrote:
> On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
>> Currently the DT bindings have details about the driver as well. This
>> patch moves this to a separate document for knav qmss driver so that
>> driver detail update can be done as needed without polluting the DT
>> bindings description.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>> Documentation/arm/keystone/knav-qmss.txt | 24 ++++++++++++++++++++++
>> .../bindings/soc/ti/keystone-navigator-qmss.txt | 20 ++++--------------
>> 2 files changed, 28 insertions(+), 16 deletions(-)
>> create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>>
>> diff --git a/Documentation/arm/keystone/knav-qmss.txt b/Documentation/arm/keystone/knav-qmss.txt
>> new file mode 100644
>> index 0000000..79946d1
>> --- /dev/null
>> +++ b/Documentation/arm/keystone/knav-qmss.txt
>> @@ -0,0 +1,24 @@
>> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> +
>> +Driver source code path
>> + drivers/soc/ti/knav_qmss.c
>> + drivers/soc/ti/knav_qmss_acc.c
>> +
>> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> +the main hardware sub system which forms the backbone of the Keystone
>> +multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> +processors(PDSP), linking RAM, descriptor pools and infrastructure
>> +Packet DMA.
>> +The Queue Manager is a hardware module that is responsible for accelerating
>> +management of the packet queues. Packets are queued/de-queued by writing or
>> +reading descriptor address to a particular memory mapped location. The PDSPs
>> +perform QMSS related functions like accumulation, QoS, or event management.
>> +Linking RAM registers are used to link the descriptors which are stored in
>> +descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> +The QMSS driver manages the PDSP setups, linking RAM regions,
>> +queue pool management (allocation, push, pop and notify) and descriptor
>> +pool management.
>> +
>> +knav qmss driver provides a set of APIs to drivers to open/close qmss queues,
>> +allocate descriptor pools, map the descriptors, push/pop to queues etc. For
>> +details of the available APIs, please refers to include/linux/soc/ti/knav_qmss.h
>> diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> index d8e8cdb..2cecea1 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> +++ b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> @@ -1,20 +1,8 @@
>> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> -
>> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> -the main hardware sub system which forms the backbone of the Keystone
>> -multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> -processors(PDSP), linking RAM, descriptor pools and infrastructure
>> -Packet DMA.
>> -The Queue Manager is a hardware module that is responsible for accelerating
>> -management of the packet queues. Packets are queued/de-queued by writing or
>> -reading descriptor address to a particular memory mapped location. The PDSPs
>> -perform QMSS related functions like accumulation, QoS, or event management.
>> -Linking RAM registers are used to link the descriptors which are stored in
>> -descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> -The QMSS driver manages the PDSP setups, linking RAM regions,
>> -queue pool management (allocation, push, pop and notify) and descriptor
>> -pool management.
>
> Only the last sentence seems to be about the driver and is rather
> obvious (a driver manages the h/w). I would leave all this as-is
> currently.
>
> Rob
>
Rob,
I promise I will fix this in my next opportunity. Also there is similar
clean up needed for knav dma DT documentation and Netcp documentations.
It is in my TODO list.
Thanks.
Murali
>> +* Texas Instruments Keystone Navigator (knav) Queue Management SubSystem driver
>> + DT bindings
>>
>> +For details of the driver, please refer to
>> +Documentation/arm/keystone/knav-qmss.txt
>>
>> Required properties:
>> - compatible : Must be "ti,keystone-navigator-qmss";
>> --
>> 1.9.1
>>
>
>
--
Murali Karicheri
Linux Kernel, Keystone
next prev parent reply other threads:[~2015-10-13 15:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 19:46 [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-13 14:42 ` Rob Herring
2015-10-13 14:42 ` Rob Herring
2015-10-13 15:44 ` Murali Karicheri [this message]
2015-10-13 15:44 ` Murali Karicheri
2015-10-13 17:28 ` Murali Karicheri
2015-10-13 17:28 ` Murali Karicheri
2015-10-13 17:28 ` Murali Karicheri
2015-10-13 18:01 ` Rob Herring
2015-10-13 18:01 ` Rob Herring
2015-10-13 18:21 ` Murali Karicheri
2015-10-13 18:21 ` Murali Karicheri
2015-10-12 19:46 ` [PATCH v2 2/4] soc: ti: add firmware file name as part of the driver Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-13 14:32 ` Arnd Bergmann
2015-10-13 14:32 ` Arnd Bergmann
2015-10-13 14:38 ` Rob Herring
2015-10-12 19:46 ` [PATCH v2 3/4] ARM: dts: keystone: enable accumulator channels Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` [PATCH 4/4] soc: ti: qmss: make acc queue support optional in the driver Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:46 ` Murali Karicheri
2015-10-12 19:54 ` [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri
2015-10-12 19:54 ` Murali Karicheri
2015-10-12 19:54 ` Murali Karicheri
2015-10-13 13:56 ` Murali Karicheri
2015-10-13 13:56 ` Murali Karicheri
2015-10-13 13:56 ` Murali Karicheri
2015-10-13 16:01 ` santosh shilimkar
2015-10-13 16:01 ` santosh shilimkar
2015-10-13 16:14 ` Murali Karicheri
2015-10-13 16:14 ` Murali Karicheri
2015-10-13 16:14 ` Murali Karicheri
2015-10-13 16:21 ` santosh shilimkar
2015-10-13 16:21 ` santosh shilimkar
2015-10-13 16:42 ` Murali Karicheri
2015-10-13 16:42 ` Murali Karicheri
2015-10-13 16:42 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D26D5.7060405@ti.com \
--to=m-karicheri2@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.