All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver
Date: Wed, 14 Oct 2015 16:28:23 +0100	[thread overview]
Message-ID: <561E7497.1050105@linaro.org> (raw)
In-Reply-To: <CAOAejn1spB+BCRh9+jJtaKxEmaRc04nveF3rQEbT7kLMH0kOkg@mail.gmail.com>

On 14/10/15 16:26, M'boumba Cedric Madianga wrote:
> 2015-10-14 16:24 GMT+02:00 Daniel Thompson <daniel.thompson@linaro.org>:
>>
>> Hmnnn...
>>
>> The dmaengine framework will WARN_ONCE() if an dmaengine is removed whilst
>> it is active and also works hard to ensure dmaengine modules are not removed
>> whilst there are active drivers using the framework.
>>
>> How do we get into this function whilst there is still an active DMA
>> channels?
>
> For example, when a user try "rmmod stm32-dma" in uart console.
> It will enter in stm32_dma_remove while there is potentially still active DMA.

Check dmaengine.c for yourself but I think in this case the dmaengine 
framework will hold references to the module and prevent the remove from 
taking place.


Daniel.

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	robh+dt@kernel.org, pawel.moll@arm.com,
	Mark Rutland <mark.rutland@arm.com>,
	ijc+devicetree@hellion.org.uk, Kumar Gala <galak@codeaurora.org>,
	linux@arm.linux.org.uk, Vinod Koul <vinod.koul@intel.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver
Date: Wed, 14 Oct 2015 16:28:23 +0100	[thread overview]
Message-ID: <561E7497.1050105@linaro.org> (raw)
In-Reply-To: <CAOAejn1spB+BCRh9+jJtaKxEmaRc04nveF3rQEbT7kLMH0kOkg@mail.gmail.com>

On 14/10/15 16:26, M'boumba Cedric Madianga wrote:
> 2015-10-14 16:24 GMT+02:00 Daniel Thompson <daniel.thompson@linaro.org>:
>>
>> Hmnnn...
>>
>> The dmaengine framework will WARN_ONCE() if an dmaengine is removed whilst
>> it is active and also works hard to ensure dmaengine modules are not removed
>> whilst there are active drivers using the framework.
>>
>> How do we get into this function whilst there is still an active DMA
>> channels?
>
> For example, when a user try "rmmod stm32-dma" in uart console.
> It will enter in stm32_dma_remove while there is potentially still active DMA.

Check dmaengine.c for yourself but I think in this case the dmaengine 
framework will hold references to the module and prevent the remove from 
taking place.


Daniel.

  reply	other threads:[~2015-10-14 15:28 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 14:05 [PATCH v2 0/4] Add support for STM32 DMA M'boumba Cedric Madianga
2015-10-13 14:05 ` M'boumba Cedric Madianga
2015-10-13 14:05 ` [PATCH v2 1/4] dt-bindings: Document the STM32 DMA bindings M'boumba Cedric Madianga
2015-10-13 14:05   ` M'boumba Cedric Madianga
2015-10-14  8:54   ` M'boumba Cedric Madianga
2015-10-14  8:54     ` M'boumba Cedric Madianga
2015-10-13 14:05 ` [PATCH v2 2/4] dmaengine: Add STM32 DMA driver M'boumba Cedric Madianga
2015-10-13 14:05   ` M'boumba Cedric Madianga
2015-10-13 14:34   ` Daniel Thompson
2015-10-13 14:34     ` Daniel Thompson
2015-10-13 14:34     ` Daniel Thompson
2015-10-14  7:54     ` M'boumba Cedric Madianga
2015-10-14  7:54       ` M'boumba Cedric Madianga
2015-10-14  7:54       ` M'boumba Cedric Madianga
2015-10-14  8:52       ` Daniel Thompson
2015-10-14  8:52         ` Daniel Thompson
2015-10-14  8:57         ` M'boumba Cedric Madianga
2015-10-14  8:57           ` M'boumba Cedric Madianga
2015-10-14  8:57           ` M'boumba Cedric Madianga
2015-10-14 13:17       ` M'boumba Cedric Madianga
2015-10-14 13:17         ` M'boumba Cedric Madianga
2015-10-14 13:29         ` Daniel Thompson
2015-10-14 13:29           ` Daniel Thompson
2015-10-14 13:29           ` Daniel Thompson
2015-10-14 13:41           ` M'boumba Cedric Madianga
2015-10-14 13:41             ` M'boumba Cedric Madianga
2015-10-14 14:24             ` Daniel Thompson
2015-10-14 14:24               ` Daniel Thompson
2015-10-14 15:26               ` M'boumba Cedric Madianga
2015-10-14 15:26                 ` M'boumba Cedric Madianga
2015-10-14 15:26                 ` M'boumba Cedric Madianga
2015-10-14 15:28                 ` Daniel Thompson [this message]
2015-10-14 15:28                   ` Daniel Thompson
2015-10-14 15:41                   ` M'boumba Cedric Madianga
2015-10-14 15:41                     ` M'boumba Cedric Madianga
2015-10-14 15:41                     ` M'boumba Cedric Madianga
2015-10-15  4:07                     ` Vinod Koul
2015-10-15  4:07                       ` Vinod Koul
2015-10-15  4:07                       ` Vinod Koul
2015-10-14 11:16   ` Vinod Koul
2015-10-14 11:16     ` Vinod Koul
2015-10-14 11:16     ` Vinod Koul
2015-10-14 13:07     ` M'boumba Cedric Madianga
2015-10-14 13:07       ` M'boumba Cedric Madianga
2015-10-14 14:14       ` Vinod Koul
2015-10-14 14:14         ` Vinod Koul
2015-10-14 14:14         ` Vinod Koul
2015-10-13 14:05 ` [PATCH v2 3/4] ARM: dts: Add STM32 DMA support for STM32F429 MCU M'boumba Cedric Madianga
2015-10-13 14:05   ` M'boumba Cedric Madianga
2015-10-13 14:05 ` [PATCH v2 4/4] ARM: configs: Add STM32 DMA support in STM32 defconfig M'boumba Cedric Madianga
2015-10-13 14:05   ` M'boumba Cedric Madianga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561E7497.1050105@linaro.org \
    --to=daniel.thompson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.