From: Hannes Reinecke <hare@suse.de>
To: Arnd Bergmann <arnd@arndb.de>,
linux-scsi@vger.kernel.org, JBottomley@odin.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: advansys needs ISA dma api for ISA support
Date: Thu, 15 Oct 2015 14:06:15 +0200 [thread overview]
Message-ID: <561F96B7.4050300@suse.de> (raw)
In-Reply-To: <5081546.QjQ32dGX2L@wuerfel>
On 10/12/2015 05:10 PM, Arnd Bergmann wrote:
> The advansys drvier uses the request_dma function that is used on ISA
> machines for the internal DMA controller, which causes build errors
> on platforms that have ISA slots but do not provide the ISA DMA API:
>
> drivers/scsi/advansys.c: In function 'advansys_board_found':
> drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
>
> The problem now showed up in ARM randconfig builds after commit
> 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
> warning") made it possible to build on platforms that have neither
> VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
>
> This adds the missing dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index d2f480b04a52..d4aa6a1a806c 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -499,6 +499,7 @@ config SCSI_ADVANSYS
> tristate "AdvanSys SCSI support"
> depends on SCSI
> depends on ISA || EISA || PCI
> + depends on ISA_DMA_API || !ISA
> help
> This is a driver for all SCSI host adapters manufactured by
> AdvanSys. It is documented in the kernel source in
>
Sorry to chime in again, but wouldn't this allow to build on platforms
which have neither ISA_DMA_API nor ISA, like oldish sparc systems with
proprietary S-BUS?
Why not ISA_DMA_API || EISA || PCI ?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hare@suse.de (Hannes Reinecke)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scsi: advansys needs ISA dma api for ISA support
Date: Thu, 15 Oct 2015 14:06:15 +0200 [thread overview]
Message-ID: <561F96B7.4050300@suse.de> (raw)
In-Reply-To: <5081546.QjQ32dGX2L@wuerfel>
On 10/12/2015 05:10 PM, Arnd Bergmann wrote:
> The advansys drvier uses the request_dma function that is used on ISA
> machines for the internal DMA controller, which causes build errors
> on platforms that have ISA slots but do not provide the ISA DMA API:
>
> drivers/scsi/advansys.c: In function 'advansys_board_found':
> drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
>
> The problem now showed up in ARM randconfig builds after commit
> 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
> warning") made it possible to build on platforms that have neither
> VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
>
> This adds the missing dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index d2f480b04a52..d4aa6a1a806c 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -499,6 +499,7 @@ config SCSI_ADVANSYS
> tristate "AdvanSys SCSI support"
> depends on SCSI
> depends on ISA || EISA || PCI
> + depends on ISA_DMA_API || !ISA
> help
> This is a driver for all SCSI host adapters manufactured by
> AdvanSys. It is documented in the kernel source in
>
Sorry to chime in again, but wouldn't this allow to build on platforms
which have neither ISA_DMA_API nor ISA, like oldish sparc systems with
proprietary S-BUS?
Why not ISA_DMA_API || EISA || PCI ?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Arnd Bergmann <arnd@arndb.de>,
linux-scsi@vger.kernel.org, JBottomley@odin.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: advansys needs ISA dma api for ISA support
Date: Thu, 15 Oct 2015 14:06:15 +0200 [thread overview]
Message-ID: <561F96B7.4050300@suse.de> (raw)
In-Reply-To: <5081546.QjQ32dGX2L@wuerfel>
On 10/12/2015 05:10 PM, Arnd Bergmann wrote:
> The advansys drvier uses the request_dma function that is used on ISA
> machines for the internal DMA controller, which causes build errors
> on platforms that have ISA slots but do not provide the ISA DMA API:
>
> drivers/scsi/advansys.c: In function 'advansys_board_found':
> drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
>
> The problem now showed up in ARM randconfig builds after commit
> 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
> warning") made it possible to build on platforms that have neither
> VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
>
> This adds the missing dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index d2f480b04a52..d4aa6a1a806c 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -499,6 +499,7 @@ config SCSI_ADVANSYS
> tristate "AdvanSys SCSI support"
> depends on SCSI
> depends on ISA || EISA || PCI
> + depends on ISA_DMA_API || !ISA
> help
> This is a driver for all SCSI host adapters manufactured by
> AdvanSys. It is documented in the kernel source in
>
Sorry to chime in again, but wouldn't this allow to build on platforms
which have neither ISA_DMA_API nor ISA, like oldish sparc systems with
proprietary S-BUS?
Why not ISA_DMA_API || EISA || PCI ?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2015-10-15 12:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:10 [PATCH] scsi: advansys needs ISA dma api for ISA support Arnd Bergmann
2015-10-12 15:10 ` Arnd Bergmann
2015-10-12 15:28 ` James Bottomley
2015-10-12 15:28 ` James Bottomley
2015-10-12 15:44 ` Arnd Bergmann
2015-10-12 15:44 ` Arnd Bergmann
2015-10-13 19:59 ` James Bottomley
2015-10-13 19:59 ` James Bottomley
2015-10-13 5:47 ` Hannes Reinecke
2015-10-13 5:47 ` Hannes Reinecke
2015-10-15 12:06 ` Hannes Reinecke [this message]
2015-10-15 12:06 ` Hannes Reinecke
2015-10-15 12:06 ` Hannes Reinecke
2015-10-15 12:09 ` Hannes Reinecke
2015-10-15 12:09 ` Hannes Reinecke
2015-10-15 15:04 ` Arnd Bergmann
2015-10-15 15:04 ` Arnd Bergmann
2015-10-16 11:49 ` Hannes Reinecke
2015-10-16 11:49 ` Hannes Reinecke
2015-10-16 11:49 ` Hannes Reinecke
2015-10-16 12:04 ` Arnd Bergmann
2015-10-16 12:04 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561F96B7.4050300@suse.de \
--to=hare@suse.de \
--cc=JBottomley@odin.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.