Re: [PATCH v1 2/2] ARM: dts: rockchip: Add the OTP gpio pinctrl

[Caesar Wang <wxt@rock-chips.com>]

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

Doug,

在 2015年10月21日 12:25, Doug Anderson 写道:
> Caesar,
>
> On Tue, Oct 20, 2015 at 7:43 PM, Caesar Wang <wxt@rock-chips.com> wrote:
>> We need the OTP pin is gpio state before resetting the TSADC controller,
>> since the tshut polarity will generate a high signal.
> It might or might not be "high" depending on polarity, right?  It's
> just possible that it could glitch during probe.  Other than that nit,
> this seems fine to me.

I think the description is right,   maybe need other decriptions.
The tshut *polarity* is low in a short period of time when the TSADC 
controller is reset.

In other words,

If T < (setting temperature), the OTP output the High Signal. ------> if the otp out polarity is high, the TSHUT will work.
If T > (setting temperature), the OTP output the Low Signal.


> If it's not too much trouble it'd be nice if you could spin with the
> description change.  Otherwise:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
>
>

-- 
Yours,
Caesar


[-- Attachment #2: Type: text/html, Size: 1913 bytes --]