All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Tom Herbert <therbert@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Cc: linux-parisc List <linux-parisc@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	John David Anglin <dave.anglin@bell.net>
Subject: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)
Date: Thu, 22 Oct 2015 22:00:11 +0200	[thread overview]
Message-ID: <5629404B.8090805@gmx.de> (raw)
In-Reply-To: <5628F868.3040105@bell.net>

Hi Tom & David,

I've queued-up a patch for the parisc architecture which reduces L1_CAC=
HE_BYTES from 32 to 16:
  https://patchwork.kernel.org/patch/7399291/

But this change will break the kernel build like this:

In file included from net/core/dev.c:92:0:
net/core/dev.c: In function =E2=80=98expand_xps_map=E2=80=99:
include/linux/netdevice.h:721:27: warning: overflow in implicit constan=
t conversion [-Woverflow]
   #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_map))=
 \
net/core/dev.c:1972:18: note: in expansion of macro =E2=80=98XPS_MIN_MA=
P_ALLOC=E2=80=99
   int alloc_len =3D XPS_MIN_MAP_ALLOC;

Do you see an easy way to fix this ?

Thanks,
Helge=20
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
 in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: Tom Herbert <therbert@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Cc: linux-parisc List <linux-parisc@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	John David Anglin <dave.anglin@bell.net>
Subject: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)
Date: Thu, 22 Oct 2015 22:00:11 +0200	[thread overview]
Message-ID: <5629404B.8090805@gmx.de> (raw)
In-Reply-To: <5628F868.3040105@bell.net>

Hi Tom & David,

I've queued-up a patch for the parisc architecture which reduces L1_CACHE_BYTES from 32 to 16:
  https://patchwork.kernel.org/patch/7399291/

But this change will break the kernel build like this:

In file included from net/core/dev.c:92:0:
net/core/dev.c: In function ‘expand_xps_map’:
include/linux/netdevice.h:721:27: warning: overflow in implicit constant conversion [-Woverflow]
   #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES - sizeof(struct xps_map)) \
net/core/dev.c:1972:18: note: in expansion of macro ‘XPS_MIN_MAP_ALLOC’
   int alloc_len = XPS_MIN_MAP_ALLOC;

Do you see an easy way to fix this ?

Thanks,
Helge 
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-10-22 20:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26 15:38 [PATCH][RFC] parisc: Change L1_CACHE_BYTES to 16 John David Anglin
2015-09-27 16:07 ` [PATCH v2][RFC] " John David Anglin
2015-09-27 16:17   ` James Bottomley
2015-09-27 16:46     ` John David Anglin
2015-10-15  0:32   ` [PATCH v3] " John David Anglin
2015-10-22 11:38     ` Aw: " Helge Deller
2015-10-22 11:53       ` Helge Deller
2015-10-22 14:35         ` James Bottomley
2015-10-22 14:53           ` John David Anglin
2015-10-22 20:00             ` Helge Deller [this message]
2015-10-22 20:00               ` CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map) Helge Deller
2015-10-22 21:37               ` Tom Herbert
2015-10-22 21:37                 ` Tom Herbert
2015-10-23 19:21                 ` Helge Deller
2015-10-23 19:21                   ` Helge Deller
2015-10-23 22:16                   ` Tom Herbert
2015-10-23 22:16                     ` Tom Herbert
2015-10-22 21:50               ` Eric Dumazet
2015-10-22 21:50                 ` Eric Dumazet
2015-10-23 19:25                 ` Helge Deller
2015-10-23 19:25                   ` Helge Deller
2015-10-23 20:03                   ` Eric Dumazet
2015-10-23 21:08                     ` Helge Deller
2015-10-23 21:09                       ` Helge Deller
2015-10-23 21:38                       ` Eric Dumazet
2015-10-23 22:00                       ` Alexander Duyck
2015-10-23 22:17                         ` Helge Deller
2015-10-23 22:40                           ` Alexander Duyck
2015-10-24 14:43                             ` Helge Deller
2015-10-25  5:41                               ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5629404B.8090805@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=davem@davemloft.net \
    --cc=linux-parisc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.