From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>, Arnd Bergmann <arnd@arndb.de>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
driverdev <devel@driverdev.osuosl.org>,
linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN
Date: Sun, 25 Oct 2015 12:16:32 +0000 [thread overview]
Message-ID: <562CC820.9060100@kernel.org> (raw)
In-Reply-To: <CAEnQRZDTP6Xut9hGLe4QpgdZJvumY0fESMc_aYWJ4TW3oHeUJw@mail.gmail.com>
On 19/10/15 09:16, Daniel Baluta wrote:
> On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The iio dummy code was recently changed to use irq_work_queue, but
>> that code is compiled into the kernel only if IRQ_WORK is set, so
>> we can get a link error here:
>>
>> drivers/built-in.o: In function `iio_evgen_poke':
>> (.text+0x208a04): undefined reference to `irq_work_queue'
>>
>> This changes the Kconfig file to match what other drivers do.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")
>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the fixes-togreg branch of iio.git. I fear this won't get to Linus
until just after the release occurs. Unfortunate timing.
Jonathan
>
>> ---
>> Found on ARM randconfig tests
>>
>> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>> index 6d5b38d69578..9d7f0004d2d7 100644
>> --- a/drivers/staging/iio/Kconfig
>> +++ b/drivers/staging/iio/Kconfig
>> @@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
>> source "drivers/staging/iio/trigger/Kconfig"
>>
>> config IIO_DUMMY_EVGEN
>> - tristate
>> + tristate
>> + select IRQ_WORK
>>
>> config IIO_SIMPLE_DUMMY
>> tristate "An example driver with no hardware requirements"
>>
>> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN
Date: Sun, 25 Oct 2015 12:16:32 +0000 [thread overview]
Message-ID: <562CC820.9060100@kernel.org> (raw)
In-Reply-To: <CAEnQRZDTP6Xut9hGLe4QpgdZJvumY0fESMc_aYWJ4TW3oHeUJw@mail.gmail.com>
On 19/10/15 09:16, Daniel Baluta wrote:
> On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The iio dummy code was recently changed to use irq_work_queue, but
>> that code is compiled into the kernel only if IRQ_WORK is set, so
>> we can get a link error here:
>>
>> drivers/built-in.o: In function `iio_evgen_poke':
>> (.text+0x208a04): undefined reference to `irq_work_queue'
>>
>> This changes the Kconfig file to match what other drivers do.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")
>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the fixes-togreg branch of iio.git. I fear this won't get to Linus
until just after the release occurs. Unfortunate timing.
Jonathan
>
>> ---
>> Found on ARM randconfig tests
>>
>> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>> index 6d5b38d69578..9d7f0004d2d7 100644
>> --- a/drivers/staging/iio/Kconfig
>> +++ b/drivers/staging/iio/Kconfig
>> @@ -18,7 +18,8 @@ source "drivers/staging/iio/resolver/Kconfig"
>> source "drivers/staging/iio/trigger/Kconfig"
>>
>> config IIO_DUMMY_EVGEN
>> - tristate
>> + tristate
>> + select IRQ_WORK
>>
>> config IIO_SIMPLE_DUMMY
>> tristate "An example driver with no hardware requirements"
>>
>> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-10-25 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 22:29 [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN Arnd Bergmann
2015-10-16 22:29 ` Arnd Bergmann
2015-10-19 8:16 ` Daniel Baluta
2015-10-19 8:16 ` Daniel Baluta
2015-10-25 12:16 ` Jonathan Cameron [this message]
2015-10-25 12:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562CC820.9060100@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=cristina.opriceana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.