* [PATCH] Staging: iio: cdc: Remove unused macros
@ 2015-10-07 20:38 Shraddha Barke
[not found] ` <561A6DCD.8000505@kernel.org>
0 siblings, 1 reply; 4+ messages in thread
From: Shraddha Barke @ 2015-10-07 20:38 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Jonathan Cameron
Remove the macros since they are not used anywhere throughout the
kernel.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/iio/cdc/ad7746.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 028b4e8..a4bb152 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -27,11 +27,7 @@
#define AD7746_REG_STATUS 0
#define AD7746_REG_CAP_DATA_HIGH 1
-#define AD7746_REG_CAP_DATA_MID 2
-#define AD7746_REG_CAP_DATA_LOW 3
#define AD7746_REG_VT_DATA_HIGH 4
-#define AD7746_REG_VT_DATA_MID 5
-#define AD7746_REG_VT_DATA_LOW 6
#define AD7746_REG_CAP_SETUP 7
#define AD7746_REG_VT_SETUP 8
#define AD7746_REG_EXC_SETUP 9
@@ -39,11 +35,8 @@
#define AD7746_REG_CAPDACA 11
#define AD7746_REG_CAPDACB 12
#define AD7746_REG_CAP_OFFH 13
-#define AD7746_REG_CAP_OFFL 14
#define AD7746_REG_CAP_GAINH 15
-#define AD7746_REG_CAP_GAINL 16
#define AD7746_REG_VOLT_GAINH 17
-#define AD7746_REG_VOLT_GAINL 18
/* Status Register Bit Designations (AD7746_REG_STATUS) */
#define AD7746_STATUS_EXCERR BIT(3)
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <561A6DCD.8000505@kernel.org>]
* Re: [PATCH] Staging: iio: cdc: Remove unused macros [not found] ` <561A6DCD.8000505@kernel.org> @ 2015-10-11 14:10 ` Jonathan Cameron 2015-10-25 13:38 ` Jonathan Cameron 0 siblings, 1 reply; 4+ messages in thread From: Jonathan Cameron @ 2015-10-11 14:10 UTC (permalink / raw) To: Shraddha Barke, outreachy-kernel, linux-iio@vger.kernel.org, Lars-Peter Clausen On 11/10/15 15:10, Jonathan Cameron wrote: > On 07/10/15 21:38, Shraddha Barke wrote: >> Remove the macros since they are not used anywhere throughout the >> kernel. >> >> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> > Hi Shraddha, > > This should have been cc'd to linux-iio and Lars-Peter Clausen > (who maintains all the Analog devices drivers). > > It's straightforward, but worth checking that they are fine with this. That would have worked better if I'd then remembered to CC them myself. Sorry! > > Jonathan >> --- >> drivers/staging/iio/cdc/ad7746.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c >> index 028b4e8..a4bb152 100644 >> --- a/drivers/staging/iio/cdc/ad7746.c >> +++ b/drivers/staging/iio/cdc/ad7746.c >> @@ -27,11 +27,7 @@ >> >> #define AD7746_REG_STATUS 0 >> #define AD7746_REG_CAP_DATA_HIGH 1 >> -#define AD7746_REG_CAP_DATA_MID 2 >> -#define AD7746_REG_CAP_DATA_LOW 3 >> #define AD7746_REG_VT_DATA_HIGH 4 >> -#define AD7746_REG_VT_DATA_MID 5 >> -#define AD7746_REG_VT_DATA_LOW 6 >> #define AD7746_REG_CAP_SETUP 7 >> #define AD7746_REG_VT_SETUP 8 >> #define AD7746_REG_EXC_SETUP 9 >> @@ -39,11 +35,8 @@ >> #define AD7746_REG_CAPDACA 11 >> #define AD7746_REG_CAPDACB 12 >> #define AD7746_REG_CAP_OFFH 13 >> -#define AD7746_REG_CAP_OFFL 14 >> #define AD7746_REG_CAP_GAINH 15 >> -#define AD7746_REG_CAP_GAINL 16 >> #define AD7746_REG_VOLT_GAINH 17 >> -#define AD7746_REG_VOLT_GAINL 18 >> >> /* Status Register Bit Designations (AD7746_REG_STATUS) */ >> #define AD7746_STATUS_EXCERR BIT(3) >> > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: iio: cdc: Remove unused macros 2015-10-11 14:10 ` Jonathan Cameron @ 2015-10-25 13:38 ` Jonathan Cameron 0 siblings, 0 replies; 4+ messages in thread From: Jonathan Cameron @ 2015-10-25 13:38 UTC (permalink / raw) To: Shraddha Barke, outreachy-kernel, linux-iio@vger.kernel.org, Lars-Peter Clausen On 11/10/15 15:10, Jonathan Cameron wrote: > On 11/10/15 15:10, Jonathan Cameron wrote: >> On 07/10/15 21:38, Shraddha Barke wrote: >>> Remove the macros since they are not used anywhere throughout the >>> kernel. >>> >>> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> >> Hi Shraddha, >> >> This should have been cc'd to linux-iio and Lars-Peter Clausen >> (who maintains all the Analog devices drivers). >> >> It's straightforward, but worth checking that they are fine with this. > That would have worked better if I'd then remembered to CC them myself. > > Sorry! Looks like Greg beat me to this one anyway. >> >> Jonathan >>> --- >>> drivers/staging/iio/cdc/ad7746.c | 7 ------- >>> 1 file changed, 7 deletions(-) >>> >>> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c >>> index 028b4e8..a4bb152 100644 >>> --- a/drivers/staging/iio/cdc/ad7746.c >>> +++ b/drivers/staging/iio/cdc/ad7746.c >>> @@ -27,11 +27,7 @@ >>> >>> #define AD7746_REG_STATUS 0 >>> #define AD7746_REG_CAP_DATA_HIGH 1 >>> -#define AD7746_REG_CAP_DATA_MID 2 >>> -#define AD7746_REG_CAP_DATA_LOW 3 >>> #define AD7746_REG_VT_DATA_HIGH 4 >>> -#define AD7746_REG_VT_DATA_MID 5 >>> -#define AD7746_REG_VT_DATA_LOW 6 >>> #define AD7746_REG_CAP_SETUP 7 >>> #define AD7746_REG_VT_SETUP 8 >>> #define AD7746_REG_EXC_SETUP 9 >>> @@ -39,11 +35,8 @@ >>> #define AD7746_REG_CAPDACA 11 >>> #define AD7746_REG_CAPDACB 12 >>> #define AD7746_REG_CAP_OFFH 13 >>> -#define AD7746_REG_CAP_OFFL 14 >>> #define AD7746_REG_CAP_GAINH 15 >>> -#define AD7746_REG_CAP_GAINL 16 >>> #define AD7746_REG_VOLT_GAINH 17 >>> -#define AD7746_REG_VOLT_GAINL 18 >>> >>> /* Status Register Bit Designations (AD7746_REG_STATUS) */ >>> #define AD7746_STATUS_EXCERR BIT(3) >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: iio: cdc: Remove unused macros @ 2015-10-16 5:20 Shraddha Barke 0 siblings, 0 replies; 4+ messages in thread From: Shraddha Barke @ 2015-10-16 5:20 UTC (permalink / raw) To: outreachy-kernel Remove the macros since they are not used anywhere throughout the kernel. Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> --- drivers/staging/iio/cdc/ad7746.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index 028b4e8..a4bb152 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -27,11 +27,7 @@ #define AD7746_REG_STATUS 0 #define AD7746_REG_CAP_DATA_HIGH 1 -#define AD7746_REG_CAP_DATA_MID 2 -#define AD7746_REG_CAP_DATA_LOW 3 #define AD7746_REG_VT_DATA_HIGH 4 -#define AD7746_REG_VT_DATA_MID 5 -#define AD7746_REG_VT_DATA_LOW 6 #define AD7746_REG_CAP_SETUP 7 #define AD7746_REG_VT_SETUP 8 #define AD7746_REG_EXC_SETUP 9 @@ -39,11 +35,8 @@ #define AD7746_REG_CAPDACA 11 #define AD7746_REG_CAPDACB 12 #define AD7746_REG_CAP_OFFH 13 -#define AD7746_REG_CAP_OFFL 14 #define AD7746_REG_CAP_GAINH 15 -#define AD7746_REG_CAP_GAINL 16 #define AD7746_REG_VOLT_GAINH 17 -#define AD7746_REG_VOLT_GAINL 18 /* Status Register Bit Designations (AD7746_REG_STATUS) */ #define AD7746_STATUS_EXCERR BIT(3) -- 2.1.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-25 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-07 20:38 [PATCH] Staging: iio: cdc: Remove unused macros Shraddha Barke
[not found] ` <561A6DCD.8000505@kernel.org>
2015-10-11 14:10 ` Jonathan Cameron
2015-10-25 13:38 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2015-10-16 5:20 Shraddha Barke
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.