From: Florian Fainelli <f.fainelli@gmail.com>
To: Jisheng Zhang <jszhang@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Doug Berger <opendmb@gmail.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com, Byungho An <bh74.an@samsung.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] net: dsa|ethernet: use bool values to pass bool param of phy_init_eee
Date: Mon, 24 Jan 2022 09:09:41 -0800 [thread overview]
Message-ID: <562d9627-fe34-fbef-e908-d06a1cdd7cb4@gmail.com> (raw)
In-Reply-To: <20220123152241.1480-1-jszhang@kernel.org>
On 1/23/2022 7:22 AM, Jisheng Zhang wrote:
> The 2nd param of phy_init_eee(): clk_stop_enable is a bool param, use
> true or false instead of 1/0.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Nit: for future changes, if your patch spans multiple
subsystems/directories, just go with the top-most subject prefix, for
instance here "net: " would have been sufficient. Thanks!
--
Florian
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jisheng Zhang <jszhang@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Doug Berger <opendmb@gmail.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com, Byungho An <bh74.an@samsung.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] net: dsa|ethernet: use bool values to pass bool param of phy_init_eee
Date: Mon, 24 Jan 2022 09:09:41 -0800 [thread overview]
Message-ID: <562d9627-fe34-fbef-e908-d06a1cdd7cb4@gmail.com> (raw)
In-Reply-To: <20220123152241.1480-1-jszhang@kernel.org>
On 1/23/2022 7:22 AM, Jisheng Zhang wrote:
> The 2nd param of phy_init_eee(): clk_stop_enable is a bool param, use
> true or false instead of 1/0.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Nit: for future changes, if your patch spans multiple
subsystems/directories, just go with the top-most subject prefix, for
instance here "net: " would have been sufficient. Thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jisheng Zhang <jszhang@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Doug Berger <opendmb@gmail.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com, Byungho An <bh74.an@samsung.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] net: dsa|ethernet: use bool values to pass bool param of phy_init_eee
Date: Mon, 24 Jan 2022 09:09:41 -0800 [thread overview]
Message-ID: <562d9627-fe34-fbef-e908-d06a1cdd7cb4@gmail.com> (raw)
In-Reply-To: <20220123152241.1480-1-jszhang@kernel.org>
On 1/23/2022 7:22 AM, Jisheng Zhang wrote:
> The 2nd param of phy_init_eee(): clk_stop_enable is a bool param, use
> true or false instead of 1/0.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Nit: for future changes, if your patch spans multiple
subsystems/directories, just go with the top-most subject prefix, for
instance here "net: " would have been sufficient. Thanks!
--
Florian
next prev parent reply other threads:[~2022-01-24 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 15:22 [PATCH] net: dsa|ethernet: use bool values to pass bool param of phy_init_eee Jisheng Zhang
2022-01-23 15:22 ` Jisheng Zhang
2022-01-23 15:22 ` Jisheng Zhang
2022-01-23 15:54 ` Andrew Lunn
2022-01-23 15:54 ` Andrew Lunn
2022-01-23 15:54 ` Andrew Lunn
2022-01-24 17:09 ` Florian Fainelli [this message]
2022-01-24 17:09 ` Florian Fainelli
2022-01-24 17:09 ` Florian Fainelli
2022-01-25 1:10 ` Jakub Kicinski
2022-01-25 1:10 ` Jakub Kicinski
2022-01-25 1:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562d9627-fe34-fbef-e908-d06a1cdd7cb4@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bh74.an@samsung.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=jszhang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opendmb@gmail.com \
--cc=qiangqing.zhang@nxp.com \
--cc=sean.wang@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.