From: Daniel Thompson <daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Maxime Coquelin
<mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Bruno Herrera
<bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board
Date: Wed, 28 Oct 2015 08:09:23 +0000 [thread overview]
Message-ID: <563082B3.8040301@linaro.org> (raw)
In-Reply-To: <562FF234.9010403-l3A5Bk7waGM@public.gmane.org>
On 27/10/15 21:52, Andreas Färber wrote:
> Am 27.10.2015 um 22:46 schrieb Linus Walleij:
>> Heartbeat is awesome.
>
> Yes, it's awesome for testing, but not for a .dts file that ends up in a
> distro (not the case here, of course) and keeps blinking on the desk.
>
> If someone wants LEDs to blink, they can set that via sysfs or by
> modifying their .dts locally.
>
> sunxi chose to keep LEDs off my default. For qcom we had a similar
> discussion some weeks ago. I don't regularly read Linux patches, so feel
> free to skim the archives yourself.
Among the existing DTS files there is pretty significant use of
heartbeat although its not absolute.
There are 119 files that set a default-trigger, of these 91 (~75%)
include a line to configure a heartbeat.
Personally I'd be very happy with heartbeat by default on STM32... I've
seldom worked on a board without a default-enabled heartbeat so they
make me feel comfortable. ;-)
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board
Date: Wed, 28 Oct 2015 08:09:23 +0000 [thread overview]
Message-ID: <563082B3.8040301@linaro.org> (raw)
In-Reply-To: <562FF234.9010403@suse.de>
On 27/10/15 21:52, Andreas F?rber wrote:
> Am 27.10.2015 um 22:46 schrieb Linus Walleij:
>> Heartbeat is awesome.
>
> Yes, it's awesome for testing, but not for a .dts file that ends up in a
> distro (not the case here, of course) and keeps blinking on the desk.
>
> If someone wants LEDs to blink, they can set that via sysfs or by
> modifying their .dts locally.
>
> sunxi chose to keep LEDs off my default. For qcom we had a similar
> discussion some weeks ago. I don't regularly read Linux patches, so feel
> free to skim the archives yourself.
Among the existing DTS files there is pretty significant use of
heartbeat although its not absolute.
There are 119 files that set a default-trigger, of these 91 (~75%)
include a line to configure a heartbeat.
Personally I'd be very happy with heartbeat by default on STM32... I've
seldom worked on a board without a default-enabled heartbeat so they
make me feel comfortable. ;-)
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>,
"Linus Walleij" <linus.walleij@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Bruno Herrera <bruherrera@gmail.com>
Subject: Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board
Date: Wed, 28 Oct 2015 08:09:23 +0000 [thread overview]
Message-ID: <563082B3.8040301@linaro.org> (raw)
In-Reply-To: <562FF234.9010403@suse.de>
On 27/10/15 21:52, Andreas Färber wrote:
> Am 27.10.2015 um 22:46 schrieb Linus Walleij:
>> Heartbeat is awesome.
>
> Yes, it's awesome for testing, but not for a .dts file that ends up in a
> distro (not the case here, of course) and keeps blinking on the desk.
>
> If someone wants LEDs to blink, they can set that via sysfs or by
> modifying their .dts locally.
>
> sunxi chose to keep LEDs off my default. For qcom we had a similar
> discussion some weeks ago. I don't regularly read Linux patches, so feel
> free to skim the archives yourself.
Among the existing DTS files there is pretty significant use of
heartbeat although its not absolute.
There are 119 files that set a default-trigger, of these 91 (~75%)
include a line to configure a heartbeat.
Personally I'd be very happy with heartbeat by default on STM32... I've
seldom worked on a board without a default-enabled heartbeat so they
make me feel comfortable. ;-)
Daniel.
next prev parent reply other threads:[~2015-10-28 8:09 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 17:23 [PATCH v2 0/9] Add STM32 pinctrl/GPIO driver Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 1/9] ARM: Kconfig: Introduce MACH_STM32F429 flag Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 2/9] Documentation: dt-bindings: Document STM32 pinctrl driver DT bindings Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl " Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
[not found] ` <1445102604-11502-4-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-20 10:06 ` Daniel Thompson
2015-10-20 10:06 ` Daniel Thompson
2015-10-20 10:06 ` Daniel Thompson
[not found] ` <56261239.5030007-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-20 16:32 ` Maxime Coquelin
2015-10-20 16:32 ` Maxime Coquelin
2015-10-20 16:32 ` Maxime Coquelin
2015-10-22 12:35 ` Linus Walleij
2015-10-22 12:35 ` Linus Walleij
2015-11-06 12:57 ` Maxime Coquelin
2015-11-06 12:57 ` Maxime Coquelin
2015-11-17 11:00 ` Linus Walleij
2015-11-17 11:00 ` Linus Walleij
2015-11-30 15:55 ` Maxime Coquelin
2015-11-30 15:55 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 4/9] pinctrl: Add support STM32 MCUs Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
[not found] ` <1445102604-11502-5-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-01 9:53 ` Maxime Coquelin
2015-12-01 9:53 ` Maxime Coquelin
2015-12-01 9:53 ` Maxime Coquelin
2015-12-10 17:08 ` Linus Walleij
2015-12-10 17:08 ` Linus Walleij
2015-12-11 8:20 ` Patrice Chotard
2015-12-11 8:20 ` Patrice Chotard
2015-12-11 8:26 ` Maxime Coquelin
2015-12-11 8:26 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 5/9] ARM: mach-stm32: Select pinctrl Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
[not found] ` <1445102604-11502-6-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-26 13:37 ` Linus Walleij
2015-10-26 13:37 ` Linus Walleij
2015-10-26 13:37 ` Linus Walleij
2015-10-17 17:23 ` [PATCH v2 6/9] ARM: dts: Add pinctrl node to STM32F429 Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 7/9] ARM: dts: Add USART1 pin config to STM32F429 boards Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-26 13:38 ` Linus Walleij
2015-10-26 13:38 ` Linus Walleij
2015-10-17 17:23 ` [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-26 13:41 ` Linus Walleij
2015-10-26 13:41 ` Linus Walleij
2015-10-27 20:31 ` Maxime Coquelin
2015-10-27 20:31 ` Maxime Coquelin
2015-10-27 21:37 ` Andreas Färber
2015-10-27 21:37 ` Andreas Färber
2015-10-27 21:46 ` Linus Walleij
2015-10-27 21:46 ` Linus Walleij
2015-10-27 21:52 ` Andreas Färber
2015-10-27 21:52 ` Andreas Färber
2015-10-27 21:52 ` Andreas Färber
[not found] ` <562FF234.9010403-l3A5Bk7waGM@public.gmane.org>
2015-10-28 8:09 ` Daniel Thompson [this message]
2015-10-28 8:09 ` Daniel Thompson
2015-10-28 8:09 ` Daniel Thompson
2015-10-28 14:24 ` Maxime Coquelin
2015-10-28 14:24 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 9/9] ARM: config: Enable GPIO Led driver in stm32_defconfig Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-26 13:42 ` Linus Walleij
2015-10-26 13:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563082B3.8040301@linaro.org \
--to=daniel.thompson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=afaerber-l3A5Bk7waGM@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=bruherrera-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.