All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrice Chotard <patrice.chotard@st.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Bruno Herrera" <bruherrera@gmail.com>
Subject: Re: [PATCH v2 4/9] pinctrl: Add support STM32 MCUs
Date: Fri, 11 Dec 2015 09:20:50 +0100	[thread overview]
Message-ID: <566A8762.4040108@st.com> (raw)
In-Reply-To: <CACRpkda4eSHu57Tw6F-kmxY_EOSEhpRiowQN9o4LbPVgE_Xvkw@mail.gmail.com>

Hi Linus

I will try to review it before end of next week

Patrice



On 12/10/2015 06:08 PM, Linus Walleij wrote:
> On Tue, Dec 1, 2015 at 10:53 AM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com> wrote:
>> 2015-10-17 19:23 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>:
>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>>> family of MCUs.
>>>
>>> While it only supports STM32F429 for now, it has been designed to enable
>>> support of other MCUs of the family (e.g. STM32F746).
>>>
>>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>>> ---
>>>   drivers/pinctrl/Kconfig                   |    1 +
>>>   drivers/pinctrl/Makefile                  |    1 +
>>>   drivers/pinctrl/stm32/Kconfig             |   16 +
>>>   drivers/pinctrl/stm32/Makefile            |    5 +
>>>   drivers/pinctrl/stm32/pinctrl-stm32.c     |  856 +++++++++++++++
>>>   drivers/pinctrl/stm32/pinctrl-stm32.h     |   43 +
>>>   drivers/pinctrl/stm32/pinctrl-stm32f429.c | 1598 +++++++++++++++++++++++++++++
>>>   7 files changed, 2520 insertions(+)
>>>   create mode 100644 drivers/pinctrl/stm32/Kconfig
>>>   create mode 100644 drivers/pinctrl/stm32/Makefile
>>>   create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.c
>>>   create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.h
>>>   create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32f429.c
>>>
>> Gentle reminder, do you know when you will be able to review this driver?
> I'm a bit overloaded so reviewing of large chunks of code takes time.
>
> It would be great if I could have some Reviewed-by tags from someone
> else who's familiar with pin control.
>
> Patrice: do you have a chance to review this driver and help us?
>
> Yours,
> Linus Walleij


WARNING: multiple messages have this Message-ID (diff)
From: patrice.chotard@st.com (Patrice Chotard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/9] pinctrl: Add support STM32 MCUs
Date: Fri, 11 Dec 2015 09:20:50 +0100	[thread overview]
Message-ID: <566A8762.4040108@st.com> (raw)
In-Reply-To: <CACRpkda4eSHu57Tw6F-kmxY_EOSEhpRiowQN9o4LbPVgE_Xvkw@mail.gmail.com>

Hi Linus

I will try to review it before end of next week

Patrice



On 12/10/2015 06:08 PM, Linus Walleij wrote:
> On Tue, Dec 1, 2015 at 10:53 AM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com> wrote:
>> 2015-10-17 19:23 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>:
>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>>> family of MCUs.
>>>
>>> While it only supports STM32F429 for now, it has been designed to enable
>>> support of other MCUs of the family (e.g. STM32F746).
>>>
>>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>>> ---
>>>   drivers/pinctrl/Kconfig                   |    1 +
>>>   drivers/pinctrl/Makefile                  |    1 +
>>>   drivers/pinctrl/stm32/Kconfig             |   16 +
>>>   drivers/pinctrl/stm32/Makefile            |    5 +
>>>   drivers/pinctrl/stm32/pinctrl-stm32.c     |  856 +++++++++++++++
>>>   drivers/pinctrl/stm32/pinctrl-stm32.h     |   43 +
>>>   drivers/pinctrl/stm32/pinctrl-stm32f429.c | 1598 +++++++++++++++++++++++++++++
>>>   7 files changed, 2520 insertions(+)
>>>   create mode 100644 drivers/pinctrl/stm32/Kconfig
>>>   create mode 100644 drivers/pinctrl/stm32/Makefile
>>>   create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.c
>>>   create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.h
>>>   create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32f429.c
>>>
>> Gentle reminder, do you know when you will be able to review this driver?
> I'm a bit overloaded so reviewing of large chunks of code takes time.
>
> It would be great if I could have some Reviewed-by tags from someone
> else who's familiar with pin control.
>
> Patrice: do you have a chance to review this driver and help us?
>
> Yours,
> Linus Walleij

  reply	other threads:[~2015-12-11  8:21 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-17 17:23 [PATCH v2 0/9] Add STM32 pinctrl/GPIO driver Maxime Coquelin
2015-10-17 17:23 ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 1/9] ARM: Kconfig: Introduce MACH_STM32F429 flag Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 2/9] Documentation: dt-bindings: Document STM32 pinctrl driver DT bindings Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl " Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
     [not found]   ` <1445102604-11502-4-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-20 10:06     ` Daniel Thompson
2015-10-20 10:06       ` Daniel Thompson
2015-10-20 10:06       ` Daniel Thompson
     [not found]       ` <56261239.5030007-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-20 16:32         ` Maxime Coquelin
2015-10-20 16:32           ` Maxime Coquelin
2015-10-20 16:32           ` Maxime Coquelin
2015-10-22 12:35           ` Linus Walleij
2015-10-22 12:35             ` Linus Walleij
2015-11-06 12:57             ` Maxime Coquelin
2015-11-06 12:57               ` Maxime Coquelin
2015-11-17 11:00               ` Linus Walleij
2015-11-17 11:00                 ` Linus Walleij
2015-11-30 15:55                 ` Maxime Coquelin
2015-11-30 15:55                   ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 4/9] pinctrl: Add support STM32 MCUs Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
     [not found]   ` <1445102604-11502-5-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-01  9:53     ` Maxime Coquelin
2015-12-01  9:53       ` Maxime Coquelin
2015-12-01  9:53       ` Maxime Coquelin
2015-12-10 17:08       ` Linus Walleij
2015-12-10 17:08         ` Linus Walleij
2015-12-11  8:20         ` Patrice Chotard [this message]
2015-12-11  8:20           ` Patrice Chotard
2015-12-11  8:26           ` Maxime Coquelin
2015-12-11  8:26             ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 5/9] ARM: mach-stm32: Select pinctrl Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
     [not found]   ` <1445102604-11502-6-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-26 13:37     ` Linus Walleij
2015-10-26 13:37       ` Linus Walleij
2015-10-26 13:37       ` Linus Walleij
2015-10-17 17:23 ` [PATCH v2 6/9] ARM: dts: Add pinctrl node to STM32F429 Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 7/9] ARM: dts: Add USART1 pin config to STM32F429 boards Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-26 13:38   ` Linus Walleij
2015-10-26 13:38     ` Linus Walleij
2015-10-17 17:23 ` [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-26 13:41   ` Linus Walleij
2015-10-26 13:41     ` Linus Walleij
2015-10-27 20:31     ` Maxime Coquelin
2015-10-27 20:31       ` Maxime Coquelin
2015-10-27 21:37       ` Andreas Färber
2015-10-27 21:37         ` Andreas Färber
2015-10-27 21:46         ` Linus Walleij
2015-10-27 21:46           ` Linus Walleij
2015-10-27 21:52           ` Andreas Färber
2015-10-27 21:52             ` Andreas Färber
2015-10-27 21:52             ` Andreas Färber
     [not found]             ` <562FF234.9010403-l3A5Bk7waGM@public.gmane.org>
2015-10-28  8:09               ` Daniel Thompson
2015-10-28  8:09                 ` Daniel Thompson
2015-10-28  8:09                 ` Daniel Thompson
2015-10-28 14:24                 ` Maxime Coquelin
2015-10-28 14:24                   ` Maxime Coquelin
2015-10-17 17:23 ` [PATCH v2 9/9] ARM: config: Enable GPIO Led driver in stm32_defconfig Maxime Coquelin
2015-10-17 17:23   ` Maxime Coquelin
2015-10-26 13:42   ` Linus Walleij
2015-10-26 13:42     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566A8762.4040108@st.com \
    --to=patrice.chotard@st.com \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=bruherrera@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.