All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] fix bad indentation in pcie_cap_slot_write_config()
Date: Thu, 29 Oct 2015 11:07:49 +0300	[thread overview]
Message-ID: <5631D3D5.7080105@msgid.tls.msk.ru> (raw)
In-Reply-To: <5631D17A.4020101@cn.fujitsu.com>

29.10.2015 10:57, Cao jin wrote:
> Thanks Michael. and I am sorry if it bothered you.

There's nothing to worry about, really.

> Maybe it can be avoid to have a clear definition of "trivial" to direct the newbies like me:P

It is a general common sense maybe, I dunno.  There's lot of code which does not
comply with the coding styles, and at the very least, when you change just that
without actually changing the code, git blame stops working, showing your non-
change for everything instead of showing actual _code_ changes.  That's one of
the reasons why all qemu codebase hasn't been translated by some automatic
coding style formatting tool.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] fix bad indentation in pcie_cap_slot_write_config()
Date: Thu, 29 Oct 2015 11:07:49 +0300	[thread overview]
Message-ID: <5631D3D5.7080105@msgid.tls.msk.ru> (raw)
In-Reply-To: <5631D17A.4020101@cn.fujitsu.com>

29.10.2015 10:57, Cao jin wrote:
> Thanks Michael. and I am sorry if it bothered you.

There's nothing to worry about, really.

> Maybe it can be avoid to have a clear definition of "trivial" to direct the newbies like me:P

It is a general common sense maybe, I dunno.  There's lot of code which does not
comply with the coding styles, and at the very least, when you change just that
without actually changing the code, git blame stops working, showing your non-
change for everything instead of showing actual _code_ changes.  That's one of
the reasons why all qemu codebase hasn't been translated by some automatic
coding style formatting tool.

Thanks,

/mjt

  reply	other threads:[~2015-10-29  8:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25  8:23 [Qemu-devel] [PATCH] fix bad indentation in pcie_cap_slot_write_config() Cao jin
2015-10-26 12:07 ` [Qemu-trivial] " Cao jin
2015-10-26 12:07   ` Cao jin
2015-10-26 12:16   ` [Qemu-trivial] " Michael S. Tsirkin
2015-10-26 12:16     ` Michael S. Tsirkin
2015-10-29  7:45 ` [Qemu-trivial] " Michael Tokarev
2015-10-29  7:45   ` [Qemu-devel] " Michael Tokarev
2015-10-29  7:57   ` [Qemu-trivial] " Cao jin
2015-10-29  7:57     ` [Qemu-devel] " Cao jin
2015-10-29  8:07     ` Michael Tokarev [this message]
2015-10-29  8:07       ` Michael Tokarev
2015-10-29  8:28       ` [Qemu-trivial] " Cao jin
2015-10-29  8:28         ` [Qemu-devel] " Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5631D3D5.7080105@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.