From: "Hunt, David" <david.hunt@intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 6/6] test: add checks for cpu flags on armv8
Date: Fri, 30 Oct 2015 16:28:25 +0000 [thread overview]
Message-ID: <56339AA9.1060505@intel.com> (raw)
In-Reply-To: <20151030161106.4657232.16920.465@rehivetech.com>
On 30/10/2015 16:11, Jan Viktorin wrote:
> Hmm, I see. It's good to fix this in the generated e-mails between format-patch
> and send-email calls. I always review those to be sure they meet my
expectations ;).
> Anyway, it is not clear, what has changed in the v3. Just the rte_cycles?
> You should explain that at least in the 0000 patch. Better to keep some history
> in each single commit (are there any rules in dpdk for this? Just look how they do in kernel).
--snip--
Sure, I'll keep that in mind for the next time. A list of changes for
each revision, and also changes in each patch in the patch set. As
Thomas says - whatever helps the reviewer :)
For the moment there probably isn't a need to release a new patch set
for these comments, so I'll just list them here:
1. v3 has just the additional comment in one of the patches to say that
the armv8 header files are in the 'arm' include directory.
2. The rte_cycles is unchanged, the CONFIG_ is not needed.
If there is a need to post another patch set I'll include the change
notes. Otherwise do we all think that the patch is there (or there
abouts)? :)
Regards,
Dave.
next prev parent reply other threads:[~2015-10-30 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446212826-19425-7-git-send-email-david.hunt@intel.com>
[not found] ` <5633798B.2050708@intel.com>
2015-10-30 16:11 ` [PATCH v3 6/6] test: add checks for cpu flags on armv8 Jan Viktorin
2015-10-30 16:16 ` Thomas Monjalon
2015-10-30 16:28 ` Hunt, David [this message]
2015-11-02 6:32 ` Jerin Jacob
2015-11-02 10:47 ` Hunt, David
2015-11-02 13:17 ` Jerin Jacob
2015-11-02 15:04 ` Hunt, David
2015-11-02 15:13 ` Jan Viktorin
2015-11-02 15:20 ` Hunt, David
2015-11-02 15:24 ` Jan Viktorin
2015-10-30 13:49 [PATCH v3 0/6] ARMv8 additions to ARMv7 support David Hunt
2015-10-30 13:49 ` [PATCH v3 6/6] test: add checks for cpu flags on armv8 David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56339AA9.1060505@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.