From: "Hunt, David" <david.hunt@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 6/6] test: add checks for cpu flags on armv8
Date: Mon, 2 Nov 2015 15:04:14 +0000 [thread overview]
Message-ID: <56377B6E.70502@intel.com> (raw)
In-Reply-To: <20151102131710.GA10385@localhost.localdomain>
On 02/11/2015 13:17, Jerin Jacob wrote:
-snip--
> If am not wrong existing rte_cpu_get_flag_enabled() implementation
> should be broken in your platform also for arm64. as I could see only AT_HWCAP
> not AT_HWCAP2 and AT_HWCAP is 0x7 that means your platform also
> follows
>
> http://lxr.free-electrons.com/source/arch/arm64/include/uapi/asm/hwcap.h
>
> and the implmentation is
>
> FEAT_DEF(SWP, 0x00000001, 0, REG_HWCAP, 0) // not correct for arm64
> FEAT_DEF(HALF, 0x00000001, 0, REG_HWCAP, 1) // not correct for arm64
> FEAT_DEF(THUMB, 0x00000001, 0, REG_HWCAP, 2) // not correct for arm64
> FEAT_DEF(A26BIT, 0x00000001, 0, REG_HWCAP, 3)
--snip--
> FEAT_DEF(CRC32, 0x00000001, 0, REG_HWCAP2, 4)
> FEAT_DEF(AARCH32, 0x00000001, 0, REG_PLATFORM, 0)
> FEAT_DEF(AARCH64, 0x00000001, 0, REG_PLATFORM, 1)
>
> Am I missing something ?
You are correct. I need to re-visit this. In merging the ARMv7 and
ARVv8, I should have split the hardware capabilities flags into 32-but
and 64-bit versions. I'll do that in the next patch.
Thanks,
Dave.
next prev parent reply other threads:[~2015-11-02 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446212826-19425-7-git-send-email-david.hunt@intel.com>
[not found] ` <5633798B.2050708@intel.com>
2015-10-30 16:11 ` [PATCH v3 6/6] test: add checks for cpu flags on armv8 Jan Viktorin
2015-10-30 16:16 ` Thomas Monjalon
2015-10-30 16:28 ` Hunt, David
2015-11-02 6:32 ` Jerin Jacob
2015-11-02 10:47 ` Hunt, David
2015-11-02 13:17 ` Jerin Jacob
2015-11-02 15:04 ` Hunt, David [this message]
2015-11-02 15:13 ` Jan Viktorin
2015-11-02 15:20 ` Hunt, David
2015-11-02 15:24 ` Jan Viktorin
2015-10-30 13:49 [PATCH v3 0/6] ARMv8 additions to ARMv7 support David Hunt
2015-10-30 13:49 ` [PATCH v3 6/6] test: add checks for cpu flags on armv8 David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56377B6E.70502@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.