From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 6/6] test: add checks for cpu flags on armv8
Date: Fri, 30 Oct 2015 09:16:11 -0700 (PDT) [thread overview]
Message-ID: <6645369.r3ghAFd0W5@xps13> (raw)
In-Reply-To: <20151030161106.4657232.16920.465@rehivetech.com>
2015-10-30 17:11, Jan Viktorin:
> Anyway, it is not clear, what has changed in the v3. Just the rte_cycles?
> You should explain that at least in the 0000 patch.
> Better to keep some history in each single commit (are there any rules in
> dpdk for this? Just look how they do in kernel).
The rule is to help reviewers ;)
History in the cover letter is good.
If there are also some history in each patch, it's better.
next prev parent reply other threads:[~2015-10-30 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446212826-19425-7-git-send-email-david.hunt@intel.com>
[not found] ` <5633798B.2050708@intel.com>
2015-10-30 16:11 ` [PATCH v3 6/6] test: add checks for cpu flags on armv8 Jan Viktorin
2015-10-30 16:16 ` Thomas Monjalon [this message]
2015-10-30 16:28 ` Hunt, David
2015-11-02 6:32 ` Jerin Jacob
2015-11-02 10:47 ` Hunt, David
2015-11-02 13:17 ` Jerin Jacob
2015-11-02 15:04 ` Hunt, David
2015-11-02 15:13 ` Jan Viktorin
2015-11-02 15:20 ` Hunt, David
2015-11-02 15:24 ` Jan Viktorin
2015-10-30 13:49 [PATCH v3 0/6] ARMv8 additions to ARMv7 support David Hunt
2015-10-30 13:49 ` [PATCH v3 6/6] test: add checks for cpu flags on armv8 David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6645369.r3ghAFd0W5@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.