All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent ABRIOU <vincent.abriou@st.com>
To: Takashi Iwai <tiwai@suse.de>, Emil Velikov <emil.l.velikov@gmail.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK
Date: Mon, 2 Nov 2015 10:10:27 +0100	[thread overview]
Message-ID: <56372883.2020801@st.com> (raw)
In-Reply-To: <s5h1tcdiv4m.wl-tiwai@suse.de>

Hi Takashi,

I made a rework to load the firmware at a different time, when file 
system is available.
I am now able to remove FW_LOADER_USER_HELPER_FALLBACK.
I will submit a new patch for this.

Vincent

On 10/29/2015 03:53 PM, Takashi Iwai wrote:
> On Thu, 29 Oct 2015 15:37:51 +0100,
> Emil Velikov wrote:
>>
>> On 29 October 2015 at 14:21, Vincent ABRIOU <vincent.abriou@st.com> wrote:
>>> Hi Takashi,
>>>
>>> Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP
>>> firmware execution.
>>> Indeed, our firmware is not built-in. It is a proprietary firmware
>>> uploaded into the file system that's why we need the
>>> USER_HELPER_FALLBACK to be able to load it once file system is available.
>>>
>> Hmm most other DRM drivers also require firmware. Whist some allow the
>> firmware to be picked in initrd it's not a strict requirement.
>> So I'm wondering how come there hasn't been (m)any reports,
>> considering that neither one sets USER_HELPER_FALLBACK.
>>
>> Perhaps they also need it, or something in the sti module is done
>> differently ? Just some food for thought.
>
> It's the option each user decides to set or not, depending on the
> deployed system.  Most of PCs don't need them, and actually enabling
> this option causes troubles for them.  On other embedded systems, this
> might be still needed.  So, it's the system setup issue, and not the
> thing a driver needs to care.
>
> Imagine that your driver has "select EXT3_FS" because your system
> requires it; without that option, it won't boot, OMG!
> Is it the right thing?  Obviously no.  The same logic is applied to
> this case, too.
>
>
> Takashi
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Vincent ABRIOU <vincent.abriou@st.com>
To: Takashi Iwai <tiwai@suse.de>, Emil Velikov <emil.l.velikov@gmail.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK
Date: Mon, 2 Nov 2015 10:10:27 +0100	[thread overview]
Message-ID: <56372883.2020801@st.com> (raw)
In-Reply-To: <s5h1tcdiv4m.wl-tiwai@suse.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1972 bytes --]

Hi Takashi,

I made a rework to load the firmware at a different time, when file 
system is available.
I am now able to remove FW_LOADER_USER_HELPER_FALLBACK.
I will submit a new patch for this.

Vincent

On 10/29/2015 03:53 PM, Takashi Iwai wrote:
> On Thu, 29 Oct 2015 15:37:51 +0100,
> Emil Velikov wrote:
>>
>> On 29 October 2015 at 14:21, Vincent ABRIOU <vincent.abriou@st.com> wrote:
>>> Hi Takashi,
>>>
>>> Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP
>>> firmware execution.
>>> Indeed, our firmware is not built-in. It is a proprietary firmware
>>> uploaded into the file system that's why we need the
>>> USER_HELPER_FALLBACK to be able to load it once file system is available.
>>>
>> Hmm most other DRM drivers also require firmware. Whist some allow the
>> firmware to be picked in initrd it's not a strict requirement.
>> So I'm wondering how come there hasn't been (m)any reports,
>> considering that neither one sets USER_HELPER_FALLBACK.
>>
>> Perhaps they also need it, or something in the sti module is done
>> differently ? Just some food for thought.
>
> It's the option each user decides to set or not, depending on the
> deployed system.  Most of PCs don't need them, and actually enabling
> this option causes troubles for them.  On other embedded systems, this
> might be still needed.  So, it's the system setup issue, and not the
> thing a driver needs to care.
>
> Imagine that your driver has "select EXT3_FS" because your system
> requires it; without that option, it won't boot, OMG!
> Is it the right thing?  Obviously no.  The same logic is applied to
> this case, too.
>
>
> Takashi
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2015-11-02  9:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  6:16 [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Takashi Iwai
2015-10-19  6:16 ` Takashi Iwai
2015-10-29 14:21 ` Vincent ABRIOU
2015-10-29 14:21   ` Vincent ABRIOU
2015-10-29 14:36   ` Takashi Iwai
2015-10-29 14:36     ` Takashi Iwai
2015-10-29 14:37   ` Emil Velikov
2015-10-29 14:37     ` Emil Velikov
2015-10-29 14:53     ` Takashi Iwai
2015-10-29 14:53       ` Takashi Iwai
2015-11-02  9:10       ` Vincent ABRIOU [this message]
2015-11-02  9:10         ` Vincent ABRIOU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56372883.2020801@st.com \
    --to=vincent.abriou@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.