From: Anton Bondarenko <anton.bondarenko.sama@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: broonie@kernel.org, b38343@freescale.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
vladimir_zapolskiy@mentor.com, jiada_wang@mentor.com
Subject: Re: [PATCH v3 6/7] spi: imx: return error from dma channel request
Date: Thu, 5 Nov 2015 17:00:28 +0100 [thread overview]
Message-ID: <563B7D1C.7010105@gmail.com> (raw)
In-Reply-To: <20151105085637.GJ8526@pengutronix.de>
On 05.11.2015 09:56, Sascha Hauer wrote:
> On Sun, Nov 01, 2015 at 03:41:40PM +0100, Anton Bondarenko wrote:
>> From: Anton Bondarenko <anton_bondarenko@mentor.com>
>>
>> On SDMA initialization return exactly the same error, which is
>> reported by dma_request_slave_channel_reason(), it is a preceding
>> change to defer SPI DMA initialization, if SDMA module is not yet
>> available.
>
> Maybe something like: "fix probe deferral when dmaengine is not yet
> available" in the subject line will better express that this is a patch
> that should be applied ASAP. Also you can move this up to the front of
> the series when resending.
>
> Sascha
>
This patch itself does not implement deferral for spi-imx if dmaengine
not ready. The patch targets 2 things: give a bit more detailed error
information of SPI dma slave channel initialization error and provide a
basis for the next patch ([PATCH v3 7/7] spi: imx: defer spi
initialization, if DMA engine is pending).
Regards, Anton
WARNING: multiple messages have this Message-ID (diff)
From: anton.bondarenko.sama@gmail.com (Anton Bondarenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/7] spi: imx: return error from dma channel request
Date: Thu, 5 Nov 2015 17:00:28 +0100 [thread overview]
Message-ID: <563B7D1C.7010105@gmail.com> (raw)
In-Reply-To: <20151105085637.GJ8526@pengutronix.de>
On 05.11.2015 09:56, Sascha Hauer wrote:
> On Sun, Nov 01, 2015 at 03:41:40PM +0100, Anton Bondarenko wrote:
>> From: Anton Bondarenko <anton_bondarenko@mentor.com>
>>
>> On SDMA initialization return exactly the same error, which is
>> reported by dma_request_slave_channel_reason(), it is a preceding
>> change to defer SPI DMA initialization, if SDMA module is not yet
>> available.
>
> Maybe something like: "fix probe deferral when dmaengine is not yet
> available" in the subject line will better express that this is a patch
> that should be applied ASAP. Also you can move this up to the front of
> the series when resending.
>
> Sascha
>
This patch itself does not implement deferral for spi-imx if dmaengine
not ready. The patch targets 2 things: give a bit more detailed error
information of SPI dma slave channel initialization error and provide a
basis for the next patch ([PATCH v3 7/7] spi: imx: defer spi
initialization, if DMA engine is pending).
Regards, Anton
next prev parent reply other threads:[~2015-11-05 16:00 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 14:41 [PATCH v3 0/7] Improvements for SPI IMX driver for Freescale IMX51, IMX53 and IMX6 Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` [PATCH v3 1/7] spi: imx: Fix DMA transfer Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-03 7:08 ` Robin Gong
2015-11-03 7:08 ` Robin Gong
2015-11-04 21:03 ` Anton Bondarenko
2015-11-04 21:03 ` Anton Bondarenko
2015-11-04 21:03 ` Anton Bondarenko
2015-11-05 8:34 ` Sascha Hauer
2015-11-05 8:34 ` Sascha Hauer
[not found] ` <20151105083422.GH8526-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-05 16:51 ` Anton Bondarenko
2015-11-05 16:51 ` Anton Bondarenko
2015-11-05 16:51 ` Anton Bondarenko
[not found] ` <563B88FD.8050702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-14 10:02 ` Anton Bondarenko
2015-11-14 10:02 ` Anton Bondarenko
2015-11-14 10:02 ` Anton Bondarenko
2015-11-01 14:41 ` [PATCH v3 5/7] spi: imx: Add support for loopback for ECSPI controllers Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
[not found] ` <1446388901-6073-6-git-send-email-anton.bondarenko.sama-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-14 10:06 ` Anton Bondarenko
2015-11-14 10:06 ` Anton Bondarenko
2015-11-14 10:06 ` Anton Bondarenko
[not found] ` <1446388901-6073-1-git-send-email-anton.bondarenko.sama-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-01 14:41 ` [PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-05 8:47 ` Sascha Hauer
2015-11-05 8:47 ` Sascha Hauer
[not found] ` <20151105084723.GI8526-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-10 20:20 ` Anton Bondarenko
2015-11-10 20:20 ` Anton Bondarenko
2015-11-10 20:20 ` Anton Bondarenko
2015-11-11 8:12 ` Sascha Hauer
2015-11-11 8:12 ` Sascha Hauer
2015-11-14 10:01 ` Anton Bondarenko
2015-11-14 10:01 ` Anton Bondarenko
2015-11-01 14:41 ` [PATCH v3 3/7] spi: imx: add support for all SPI word width for DMA transfer Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
[not found] ` <1446388901-6073-4-git-send-email-anton.bondarenko.sama-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-14 10:08 ` Anton Bondarenko
2015-11-14 10:08 ` Anton Bondarenko
2015-11-14 10:08 ` Anton Bondarenko
2015-11-01 14:41 ` [PATCH v3 4/7] spi: imx: add function to check for IMX51 family controller Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-14 10:06 ` Anton Bondarenko
2015-11-14 10:06 ` Anton Bondarenko
2015-11-01 14:41 ` [PATCH v3 6/7] spi: imx: return error from dma channel request Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
[not found] ` <1446388901-6073-7-git-send-email-anton.bondarenko.sama-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-05 8:56 ` Sascha Hauer
2015-11-05 8:56 ` Sascha Hauer
2015-11-05 8:56 ` Sascha Hauer
2015-11-05 16:00 ` Anton Bondarenko [this message]
2015-11-05 16:00 ` Anton Bondarenko
2015-11-14 10:03 ` Anton Bondarenko
2015-11-14 10:03 ` Anton Bondarenko
[not found] ` <563B7D1C.7010105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-14 10:05 ` Anton Bondarenko
2015-11-14 10:05 ` Anton Bondarenko
2015-11-14 10:05 ` Anton Bondarenko
2015-11-01 14:41 ` [PATCH v3 7/7] spi: imx: defer spi initialization, if DMA engine is pending Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-01 14:41 ` Anton Bondarenko
2015-11-05 8:59 ` Sascha Hauer
2015-11-05 8:59 ` Sascha Hauer
2015-11-05 16:18 ` Anton Bondarenko
2015-11-05 16:18 ` Anton Bondarenko
[not found] ` <563B8157.9030104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-14 10:03 ` Anton Bondarenko
2015-11-14 10:03 ` Anton Bondarenko
2015-11-14 10:03 ` Anton Bondarenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B7D1C.7010105@gmail.com \
--to=anton.bondarenko.sama@gmail.com \
--cc=b38343@freescale.com \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.