From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-arm@nongnu.org
Subject: Re: [PATCH 02/16] exec.c: Allow target CPUs to define multiple AddressSpaces
Date: Mon, 9 Nov 2015 11:30:28 +0100 [thread overview]
Message-ID: <564075C4.2090305@redhat.com> (raw)
In-Reply-To: <1446747358-18214-3-git-send-email-peter.maydell@linaro.org>
On 05/11/2015 19:15, Peter Maydell wrote:
> Allow multiple calls to cpu_address_space_init(); each
> call adds an entry to the cpu->ases array at the specified
> index. It is up to the target-specific CPU code to actually use
> these extra address spaces.
>
> Since this multiple AddressSpace support won't work with
> KVM, add an assertion to avoid confusing failures.
Actually it won't work _now_ with KVM, but it could.
It would be a good idea to map the multiple CPU AddressSpaces to KVM's
own multiple address spaces. It's possible to modify i386 to do this,
using address space 0 for normal operation and address space 1 for SMM,
just like KVM.
More on this as I reply to the remainder of the series...
Paolo
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Andreas Färber" <afaerber@suse.de>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 02/16] exec.c: Allow target CPUs to define multiple AddressSpaces
Date: Mon, 9 Nov 2015 11:30:28 +0100 [thread overview]
Message-ID: <564075C4.2090305@redhat.com> (raw)
In-Reply-To: <1446747358-18214-3-git-send-email-peter.maydell@linaro.org>
On 05/11/2015 19:15, Peter Maydell wrote:
> Allow multiple calls to cpu_address_space_init(); each
> call adds an entry to the cpu->ases array at the specified
> index. It is up to the target-specific CPU code to actually use
> these extra address spaces.
>
> Since this multiple AddressSpace support won't work with
> KVM, add an assertion to avoid confusing failures.
Actually it won't work _now_ with KVM, but it could.
It would be a good idea to map the multiple CPU AddressSpaces to KVM's
own multiple address spaces. It's possible to modify i386 to do this,
using address space 0 for normal operation and address space 1 for SMM,
just like KVM.
More on this as I reply to the remainder of the series...
Paolo
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
next prev parent reply other threads:[~2015-11-09 10:30 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 18:15 [PATCH 00/16] Add support for multiple address spaces per CPU and use it for ARM TrustZone Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-05 18:15 ` [PATCH 01/16] exec.c: Don't set cpu->as until cpu_address_space_init Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:04 ` Edgar E. Iglesias
2015-11-06 13:04 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-05 18:15 ` [PATCH 02/16] exec.c: Allow target CPUs to define multiple AddressSpaces Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:21 ` Edgar E. Iglesias
2015-11-06 13:21 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-06 13:34 ` Peter Maydell
2015-11-06 13:34 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:49 ` Edgar E. Iglesias
2015-11-06 13:49 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-09 10:32 ` Paolo Bonzini
2015-11-09 10:32 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 10:30 ` Paolo Bonzini [this message]
2015-11-09 10:30 ` Paolo Bonzini
2015-11-05 18:15 ` [PATCH 03/16] tlb_set_page_with_attrs: Take argument specifying AddressSpace to use Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:27 ` Edgar E. Iglesias
2015-11-06 13:27 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-06 13:41 ` Peter Maydell
2015-11-06 13:41 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:49 ` Edgar E. Iglesias
2015-11-06 13:49 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-06 13:52 ` Edgar E. Iglesias
2015-11-06 13:52 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-09 10:44 ` Paolo Bonzini
2015-11-09 10:44 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 10:49 ` Peter Maydell
2015-11-09 10:49 ` [Qemu-devel] " Peter Maydell
2015-11-10 16:13 ` Peter Maydell
2015-11-10 16:13 ` [Qemu-devel] " Peter Maydell
2015-11-05 18:15 ` [PATCH 04/16] exec.c: Add address space index to CPUIOTLBEntry Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:34 ` Edgar E. Iglesias
2015-11-06 13:34 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-06 13:45 ` Peter Maydell
2015-11-06 13:45 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:13 ` Edgar E. Iglesias
2015-11-06 14:13 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-05 18:15 ` [PATCH 05/16] exec.c: Add cpu_get_address_space() Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-05 18:15 ` [PATCH 06/16] include/qom/cpu.h: Add new get_phys_page_asidx_debug method Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:37 ` Edgar E. Iglesias
2015-11-06 13:37 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-05 18:15 ` [PATCH 07/16] exec.c: Use cpu_get_phys_page_asidx_debug Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:38 ` Edgar E. Iglesias
2015-11-06 13:38 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-05 18:15 ` [PATCH 08/16] exec.c: Have one io_mem_watch per AddressSpace Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 13:45 ` Edgar E. Iglesias
2015-11-06 13:45 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-09 10:49 ` Paolo Bonzini
2015-11-09 10:49 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 10:54 ` Peter Maydell
2015-11-09 10:54 ` [Qemu-devel] " Peter Maydell
2015-11-09 11:00 ` Paolo Bonzini
2015-11-09 11:00 ` [Qemu-devel] " Paolo Bonzini
2015-11-05 18:15 ` [PATCH 09/16] target-arm: Support multiple address spaces in page table walks Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:22 ` Edgar E. Iglesias
2015-11-06 14:22 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-09 10:51 ` Paolo Bonzini
2015-11-09 10:51 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 10:58 ` Peter Maydell
2015-11-09 10:58 ` [Qemu-devel] " Peter Maydell
2015-11-09 11:03 ` Paolo Bonzini
2015-11-09 11:03 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 11:09 ` Peter Maydell
2015-11-09 11:09 ` [Qemu-devel] " Peter Maydell
2015-11-09 11:19 ` Paolo Bonzini
2015-11-09 11:19 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 11:22 ` Peter Maydell
2015-11-09 11:22 ` [Qemu-devel] " Peter Maydell
2015-11-13 18:51 ` Peter Maydell
2015-11-13 18:51 ` [Qemu-devel] " Peter Maydell
2015-11-05 18:15 ` [PATCH 10/16] target-arm: Implement cpu_get_phys_page_asidx_debug Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:23 ` Edgar E. Iglesias
2015-11-06 14:23 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-05 18:15 ` [PATCH 11/16] memory: Add address_space_init_shareable() Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:29 ` Edgar E. Iglesias
2015-11-06 14:29 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-06 14:49 ` Peter Maydell
2015-11-06 14:49 ` [Qemu-devel] " Peter Maydell
2015-11-09 10:55 ` Paolo Bonzini
2015-11-09 10:55 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 10:59 ` Peter Maydell
2015-11-09 10:59 ` [Qemu-devel] " Peter Maydell
2015-11-09 11:02 ` Paolo Bonzini
2015-11-09 11:02 ` [Qemu-devel] " Paolo Bonzini
2015-11-05 18:15 ` [PATCH 12/16] qom/cpu: Add MemoryRegion property Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:31 ` Edgar E. Iglesias
2015-11-06 14:31 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-09 10:56 ` Paolo Bonzini
2015-11-09 10:56 ` [Qemu-devel] " Paolo Bonzini
2015-11-05 18:15 ` [PATCH 13/16] target-arm: Add QOM property for Secure memory region Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:33 ` Edgar E. Iglesias
2015-11-06 14:33 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-05 18:15 ` [PATCH 14/16] hw/arm/virt: Wire up memory region to CPUs explicitly Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-06 14:45 ` Edgar E. Iglesias
2015-11-06 14:45 ` [Qemu-devel] " Edgar E. Iglesias
2015-11-06 14:51 ` Peter Maydell
2015-11-06 14:51 ` [Qemu-devel] " Peter Maydell
2015-11-05 18:15 ` [PATCH 15/16] [RFC] hw/arm/virt: add secure memory region and UART Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
2015-11-05 18:15 ` [PATCH 16/16] HACK: rearrange the virt memory map to suit OP-TEE Peter Maydell
2015-11-05 18:15 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564075C4.2090305@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.