* [PATCH] topology: Include <linux/types.h> in API header file @ 2015-11-06 12:39 mengdong.lin 2015-11-06 12:59 ` Takashi Iwai 0 siblings, 1 reply; 10+ messages in thread From: mengdong.lin @ 2015-11-06 12:39 UTC (permalink / raw) To: alsa-devel Cc: Mengdong Lin, tiwai, mengdong.lin, vinod.koul, broonie, liam.r.girdwood, subhransu.s.prusty From: Mengdong Lin <mengdong.lin@linux.intel.com> Include <linux/types.h> in the API header file topology.h The struct snd_tplg_stream_caps_template has a member "formats" of type __le64. So <linux/types.h> is needed. Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com> diff --git a/include/topology.h b/include/topology.h index b631871..5ee67e2 100644 --- a/include/topology.h +++ b/include/topology.h @@ -21,6 +21,8 @@ #ifndef __ALSA_TOPOLOGY_H #define __ALSA_TOPOLOGY_H +#include <linux/types.h> + #ifdef __cplusplus extern "C" { #endif -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 12:39 [PATCH] topology: Include <linux/types.h> in API header file mengdong.lin @ 2015-11-06 12:59 ` Takashi Iwai 2015-11-06 13:31 ` Vinod Koul 0 siblings, 1 reply; 10+ messages in thread From: Takashi Iwai @ 2015-11-06 12:59 UTC (permalink / raw) To: mengdong.lin Cc: alsa-devel, vinod.koul, mengdong.lin, broonie, liam.r.girdwood, subhransu.s.prusty On Fri, 06 Nov 2015 13:39:36 +0100, mengdong.lin@linux.intel.com wrote: > > From: Mengdong Lin <mengdong.lin@linux.intel.com> > > Include <linux/types.h> in the API header file topology.h > > The struct snd_tplg_stream_caps_template has a member "formats" > of type __le64. So <linux/types.h> is needed. We shouldn't use __le64 for user-space API. I couldn't find it in include/topology.h. Where is it used? Of course, it's fine to use it for kernel ABI. But then linux/types.h is already included in local.h, so it shouldn't be a problem. Takashi > > Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com> > > diff --git a/include/topology.h b/include/topology.h > index b631871..5ee67e2 100644 > --- a/include/topology.h > +++ b/include/topology.h > @@ -21,6 +21,8 @@ > #ifndef __ALSA_TOPOLOGY_H > #define __ALSA_TOPOLOGY_H > > +#include <linux/types.h> > + > #ifdef __cplusplus > extern "C" { > #endif > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 12:59 ` Takashi Iwai @ 2015-11-06 13:31 ` Vinod Koul 2015-11-06 13:33 ` Takashi Iwai 0 siblings, 1 reply; 10+ messages in thread From: Vinod Koul @ 2015-11-06 13:31 UTC (permalink / raw) To: Takashi Iwai Cc: alsa-devel, mengdong.lin, mengdong.lin, broonie, liam.r.girdwood, subhransu.s.prusty On Fri, Nov 06, 2015 at 01:59:41PM +0100, Takashi Iwai wrote: > On Fri, 06 Nov 2015 13:39:36 +0100, > mengdong.lin@linux.intel.com wrote: > > > > From: Mengdong Lin <mengdong.lin@linux.intel.com> > > > > Include <linux/types.h> in the API header file topology.h > > > > The struct snd_tplg_stream_caps_template has a member "formats" > > of type __le64. So <linux/types.h> is needed. > > We shouldn't use __le64 for user-space API. I couldn't find it in > include/topology.h. Where is it used? > > Of course, it's fine to use it for kernel ABI. But then linux/types.h > is already included in local.h, so it shouldn't be a problem. Our tool threw this error ./local-alsa/include/alsa/topology.h:668:2: error: â__le64â does not name a type __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ It is coming from new ABI update /* * Stream Capabilities */ struct snd_soc_tplg_stream_caps { __le32 size; /* in bytes of this structure */ char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; __le64 formats; /* supported formats SNDRV_PCM_FMTBIT_* */ ^^^^^^^^^^^^^^^^^^^^^ __le32 rates; /* supported rates SNDRV_PCM_RATE_* */ __le32 rate_min; /* min rate */ __le32 rate_max; /* max rate */ __le32 channels_min; /* min channels */ __le32 channels_max; /* max channels */ __le32 periods_min; /* min number of periods */ __le32 periods_max; /* max number of periods */ __le32 period_size_min; /* min period size bytes */ __le32 period_size_max; /* max period size bytes */ __le32 buffer_size_min; /* min buffer size bytes */ __le32 buffer_size_max; /* max buffer size bytes */ } __attribute__((packed)); The problem is the users of alsa-lib and not the alsa-lib compile itself.. Thanks -- ~Vinod ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 13:31 ` Vinod Koul @ 2015-11-06 13:33 ` Takashi Iwai 2015-11-06 14:37 ` Liam Girdwood 0 siblings, 1 reply; 10+ messages in thread From: Takashi Iwai @ 2015-11-06 13:33 UTC (permalink / raw) To: Vinod Koul Cc: alsa-devel, mengdong.lin, mengdong.lin, broonie, liam.r.girdwood, subhransu.s.prusty On Fri, 06 Nov 2015 14:31:18 +0100, Vinod Koul wrote: > > On Fri, Nov 06, 2015 at 01:59:41PM +0100, Takashi Iwai wrote: > > On Fri, 06 Nov 2015 13:39:36 +0100, > > mengdong.lin@linux.intel.com wrote: > > > > > > From: Mengdong Lin <mengdong.lin@linux.intel.com> > > > > > > Include <linux/types.h> in the API header file topology.h > > > > > > The struct snd_tplg_stream_caps_template has a member "formats" > > > of type __le64. So <linux/types.h> is needed. > > > > We shouldn't use __le64 for user-space API. I couldn't find it in > > include/topology.h. Where is it used? > > > > Of course, it's fine to use it for kernel ABI. But then linux/types.h > > is already included in local.h, so it shouldn't be a problem. > > Our tool threw this error > > ./local-alsa/include/alsa/topology.h:668:2: error: â__le64â does not name a > type > __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > > > It is coming from new ABI update > > /* > * Stream Capabilities > */ > struct snd_soc_tplg_stream_caps { > __le32 size; /* in bytes of this structure */ > char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; > __le64 formats; /* supported formats SNDRV_PCM_FMTBIT_* */ > ^^^^^^^^^^^^^^^^^^^^^ > > __le32 rates; /* supported rates SNDRV_PCM_RATE_* */ > __le32 rate_min; /* min rate */ > __le32 rate_max; /* max rate */ > __le32 channels_min; /* min channels */ > __le32 channels_max; /* max channels */ > __le32 periods_min; /* min number of periods */ > __le32 periods_max; /* max number of periods */ > __le32 period_size_min; /* min period size bytes */ > __le32 period_size_max; /* max period size bytes */ > __le32 buffer_size_min; /* min buffer size bytes */ > __le32 buffer_size_max; /* max buffer size bytes */ > } __attribute__((packed)); > > The problem is the users of alsa-lib and not the alsa-lib compile itself.. The structure above shouldn't be exposed to user-space as is. If it's a part of alsa-lib API, it must be generic. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 13:33 ` Takashi Iwai @ 2015-11-06 14:37 ` Liam Girdwood 2015-11-06 14:40 ` Takashi Iwai 0 siblings, 1 reply; 10+ messages in thread From: Liam Girdwood @ 2015-11-06 14:37 UTC (permalink / raw) To: Vinod Koul Cc: alsa-devel, mengdong.lin, Takashi Iwai, mengdong.lin, broonie, subhransu.s.prusty On Fri, 2015-11-06 at 14:33 +0100, Takashi Iwai wrote: > On Fri, 06 Nov 2015 14:31:18 +0100, > Vinod Koul wrote: > > > > On Fri, Nov 06, 2015 at 01:59:41PM +0100, Takashi Iwai wrote: > > > On Fri, 06 Nov 2015 13:39:36 +0100, > > > mengdong.lin@linux.intel.com wrote: > > > > > > > > From: Mengdong Lin <mengdong.lin@linux.intel.com> > > > > > > > > Include <linux/types.h> in the API header file topology.h > > > > > > > > The struct snd_tplg_stream_caps_template has a member "formats" > > > > of type __le64. So <linux/types.h> is needed. > > > > > > We shouldn't use __le64 for user-space API. I couldn't find it in > > > include/topology.h. Where is it used? > > > > > > Of course, it's fine to use it for kernel ABI. But then linux/types.h > > > is already included in local.h, so it shouldn't be a problem. > > > > Our tool threw this error > > > > ./local-alsa/include/alsa/topology.h:668:2: error: â__le64â does not name a > > type > > __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > > Can you try the following patch for the userspace header. From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 From: Liam Girdwood <liam.r.girdwood@linux.intel.com> Date: Fri, 6 Nov 2015 14:30:36 +0000 Subject: [PATCH] topology: remove little endian type from userspace header. Use a generic unsigned long long for formats instead of an ABI endian specific __le64 type. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> --- include/topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/topology.h b/include/topology.h index b631871..1a110a2 100644 --- a/include/topology.h +++ b/include/topology.h @@ -665,7 +665,7 @@ struct snd_tplg_stream_template { */ struct snd_tplg_stream_caps_template { const char *name; /*!< name of the stream caps */ - __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ + unsigned long long formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ unsigned int rates; /*!< supported rates SNDRV_PCM_RATE_* */ unsigned int rate_min; /*!< min rate */ unsigned int rate_max; /*!< max rate */ -- 2.5.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 14:37 ` Liam Girdwood @ 2015-11-06 14:40 ` Takashi Iwai 2015-11-06 14:57 ` Liam Girdwood 0 siblings, 1 reply; 10+ messages in thread From: Takashi Iwai @ 2015-11-06 14:40 UTC (permalink / raw) To: Liam Girdwood Cc: alsa-devel, mengdong.lin, Vinod Koul, mengdong.lin, broonie, subhransu.s.prusty On Fri, 06 Nov 2015 15:37:27 +0100, Liam Girdwood wrote: > > On Fri, 2015-11-06 at 14:33 +0100, Takashi Iwai wrote: > > On Fri, 06 Nov 2015 14:31:18 +0100, > > Vinod Koul wrote: > > > > > > On Fri, Nov 06, 2015 at 01:59:41PM +0100, Takashi Iwai wrote: > > > > On Fri, 06 Nov 2015 13:39:36 +0100, > > > > mengdong.lin@linux.intel.com wrote: > > > > > > > > > > From: Mengdong Lin <mengdong.lin@linux.intel.com> > > > > > > > > > > Include <linux/types.h> in the API header file topology.h > > > > > > > > > > The struct snd_tplg_stream_caps_template has a member "formats" > > > > > of type __le64. So <linux/types.h> is needed. > > > > > > > > We shouldn't use __le64 for user-space API. I couldn't find it in > > > > include/topology.h. Where is it used? > > > > > > > > Of course, it's fine to use it for kernel ABI. But then linux/types.h > > > > is already included in local.h, so it shouldn't be a problem. > > > > > > Our tool threw this error > > > > > > ./local-alsa/include/alsa/topology.h:668:2: error: â__le64â does not name a > > > type > > > __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > > > > > Can you try the following patch for the userspace header. > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 > From: Liam Girdwood <liam.r.girdwood@linux.intel.com> > Date: Fri, 6 Nov 2015 14:30:36 +0000 > Subject: [PATCH] topology: remove little endian type from userspace header. > > Use a generic unsigned long long for formats instead of an ABI endian > specific __le64 type. Or use uint64_t instead. This is the standard definition of 64bit integer. I thought we already include stdint.h somewhere, but you can included it there again to be sure, too. Takashi > > Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> > --- > include/topology.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/topology.h b/include/topology.h > index b631871..1a110a2 100644 > --- a/include/topology.h > +++ b/include/topology.h > @@ -665,7 +665,7 @@ struct snd_tplg_stream_template { > */ > struct snd_tplg_stream_caps_template { > const char *name; /*!< name of the stream caps */ > - __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > + unsigned long long formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > unsigned int rates; /*!< supported rates SNDRV_PCM_RATE_* */ > unsigned int rate_min; /*!< min rate */ > unsigned int rate_max; /*!< max rate */ > -- > 2.5.0 > > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 14:40 ` Takashi Iwai @ 2015-11-06 14:57 ` Liam Girdwood 2015-11-09 14:04 ` Subhransu S. Prusty 0 siblings, 1 reply; 10+ messages in thread From: Liam Girdwood @ 2015-11-06 14:57 UTC (permalink / raw) To: Takashi Iwai Cc: alsa-devel, mengdong.lin, Vinod Koul, mengdong.lin, broonie, subhransu.s.prusty On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote: > On Fri, 06 Nov 2015 15:37:27 +0100, > Liam Girdwood wrote: > > > > > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 > > From: Liam Girdwood <liam.r.girdwood@linux.intel.com> > > Date: Fri, 6 Nov 2015 14:30:36 +0000 > > Subject: [PATCH] topology: remove little endian type from userspace header. > > > > Use a generic unsigned long long for formats instead of an ABI endian > > specific __le64 type. > > Or use uint64_t instead. This is the standard definition of 64bit > integer. I thought we already include stdint.h somewhere, but you can > included it there again to be sure, too. > I didn't see stdint.h so used unsigned long long on the first patch. The patch below fixes this though :- >From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001 From: Liam Girdwood <liam.r.girdwood@linux.intel.com> Date: Fri, 6 Nov 2015 14:30:36 +0000 Subject: [PATCH] topology: remove little endian type from userspace header. Use a generic uint64_t for formats instead of an ABI endian specific __le64 type. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> --- include/topology.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/topology.h b/include/topology.h index b631871..993537c 100644 --- a/include/topology.h +++ b/include/topology.h @@ -21,6 +21,8 @@ #ifndef __ALSA_TOPOLOGY_H #define __ALSA_TOPOLOGY_H +#include <stdint.h> + #ifdef __cplusplus extern "C" { #endif @@ -665,7 +667,7 @@ struct snd_tplg_stream_template { */ struct snd_tplg_stream_caps_template { const char *name; /*!< name of the stream caps */ - __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ + uint64_t formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ unsigned int rates; /*!< supported rates SNDRV_PCM_RATE_* */ unsigned int rate_min; /*!< min rate */ unsigned int rate_max; /*!< max rate */ -- 2.5.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-06 14:57 ` Liam Girdwood @ 2015-11-09 14:04 ` Subhransu S. Prusty 2015-11-10 12:29 ` Vinod Koul 0 siblings, 1 reply; 10+ messages in thread From: Subhransu S. Prusty @ 2015-11-09 14:04 UTC (permalink / raw) To: Liam Girdwood Cc: alsa-devel, mengdong.lin, Takashi Iwai, mengdong.lin, Vinod Koul, broonie, subhransu.s.prusty On Fri, Nov 06, 2015 at 02:57:17PM +0000, Liam Girdwood wrote: > On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote: > > On Fri, 06 Nov 2015 15:37:27 +0100, > > Liam Girdwood wrote: > > > > > > > > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 > > > From: Liam Girdwood <liam.r.girdwood@linux.intel.com> > > > Date: Fri, 6 Nov 2015 14:30:36 +0000 > > > Subject: [PATCH] topology: remove little endian type from userspace header. > > > > > > Use a generic unsigned long long for formats instead of an ABI endian > > > specific __le64 type. > > > > Or use uint64_t instead. This is the standard definition of 64bit > > integer. I thought we already include stdint.h somewhere, but you can > > included it there again to be sure, too. > > > > I didn't see stdint.h so used unsigned long long on the first patch. The > patch below fixes this though :- > > From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001 > From: Liam Girdwood <liam.r.girdwood@linux.intel.com> > Date: Fri, 6 Nov 2015 14:30:36 +0000 > Subject: [PATCH] topology: remove little endian type from userspace header. > > Use a generic uint64_t for formats instead of an ABI endian specific > __le64 type. Tested and it works fine. > > Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> > --- > include/topology.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/topology.h b/include/topology.h > index b631871..993537c 100644 > --- a/include/topology.h > +++ b/include/topology.h > @@ -21,6 +21,8 @@ > #ifndef __ALSA_TOPOLOGY_H > #define __ALSA_TOPOLOGY_H > > +#include <stdint.h> > + > #ifdef __cplusplus > extern "C" { > #endif > @@ -665,7 +667,7 @@ struct snd_tplg_stream_template { > */ > struct snd_tplg_stream_caps_template { > const char *name; /*!< name of the stream caps */ > - __le64 formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > + uint64_t formats; /*!< supported formats SNDRV_PCM_FMTBIT_* */ > unsigned int rates; /*!< supported rates SNDRV_PCM_RATE_* */ > unsigned int rate_min; /*!< min rate */ > unsigned int rate_max; /*!< max rate */ > -- > 2.5.0 > > -- ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-09 14:04 ` Subhransu S. Prusty @ 2015-11-10 12:29 ` Vinod Koul 2015-11-10 12:29 ` Jaroslav Kysela 0 siblings, 1 reply; 10+ messages in thread From: Vinod Koul @ 2015-11-10 12:29 UTC (permalink / raw) To: Subhransu S. Prusty Cc: alsa-devel, mengdong.lin, Takashi Iwai, mengdong.lin, Liam Girdwood, broonie On Mon, Nov 09, 2015 at 07:34:29PM +0530, Subhransu S. Prusty wrote: > On Fri, Nov 06, 2015 at 02:57:17PM +0000, Liam Girdwood wrote: > > On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote: > > > On Fri, 06 Nov 2015 15:37:27 +0100, > > > Liam Girdwood wrote: > > > > > > > > > > > > >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 > > > > From: Liam Girdwood <liam.r.girdwood@linux.intel.com> > > > > Date: Fri, 6 Nov 2015 14:30:36 +0000 > > > > Subject: [PATCH] topology: remove little endian type from userspace header. > > > > > > > > Use a generic unsigned long long for formats instead of an ABI endian > > > > specific __le64 type. > > > > > > Or use uint64_t instead. This is the standard definition of 64bit > > > integer. I thought we already include stdint.h somewhere, but you can > > > included it there again to be sure, too. > > > > > > > I didn't see stdint.h so used unsigned long long on the first patch. The > > patch below fixes this though :- > > > > From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001 > > From: Liam Girdwood <liam.r.girdwood@linux.intel.com> > > Date: Fri, 6 Nov 2015 14:30:36 +0000 > > Subject: [PATCH] topology: remove little endian type from userspace header. > > > > Use a generic uint64_t for formats instead of an ABI endian specific > > __le64 type. > > Tested and it works fine. Hi Takashi, Is this fix okay, was this applied ? -- ~Vinod ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] topology: Include <linux/types.h> in API header file 2015-11-10 12:29 ` Vinod Koul @ 2015-11-10 12:29 ` Jaroslav Kysela 0 siblings, 0 replies; 10+ messages in thread From: Jaroslav Kysela @ 2015-11-10 12:29 UTC (permalink / raw) To: Vinod Koul, Subhransu S. Prusty Cc: alsa-devel, mengdong.lin, Takashi Iwai, mengdong.lin, Liam Girdwood, broonie Dne 10.11.2015 v 13:29 Vinod Koul napsal(a): > On Mon, Nov 09, 2015 at 07:34:29PM +0530, Subhransu S. Prusty wrote: >> On Fri, Nov 06, 2015 at 02:57:17PM +0000, Liam Girdwood wrote: >>> On Fri, 2015-11-06 at 15:40 +0100, Takashi Iwai wrote: >>>> On Fri, 06 Nov 2015 15:37:27 +0100, >>>> Liam Girdwood wrote: >>>>> >>>>> >>>>> >From 568f769269122e90fceee605a98a1a526db2b3d4 Mon Sep 17 00:00:00 2001 >>>>> From: Liam Girdwood <liam.r.girdwood@linux.intel.com> >>>>> Date: Fri, 6 Nov 2015 14:30:36 +0000 >>>>> Subject: [PATCH] topology: remove little endian type from userspace header. >>>>> >>>>> Use a generic unsigned long long for formats instead of an ABI endian >>>>> specific __le64 type. >>>> >>>> Or use uint64_t instead. This is the standard definition of 64bit >>>> integer. I thought we already include stdint.h somewhere, but you can >>>> included it there again to be sure, too. >>>> >>> >>> I didn't see stdint.h so used unsigned long long on the first patch. The >>> patch below fixes this though :- >>> >>> From 52d3023e482ac856692bf27819d97d9a037a055b Mon Sep 17 00:00:00 2001 >>> From: Liam Girdwood <liam.r.girdwood@linux.intel.com> >>> Date: Fri, 6 Nov 2015 14:30:36 +0000 >>> Subject: [PATCH] topology: remove little endian type from userspace header. >>> >>> Use a generic uint64_t for formats instead of an ABI endian specific >>> __le64 type. >> >> Tested and it works fine. > > Hi Takashi, > > Is this fix okay, was this applied ? > Yes, it's in alsa-lib-1.1.0, too: http://git.alsa-project.org/?p=alsa-lib.git;a=summary Jaroslav -- Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-11-10 12:29 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-06 12:39 [PATCH] topology: Include <linux/types.h> in API header file mengdong.lin 2015-11-06 12:59 ` Takashi Iwai 2015-11-06 13:31 ` Vinod Koul 2015-11-06 13:33 ` Takashi Iwai 2015-11-06 14:37 ` Liam Girdwood 2015-11-06 14:40 ` Takashi Iwai 2015-11-06 14:57 ` Liam Girdwood 2015-11-09 14:04 ` Subhransu S. Prusty 2015-11-10 12:29 ` Vinod Koul 2015-11-10 12:29 ` Jaroslav Kysela
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.