* [PATCH] toaster: Bring back the download icon
@ 2015-11-10 14:51 Belen Barros Pena
2015-11-10 15:33 ` Michael Wood
0 siblings, 1 reply; 4+ messages in thread
From: Belen Barros Pena @ 2015-11-10 14:51 UTC (permalink / raw)
To: toaster
From: Belen Barros Pena <belen.barros.pena@intel.com>
The 'all builds' page was missing the download icon
next to the outcome icon, which allows you to download
a build log from the 'all builds' page.
This patch brings it back.
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
---
bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html b/bitbake/lib/toaster/toastergui/templates/builds.html
index a27a121..9f07211 100644
--- a/bitbake/lib/toaster/toastergui/templates/builds.html
+++ b/bitbake/lib/toaster/toastergui/templates/builds.html
@@ -62,7 +62,13 @@
{% for build in objects %}
<tr class="data" data-table-build-result="{{ build.id }}">
<td class="outcome">
- <a href="{% url "builddashboard" build.id %}">{%if build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
+ <a href="{% url "builddashboard" build.id %}">{%if build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
+ {% if build.project %}
+
+ <a href="{% url 'build_artifact' build.id "cookerlog" build.id %}">
+ <i class="icon-download-alt" title="" data-original-title="Download build log"></i>
+ </a>
+ {% endif %}
</td>
<td class="target">
{% for t in build.target_set.all %}
--
2.4.9 (Apple Git-60)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] toaster: Bring back the download icon
2015-11-10 14:51 [PATCH] toaster: Bring back the download icon Belen Barros Pena
@ 2015-11-10 15:33 ` Michael Wood
2015-11-26 14:51 ` Smith, Elliot
0 siblings, 1 reply; 4+ messages in thread
From: Michael Wood @ 2015-11-10 15:33 UTC (permalink / raw)
To: toaster
On 10/11/15 14:51, Belen Barros Pena wrote:
> From: Belen Barros Pena <belen.barros.pena@intel.com>
>
> The 'all builds' page was missing the download icon
> next to the outcome icon, which allows you to download
> a build log from the 'all builds' page.
>
> This patch brings it back.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
> ---
> bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html b/bitbake/lib/toaster/toastergui/templates/builds.html
> index a27a121..9f07211 100644
> --- a/bitbake/lib/toaster/toastergui/templates/builds.html
> +++ b/bitbake/lib/toaster/toastergui/templates/builds.html
> @@ -62,7 +62,13 @@
> {% for build in objects %}
> <tr class="data" data-table-build-result="{{ build.id }}">
> <td class="outcome">
> - <a href="{% url "builddashboard" build.id %}">{%if build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
> + <a href="{% url "builddashboard" build.id %}">{%if build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
> + {% if build.project %}
> +
> + <a href="{% url 'build_artifact' build.id "cookerlog" build.id %}">
> + <i class="icon-download-alt" title="" data-original-title="Download build log"></i>
> + </a>
> + {% endif %}
> </td>
> <td class="target">
> {% for t in build.target_set.all %}
Could you format the template logic on that first line so that there is
indentation in the logic sequence, for ease of reading. To avoid an
empty else statement it's better to switch round the logic to be inclusive.
Something more like
{% if build.outcome == build.SUCCEEDED or build.outcome == build.FAILED
%} <a href="{% url "builddashboard" build.id %}"> <i class=" {% if
build.outcome == build.SUCCEEDED %} icon-ok-sign success {% elif
build.outcome == build.FAILED %} icon-minus-sign error {% endif %}
"></i> </a> {% endif %}
more info on
https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Templates
Thanks
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] toaster: Bring back the download icon
2015-11-10 15:33 ` Michael Wood
@ 2015-11-26 14:51 ` Smith, Elliot
2015-11-26 14:58 ` Barros Pena, Belen
0 siblings, 1 reply; 4+ messages in thread
From: Smith, Elliot @ 2015-11-26 14:51 UTC (permalink / raw)
To: Michael Wood; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 3044 bytes --]
On 10 November 2015 at 15:33, Michael Wood <michael.g.wood@intel.com> wrote:
> On 10/11/15 14:51, Belen Barros Pena wrote:
>
>> From: Belen Barros Pena <belen.barros.pena@intel.com>
>>
>> The 'all builds' page was missing the download icon
>> next to the outcome icon, which allows you to download
>> a build log from the 'all builds' page.
>>
>> This patch brings it back.
>>
>
Did this ever get a v2, incorporating Michael's comments?
Elliot
>
>> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
>> ---
>> bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html
>> b/bitbake/lib/toaster/toastergui/templates/builds.html
>> index a27a121..9f07211 100644
>> --- a/bitbake/lib/toaster/toastergui/templates/builds.html
>> +++ b/bitbake/lib/toaster/toastergui/templates/builds.html
>> @@ -62,7 +62,13 @@
>> {% for build in objects %}
>> <tr class="data" data-table-build-result="{{ build.id }}">
>> <td class="outcome">
>> - <a href="{% url "builddashboard" build.id %}">{%if
>> build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign
>> success"></i>{%elif build.outcome == build.FAILED%}<i
>> class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
>> + <a href="{% url "builddashboard" build.id %}">{%if
>> build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign
>> success"></i>{%elif build.outcome == build.FAILED%}<i
>> class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
>> + {% if build.project %}
>> +
>> + <a href="{% url 'build_artifact' build.id "cookerlog"
>> build.id %}">
>> + <i class="icon-download-alt" title=""
>> data-original-title="Download build log"></i>
>> + </a>
>> + {% endif %}
>> </td>
>> <td class="target">
>> {% for t in build.target_set.all %}
>>
> Could you format the template logic on that first line so that there is
> indentation in the logic sequence, for ease of reading. To avoid an empty
> else statement it's better to switch round the logic to be inclusive.
>
> Something more like
>
> {% if build.outcome == build.SUCCEEDED or build.outcome == build.FAILED %}
> <a href="{% url "builddashboard" build.id %}"> <i class=" {% if
> build.outcome == build.SUCCEEDED %} icon-ok-sign success {% elif
> build.outcome == build.FAILED %} icon-minus-sign error {% endif %} "></i>
> </a> {% endif %}
>
> more info on
> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Templates
>
> Thanks
>
> Michael
>
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
[-- Attachment #2: Type: text/html, Size: 5331 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] toaster: Bring back the download icon
2015-11-26 14:51 ` Smith, Elliot
@ 2015-11-26 14:58 ` Barros Pena, Belen
0 siblings, 0 replies; 4+ messages in thread
From: Barros Pena, Belen @ 2015-11-26 14:58 UTC (permalink / raw)
To: Smith, Elliot, Wood, Michael G; +Cc: toaster@yoctoproject.org
On 26/11/2015 14:51, "toaster-bounces@yoctoproject.org on behalf of Smith,
Elliot" <toaster-bounces@yoctoproject.org on behalf of
elliot.smith@intel.com> wrote:
>On 10 November 2015 at 15:33, Michael Wood
><michael.g.wood@intel.com> wrote:
>
>On 10/11/15 14:51, Belen Barros Pena wrote:
>
>From: Belen Barros Pena <belen.barros.pena@intel.com>
>
>The 'all builds' page was missing the download icon
>next to the outcome icon, which allows you to download
>a build log from the 'all builds' page.
>
>This patch brings it back.
>
>Did this ever get a v2, incorporating Michael's comments?
Yes, this is merged to master already
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=88f9310ce0015be53
9ffefbeff4b64c73779fdc9
Cheers
Belén
>
>
>Elliot
>
>
>
>
>Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
>---
> bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html
>b/bitbake/lib/toaster/toastergui/templates/builds.html
>index a27a121..9f07211 100644
>--- a/bitbake/lib/toaster/toastergui/templates/builds.html
>+++ b/bitbake/lib/toaster/toastergui/templates/builds.html
>@@ -62,7 +62,13 @@
> {% for build in objects %}
> <tr class="data" data-table-build-result="{{
>build.id <http://build.id> }}">
> <td class="outcome">
>- <a href="{% url "builddashboard"
>build.id <http://build.id> %}">{%if build.outcome == build.SUCCEEDED%}<i
>class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i
>class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
>+ <a href="{% url "builddashboard"
>build.id <http://build.id> %}">{%if build.outcome == build.SUCCEEDED%}<i
>class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i
>class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
>+ {% if build.project %}
>+
>+ <a href="{% url 'build_artifact'
>build.id <http://build.id> "cookerlog"
>build.id <http://build.id> %}">
>+ <i class="icon-download-alt" title=""
>data-original-title="Download build log"></i>
>+ </a>
>+ {% endif %}
> </td>
> <td class="target">
> {% for t in build.target_set.all %}
>
>
>
>
>Could you format the template logic on that first line so that there is
>indentation in the logic sequence, for ease of reading. To avoid an empty
>else statement it's better to switch round the logic to be inclusive.
>
>Something more like
>
>{% if build.outcome == build.SUCCEEDED or build.outcome == build.FAILED
>%} <a href="{% url "builddashboard"
>build.id <http://build.id> %}"> <i class=" {% if build.outcome ==
>build.SUCCEEDED %} icon-ok-sign success {% elif build.outcome ==
>build.FAILED %} icon-minus-sign error {% endif %} "></i> </a> {% endif %}
>
>more info on
>https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Templates
><https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Templates>
>
>Thanks
>
>Michael
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>
>
>
>--
>Elliot Smith
>Software Engineer
>Intel Open Source Technology Centre
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-26 14:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-10 14:51 [PATCH] toaster: Bring back the download icon Belen Barros Pena
2015-11-10 15:33 ` Michael Wood
2015-11-26 14:51 ` Smith, Elliot
2015-11-26 14:58 ` Barros Pena, Belen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.