All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] efinet: add efinet_multicast_filter command
Date: Tue, 10 Nov 2015 13:33:45 -0500	[thread overview]
Message-ID: <56423889.2050401@fb.com> (raw)
In-Reply-To: <CAEaD8JP-usrQQhcSc0bqazg4T_WNdKkN4XBr3GF4MkEhU9Q_jg@mail.gmail.com>

On 11/05/2015 03:28 PM, Vladimir 'phcoder' Serbinenko wrote:
> I don't have EFI spec under my hand now. Can we get away with making it
> a default or at least for the case when no interface overrides mac
> address. Extra config to workaround firmware bugs is usually harmful
>

So I made us start setting the mac filter at open time and the problem 
still happened.  I"ve been running down what is going on since then and 
it seems there is a timing window between setting the receive filters 
and the card actually honoring the settings.  I've now gotten to the 
point that it works if I set the receive filters and then reset the 
interface and then set the mac filter.  This is horrible, and I may be 
able to get it to work less horribly but it feels more and more like my 
option is the least painful way.  I'll get it working as cleanly as 
possible and send that patch out and you can decide which approach you 
hate the least.  Thanks,

Josef


  parent reply	other threads:[~2015-11-10 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 19:23 [PATCH] efinet: add efinet_multicast_filter command Josef Bacik
2015-11-05 20:28 ` Vladimir 'phcoder' Serbinenko
2015-11-05 21:17   ` Josef Bacik
2015-11-05 23:47     ` Vladimir 'phcoder' Serbinenko
2015-11-06 18:42       ` Andrei Borzenkov
2015-11-06 18:47         ` Vladimir 'phcoder' Serbinenko
2015-11-07  6:08           ` Andrei Borzenkov
2015-11-10 18:33   ` Josef Bacik [this message]
2015-11-06  4:15 ` Andrei Borzenkov
2015-11-06 14:12   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56423889.2050401@fb.com \
    --to=jbacik@fb.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.