From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
rtc-linux <rtc-linux@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Zefan Li <lizefan@huawei.com>,
Xinwei Hu <huxinwei@huawei.com>,
Tianhong Ding <dingtianhong@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: [rtc-linux] Re: [PATCH 1/1] rtc: fix type information of rtc-proc
Date: Wed, 11 Nov 2015 09:06:51 +0800 [thread overview]
Message-ID: <564294AB.1080500@huawei.com> (raw)
In-Reply-To: <1444297652-10328-1-git-send-email-thunder.leizhen@huawei.com>
Hi, all
I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
cat /proc/driver/rtc
rtc_time : 00:47:43
rtc_date : 2015-11-11
alrm_time : 03:27:58 //alrm_time --> alarm_time
alrm_date : 2015-10-08 //alrm_date --> alarm_date
alarm_IRQ : no
alrm_pending : no //alrm_pending --> alarm_pending
update IRQ enabled : no
On 2015/10/8 17:47, Zhen Lei wrote:
> Display the whole word of "alarm", make it look more comfortable.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/rtc/rtc-proc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
> index ffa69e1..ef83f34 100644
> --- a/drivers/rtc/rtc-proc.c
> +++ b/drivers/rtc/rtc-proc.c
> @@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
>
> err = rtc_read_alarm(rtc, &alrm);
> if (err == 0) {
> - seq_printf(seq, "alrm_time\t: ");
> + seq_printf(seq, "alarm_time\t: ");
> if ((unsigned int)alrm.time.tm_hour <= 24)
> seq_printf(seq, "%02d:", alrm.time.tm_hour);
> else
> @@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> else
> seq_printf(seq, "**\n");
>
> - seq_printf(seq, "alrm_date\t: ");
> + seq_printf(seq, "alarm_date\t: ");
> if ((unsigned int)alrm.time.tm_year <= 200)
> seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
> else
> @@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> seq_printf(seq, "**\n");
> seq_printf(seq, "alarm_IRQ\t: %s\n",
> alrm.enabled ? "yes" : "no");
> - seq_printf(seq, "alrm_pending\t: %s\n",
> + seq_printf(seq, "alarm_pending\t: %s\n",
> alrm.pending ? "yes" : "no");
> seq_printf(seq, "update IRQ enabled\t: %s\n",
> (rtc->uie_rtctimer.enabled) ? "yes" : "no");
> --
> 2.5.0
>
>
>
> .
>
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
rtc-linux <rtc-linux@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Zefan Li <lizefan@huawei.com>,
Xinwei Hu <huxinwei@huawei.com>,
Tianhong Ding <dingtianhong@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH 1/1] rtc: fix type information of rtc-proc
Date: Wed, 11 Nov 2015 09:06:51 +0800 [thread overview]
Message-ID: <564294AB.1080500@huawei.com> (raw)
In-Reply-To: <1444297652-10328-1-git-send-email-thunder.leizhen@huawei.com>
Hi, all
I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
cat /proc/driver/rtc
rtc_time : 00:47:43
rtc_date : 2015-11-11
alrm_time : 03:27:58 //alrm_time --> alarm_time
alrm_date : 2015-10-08 //alrm_date --> alarm_date
alarm_IRQ : no
alrm_pending : no //alrm_pending --> alarm_pending
update IRQ enabled : no
On 2015/10/8 17:47, Zhen Lei wrote:
> Display the whole word of "alarm", make it look more comfortable.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/rtc/rtc-proc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
> index ffa69e1..ef83f34 100644
> --- a/drivers/rtc/rtc-proc.c
> +++ b/drivers/rtc/rtc-proc.c
> @@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
>
> err = rtc_read_alarm(rtc, &alrm);
> if (err == 0) {
> - seq_printf(seq, "alrm_time\t: ");
> + seq_printf(seq, "alarm_time\t: ");
> if ((unsigned int)alrm.time.tm_hour <= 24)
> seq_printf(seq, "%02d:", alrm.time.tm_hour);
> else
> @@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> else
> seq_printf(seq, "**\n");
>
> - seq_printf(seq, "alrm_date\t: ");
> + seq_printf(seq, "alarm_date\t: ");
> if ((unsigned int)alrm.time.tm_year <= 200)
> seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
> else
> @@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> seq_printf(seq, "**\n");
> seq_printf(seq, "alarm_IRQ\t: %s\n",
> alrm.enabled ? "yes" : "no");
> - seq_printf(seq, "alrm_pending\t: %s\n",
> + seq_printf(seq, "alarm_pending\t: %s\n",
> alrm.pending ? "yes" : "no");
> seq_printf(seq, "update IRQ enabled\t: %s\n",
> (rtc->uie_rtctimer.enabled) ? "yes" : "no");
> --
> 2.5.0
>
>
>
> .
>
next prev parent reply other threads:[~2015-11-11 1:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 9:47 [rtc-linux] [PATCH 1/1] rtc: fix type information of rtc-proc Zhen Lei
2015-10-08 9:47 ` Zhen Lei
2015-10-17 11:22 ` [rtc-linux] " Alexandre Belloni
2015-10-17 11:22 ` Alexandre Belloni
2015-11-11 1:06 ` Leizhen (ThunderTown) [this message]
2015-11-11 1:06 ` Leizhen (ThunderTown)
2015-11-11 10:54 ` [rtc-linux] " Alexandre Belloni
2015-11-11 10:54 ` Alexandre Belloni
2015-11-12 2:05 ` [rtc-linux] " Leizhen (ThunderTown)
2015-11-12 2:05 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564294AB.1080500@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=dingtianhong@huawei.com \
--cc=guohanjun@huawei.com \
--cc=huxinwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.