* [rtc-linux] [PATCH 1/1] rtc: fix type information of rtc-proc
@ 2015-10-08 9:47 ` Zhen Lei
0 siblings, 0 replies; 10+ messages in thread
From: Zhen Lei @ 2015-10-08 9:47 UTC (permalink / raw)
To: Arnd Bergmann, Alessandro Zummo, Alexandre Belloni, rtc-linux,
linux-kernel
Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo, Zhen Lei
Display the whole word of "alarm", make it look more comfortable.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/rtc/rtc-proc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
index ffa69e1..ef83f34 100644
--- a/drivers/rtc/rtc-proc.c
+++ b/drivers/rtc/rtc-proc.c
@@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
err = rtc_read_alarm(rtc, &alrm);
if (err == 0) {
- seq_printf(seq, "alrm_time\t: ");
+ seq_printf(seq, "alarm_time\t: ");
if ((unsigned int)alrm.time.tm_hour <= 24)
seq_printf(seq, "%02d:", alrm.time.tm_hour);
else
@@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
else
seq_printf(seq, "**\n");
- seq_printf(seq, "alrm_date\t: ");
+ seq_printf(seq, "alarm_date\t: ");
if ((unsigned int)alrm.time.tm_year <= 200)
seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
else
@@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
seq_printf(seq, "**\n");
seq_printf(seq, "alarm_IRQ\t: %s\n",
alrm.enabled ? "yes" : "no");
- seq_printf(seq, "alrm_pending\t: %s\n",
+ seq_printf(seq, "alarm_pending\t: %s\n",
alrm.pending ? "yes" : "no");
seq_printf(seq, "update IRQ enabled\t: %s\n",
(rtc->uie_rtctimer.enabled) ? "yes" : "no");
--
2.5.0
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/1] rtc: fix type information of rtc-proc
@ 2015-10-08 9:47 ` Zhen Lei
0 siblings, 0 replies; 10+ messages in thread
From: Zhen Lei @ 2015-10-08 9:47 UTC (permalink / raw)
To: Arnd Bergmann, Alessandro Zummo, Alexandre Belloni, rtc-linux,
linux-kernel
Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo, Zhen Lei
Display the whole word of "alarm", make it look more comfortable.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/rtc/rtc-proc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
index ffa69e1..ef83f34 100644
--- a/drivers/rtc/rtc-proc.c
+++ b/drivers/rtc/rtc-proc.c
@@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
err = rtc_read_alarm(rtc, &alrm);
if (err == 0) {
- seq_printf(seq, "alrm_time\t: ");
+ seq_printf(seq, "alarm_time\t: ");
if ((unsigned int)alrm.time.tm_hour <= 24)
seq_printf(seq, "%02d:", alrm.time.tm_hour);
else
@@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
else
seq_printf(seq, "**\n");
- seq_printf(seq, "alrm_date\t: ");
+ seq_printf(seq, "alarm_date\t: ");
if ((unsigned int)alrm.time.tm_year <= 200)
seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
else
@@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
seq_printf(seq, "**\n");
seq_printf(seq, "alarm_IRQ\t: %s\n",
alrm.enabled ? "yes" : "no");
- seq_printf(seq, "alrm_pending\t: %s\n",
+ seq_printf(seq, "alarm_pending\t: %s\n",
alrm.pending ? "yes" : "no");
seq_printf(seq, "update IRQ enabled\t: %s\n",
(rtc->uie_rtctimer.enabled) ? "yes" : "no");
--
2.5.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [rtc-linux] Re: [PATCH 1/1] rtc: fix type information of rtc-proc
2015-10-08 9:47 ` Zhen Lei
@ 2015-10-17 11:22 ` Alexandre Belloni
-1 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-10-17 11:22 UTC (permalink / raw)
To: Zhen Lei
Cc: Arnd Bergmann, Alessandro Zummo, rtc-linux, linux-kernel,
Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
Hi,
On 08/10/2015 at 17:47:32 +0800, Zhen Lei wrote :
> Display the whole word of "alarm", make it look more comfortable.
>
While this is nice, this will break scripts parsing that file for not
good technical reason. I guess we are stuck with legacy here.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] rtc: fix type information of rtc-proc
@ 2015-10-17 11:22 ` Alexandre Belloni
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-10-17 11:22 UTC (permalink / raw)
To: Zhen Lei
Cc: Arnd Bergmann, Alessandro Zummo, rtc-linux, linux-kernel,
Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
Hi,
On 08/10/2015 at 17:47:32 +0800, Zhen Lei wrote :
> Display the whole word of "alarm", make it look more comfortable.
>
While this is nice, this will break scripts parsing that file for not
good technical reason. I guess we are stuck with legacy here.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [rtc-linux] Re: [PATCH 1/1] rtc: fix type information of rtc-proc
2015-10-08 9:47 ` Zhen Lei
@ 2015-11-11 1:06 ` Leizhen (ThunderTown)
-1 siblings, 0 replies; 10+ messages in thread
From: Leizhen (ThunderTown) @ 2015-11-11 1:06 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, rtc-linux, linux-kernel
Cc: Arnd Bergmann, Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
Hi, all
I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
cat /proc/driver/rtc
rtc_time : 00:47:43
rtc_date : 2015-11-11
alrm_time : 03:27:58 //alrm_time --> alarm_time
alrm_date : 2015-10-08 //alrm_date --> alarm_date
alarm_IRQ : no
alrm_pending : no //alrm_pending --> alarm_pending
update IRQ enabled : no
On 2015/10/8 17:47, Zhen Lei wrote:
> Display the whole word of "alarm", make it look more comfortable.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/rtc/rtc-proc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
> index ffa69e1..ef83f34 100644
> --- a/drivers/rtc/rtc-proc.c
> +++ b/drivers/rtc/rtc-proc.c
> @@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
>
> err = rtc_read_alarm(rtc, &alrm);
> if (err == 0) {
> - seq_printf(seq, "alrm_time\t: ");
> + seq_printf(seq, "alarm_time\t: ");
> if ((unsigned int)alrm.time.tm_hour <= 24)
> seq_printf(seq, "%02d:", alrm.time.tm_hour);
> else
> @@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> else
> seq_printf(seq, "**\n");
>
> - seq_printf(seq, "alrm_date\t: ");
> + seq_printf(seq, "alarm_date\t: ");
> if ((unsigned int)alrm.time.tm_year <= 200)
> seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
> else
> @@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> seq_printf(seq, "**\n");
> seq_printf(seq, "alarm_IRQ\t: %s\n",
> alrm.enabled ? "yes" : "no");
> - seq_printf(seq, "alrm_pending\t: %s\n",
> + seq_printf(seq, "alarm_pending\t: %s\n",
> alrm.pending ? "yes" : "no");
> seq_printf(seq, "update IRQ enabled\t: %s\n",
> (rtc->uie_rtctimer.enabled) ? "yes" : "no");
> --
> 2.5.0
>
>
>
> .
>
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/1] rtc: fix type information of rtc-proc
@ 2015-11-11 1:06 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 10+ messages in thread
From: Leizhen (ThunderTown) @ 2015-11-11 1:06 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, rtc-linux, linux-kernel
Cc: Arnd Bergmann, Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
Hi, all
I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
cat /proc/driver/rtc
rtc_time : 00:47:43
rtc_date : 2015-11-11
alrm_time : 03:27:58 //alrm_time --> alarm_time
alrm_date : 2015-10-08 //alrm_date --> alarm_date
alarm_IRQ : no
alrm_pending : no //alrm_pending --> alarm_pending
update IRQ enabled : no
On 2015/10/8 17:47, Zhen Lei wrote:
> Display the whole word of "alarm", make it look more comfortable.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/rtc/rtc-proc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
> index ffa69e1..ef83f34 100644
> --- a/drivers/rtc/rtc-proc.c
> +++ b/drivers/rtc/rtc-proc.c
> @@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
>
> err = rtc_read_alarm(rtc, &alrm);
> if (err == 0) {
> - seq_printf(seq, "alrm_time\t: ");
> + seq_printf(seq, "alarm_time\t: ");
> if ((unsigned int)alrm.time.tm_hour <= 24)
> seq_printf(seq, "%02d:", alrm.time.tm_hour);
> else
> @@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> else
> seq_printf(seq, "**\n");
>
> - seq_printf(seq, "alrm_date\t: ");
> + seq_printf(seq, "alarm_date\t: ");
> if ((unsigned int)alrm.time.tm_year <= 200)
> seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
> else
> @@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)
> seq_printf(seq, "**\n");
> seq_printf(seq, "alarm_IRQ\t: %s\n",
> alrm.enabled ? "yes" : "no");
> - seq_printf(seq, "alrm_pending\t: %s\n",
> + seq_printf(seq, "alarm_pending\t: %s\n",
> alrm.pending ? "yes" : "no");
> seq_printf(seq, "update IRQ enabled\t: %s\n",
> (rtc->uie_rtctimer.enabled) ? "yes" : "no");
> --
> 2.5.0
>
>
>
> .
>
^ permalink raw reply [flat|nested] 10+ messages in thread* [rtc-linux] Re: [PATCH 1/1] rtc: fix type information of rtc-proc
2015-11-11 1:06 ` Leizhen (ThunderTown)
@ 2015-11-11 10:54 ` Alexandre Belloni
-1 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-11-11 10:54 UTC (permalink / raw)
To: Leizhen (ThunderTown)
Cc: Alessandro Zummo, rtc-linux, linux-kernel, Arnd Bergmann,
Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
On 11/11/2015 at 09:06:51 +0800, Leizhen (ThunderTown) wrote :
> Hi, all
>
> I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
> shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
>
Yes, that is exactly m point. What if an end user currently has a
program parsing the file and looking for alrm_time or alrm_date? After
updating his kernel, the program won't work anymore which is something
we don't want.
>
> cat /proc/driver/rtc
>
> rtc_time : 00:47:43
> rtc_date : 2015-11-11
> alrm_time : 03:27:58 //alrm_time --> alarm_time
> alrm_date : 2015-10-08 //alrm_date --> alarm_date
> alarm_IRQ : no
> alrm_pending : no //alrm_pending --> alarm_pending
> update IRQ enabled : no
>
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] rtc: fix type information of rtc-proc
@ 2015-11-11 10:54 ` Alexandre Belloni
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-11-11 10:54 UTC (permalink / raw)
To: Leizhen (ThunderTown)
Cc: Alessandro Zummo, rtc-linux, linux-kernel, Arnd Bergmann,
Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
On 11/11/2015 at 09:06:51 +0800, Leizhen (ThunderTown) wrote :
> Hi, all
>
> I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
> shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
>
Yes, that is exactly m point. What if an end user currently has a
program parsing the file and looking for alrm_time or alrm_date? After
updating his kernel, the program won't work anymore which is something
we don't want.
>
> cat /proc/driver/rtc
>
> rtc_time : 00:47:43
> rtc_date : 2015-11-11
> alrm_time : 03:27:58 //alrm_time --> alarm_time
> alrm_date : 2015-10-08 //alrm_date --> alarm_date
> alarm_IRQ : no
> alrm_pending : no //alrm_pending --> alarm_pending
> update IRQ enabled : no
>
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [rtc-linux] Re: [PATCH 1/1] rtc: fix type information of rtc-proc
2015-11-11 10:54 ` Alexandre Belloni
@ 2015-11-12 2:05 ` Leizhen (ThunderTown)
-1 siblings, 0 replies; 10+ messages in thread
From: Leizhen (ThunderTown) @ 2015-11-12 2:05 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Alessandro Zummo, rtc-linux, linux-kernel, Arnd Bergmann,
Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
On 2015/11/11 18:54, Alexandre Belloni wrote:
> On 11/11/2015 at 09:06:51 +0800, Leizhen (ThunderTown) wrote :
>> Hi, all
>>
>> I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
>> shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
>>
>
> Yes, that is exactly m point. What if an end user currently has a
> program parsing the file and looking for alrm_time or alrm_date? After
> updating his kernel, the program won't work anymore which is something
> we don't want.
OK. I see. Thanks.
>
>>
>> cat /proc/driver/rtc
>>
>> rtc_time : 00:47:43
>> rtc_date : 2015-11-11
>> alrm_time : 03:27:58 //alrm_time --> alarm_time
>> alrm_date : 2015-10-08 //alrm_date --> alarm_date
>> alarm_IRQ : no
>> alrm_pending : no //alrm_pending --> alarm_pending
>> update IRQ enabled : no
>>
>>
>
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] rtc: fix type information of rtc-proc
@ 2015-11-12 2:05 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 10+ messages in thread
From: Leizhen (ThunderTown) @ 2015-11-12 2:05 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Alessandro Zummo, rtc-linux, linux-kernel, Arnd Bergmann,
Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo
On 2015/11/11 18:54, Alexandre Belloni wrote:
> On 11/11/2015 at 09:06:51 +0800, Leizhen (ThunderTown) wrote :
>> Hi, all
>>
>> I'm sorry. Maybe I didn't describe clearly enough before. These words are finally
>> shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable.
>>
>
> Yes, that is exactly m point. What if an end user currently has a
> program parsing the file and looking for alrm_time or alrm_date? After
> updating his kernel, the program won't work anymore which is something
> we don't want.
OK. I see. Thanks.
>
>>
>> cat /proc/driver/rtc
>>
>> rtc_time : 00:47:43
>> rtc_date : 2015-11-11
>> alrm_time : 03:27:58 //alrm_time --> alarm_time
>> alrm_date : 2015-10-08 //alrm_date --> alarm_date
>> alarm_IRQ : no
>> alrm_pending : no //alrm_pending --> alarm_pending
>> update IRQ enabled : no
>>
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-11-12 2:09 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-08 9:47 [rtc-linux] [PATCH 1/1] rtc: fix type information of rtc-proc Zhen Lei
2015-10-08 9:47 ` Zhen Lei
2015-10-17 11:22 ` [rtc-linux] " Alexandre Belloni
2015-10-17 11:22 ` Alexandre Belloni
2015-11-11 1:06 ` [rtc-linux] " Leizhen (ThunderTown)
2015-11-11 1:06 ` Leizhen (ThunderTown)
2015-11-11 10:54 ` [rtc-linux] " Alexandre Belloni
2015-11-11 10:54 ` Alexandre Belloni
2015-11-12 2:05 ` [rtc-linux] " Leizhen (ThunderTown)
2015-11-12 2:05 ` Leizhen (ThunderTown)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.