From: Alexander Duyck <alexander.duyck@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] regression in ixgbe SFP detection patch
Date: Wed, 11 Nov 2015 14:09:54 -0800 [thread overview]
Message-ID: <5643BCB2.6070104@gmail.com> (raw)
In-Reply-To: <20151111213458.GD3641@gandi.net>
On 11/11/2015 01:34 PM, William Dauchy wrote:
> On Nov11 20:33, Tantilov, Emil S wrote:
>> If the diff above is the patch you are referring to then you will break the
>> SFP+ detection in the case where the driver was loaded while there were no
>> SFP+ modules present in the cages.
> understood, I was surprised of the modification of behavior.
You might try testing against net-next to see if the problem still
exists. It looks like the code in question doesn't exist upstream as it
was replaced in commit 45788d2af928 ("ixgbe: fix issue with sfp events
with new X550 devices").
- Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <alexander.duyck@gmail.com>
To: William Dauchy <william@gandi.net>,
"Tantilov, Emil S" <emil.s.tantilov@intel.com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Schmitt, Phillip J" <phillip.j.schmitt@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: regression in ixgbe SFP detection patch
Date: Wed, 11 Nov 2015 14:09:54 -0800 [thread overview]
Message-ID: <5643BCB2.6070104@gmail.com> (raw)
In-Reply-To: <20151111213458.GD3641@gandi.net>
On 11/11/2015 01:34 PM, William Dauchy wrote:
> On Nov11 20:33, Tantilov, Emil S wrote:
>> If the diff above is the patch you are referring to then you will break the
>> SFP+ detection in the case where the driver was loaded while there were no
>> SFP+ modules present in the cages.
> understood, I was surprised of the modification of behavior.
You might try testing against net-next to see if the problem still
exists. It looks like the code in question doesn't exist upstream as it
was replaced in commit 45788d2af928 ("ixgbe: fix issue with sfp events
with new X550 devices").
- Alex
next prev parent reply other threads:[~2015-11-11 22:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 17:35 [Intel-wired-lan] regression in ixgbe SFP detection patch William Dauchy
2015-11-11 17:35 ` William Dauchy
2015-11-11 20:33 ` [Intel-wired-lan] " Tantilov, Emil S
2015-11-11 20:33 ` Tantilov, Emil S
2015-11-11 21:34 ` [Intel-wired-lan] " William Dauchy
2015-11-11 21:34 ` William Dauchy
2015-11-11 22:09 ` Alexander Duyck [this message]
2015-11-11 22:09 ` Alexander Duyck
2015-11-11 22:13 ` [Intel-wired-lan] " Rustad, Mark D
2015-11-11 22:13 ` Rustad, Mark D
2015-11-12 12:22 ` William Dauchy
2015-11-12 12:22 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5643BCB2.6070104@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.