From: Don Brace <brace77070@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Scott Teel <scott.teel@pmcs.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>,
iss_storagedev@hp.com, storagedev@pmcs.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] hpsa: logical vs bitwise AND typo
Date: Thu, 12 Nov 2015 15:33:02 +0000 [thread overview]
Message-ID: <5644B12E.4040506@pmcs.com> (raw)
In-Reply-To: <1447322361.2616.10.camel@suse.de>
On 11/12/2015 03:59 AM, Johannes Thumshirn wrote:
> On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote:
>> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
>> intended here instead of logical &&. This bug is essentially
>> harmless,
>> it means that sometimes we don't print a warning message which we
>> wanted
>> to print.
>>
>> Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
>> index 6a8f958..a386036 100644
>> --- a/drivers/scsi/hpsa.c
>> +++ b/drivers/scsi/hpsa.c
>> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct
>> ctlr_info *h)
>> if ((rc != 0) || (c->err_info->CommandStatus != 0))
>> goto errout;
>>
>> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> goto out;
>>
>> errout:
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Signed-off-by: Don Brace <don.brace@pmcs.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Don Brace <brace77070@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Scott Teel <scott.teel@pmcs.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>,
iss_storagedev@hp.com, storagedev@pmcs.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] hpsa: logical vs bitwise AND typo
Date: Thu, 12 Nov 2015 09:33:02 -0600 [thread overview]
Message-ID: <5644B12E.4040506@pmcs.com> (raw)
In-Reply-To: <1447322361.2616.10.camel@suse.de>
On 11/12/2015 03:59 AM, Johannes Thumshirn wrote:
> On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote:
>> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
>> intended here instead of logical &&. This bug is essentially
>> harmless,
>> it means that sometimes we don't print a warning message which we
>> wanted
>> to print.
>>
>> Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
>> index 6a8f958..a386036 100644
>> --- a/drivers/scsi/hpsa.c
>> +++ b/drivers/scsi/hpsa.c
>> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct
>> ctlr_info *h)
>> if ((rc != 0) || (c->err_info->CommandStatus != 0))
>> goto errout;
>>
>> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> goto out;
>>
>> errout:
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Signed-off-by: Don Brace <don.brace@pmcs.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-12 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 9:43 [patch] hpsa: logical vs bitwise AND typo Dan Carpenter
2015-11-12 9:43 ` Dan Carpenter
2015-11-12 9:59 ` Johannes Thumshirn
2015-11-12 9:59 ` Johannes Thumshirn
2015-11-12 15:33 ` Don Brace [this message]
2015-11-12 15:33 ` Don Brace
2015-11-13 21:50 ` Martin K. Petersen
2015-11-13 21:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5644B12E.4040506@pmcs.com \
--to=brace77070@gmail.com \
--cc=JBottomley@odin.com \
--cc=dan.carpenter@oracle.com \
--cc=iss_storagedev@hp.com \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.teel@pmcs.com \
--cc=storagedev@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.