From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Don Brace <don.brace@pmcs.com>, Scott Teel <scott.teel@pmcs.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
iss_storagedev@hp.com, storagedev@pmcs.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] hpsa: logical vs bitwise AND typo
Date: Fri, 13 Nov 2015 21:50:21 +0000 [thread overview]
Message-ID: <yq14mgpzi02.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20151112094338.GB28432@mwanda> (Dan Carpenter's message of "Thu, 12 Nov 2015 12:43:38 +0300")
>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
Dan> intended here instead of logical &&. This bug is essentially
Dan> harmless, it means that sometimes we don't print a warning message
Dan> which we wanted to print.
Applied.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Don Brace <don.brace@pmcs.com>, Scott Teel <scott.teel@pmcs.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
iss_storagedev@hp.com, storagedev@pmcs.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] hpsa: logical vs bitwise AND typo
Date: Fri, 13 Nov 2015 16:50:21 -0500 [thread overview]
Message-ID: <yq14mgpzi02.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20151112094338.GB28432@mwanda> (Dan Carpenter's message of "Thu, 12 Nov 2015 12:43:38 +0300")
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
Dan> intended here instead of logical &&. This bug is essentially
Dan> harmless, it means that sometimes we don't print a warning message
Dan> which we wanted to print.
Applied.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-11-13 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 9:43 [patch] hpsa: logical vs bitwise AND typo Dan Carpenter
2015-11-12 9:43 ` Dan Carpenter
2015-11-12 9:59 ` Johannes Thumshirn
2015-11-12 9:59 ` Johannes Thumshirn
2015-11-12 15:33 ` Don Brace
2015-11-12 15:33 ` Don Brace
2015-11-13 21:50 ` Martin K. Petersen [this message]
2015-11-13 21:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14mgpzi02.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=JBottomley@odin.com \
--cc=dan.carpenter@oracle.com \
--cc=don.brace@pmcs.com \
--cc=iss_storagedev@hp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.teel@pmcs.com \
--cc=storagedev@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.