* [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism
@ 2015-11-11 4:48 Andre McCurdy
2015-11-11 4:48 ` [meta-browser][PATCH 2/2] chromium: " Andre McCurdy
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Andre McCurdy @ 2015-11-11 4:48 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
recipes-browser/chromium/cef3_280796.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-browser/chromium/cef3_280796.bb b/recipes-browser/chromium/cef3_280796.bb
index d827b8e..6872e5b 100644
--- a/recipes-browser/chromium/cef3_280796.bb
+++ b/recipes-browser/chromium/cef3_280796.bb
@@ -60,5 +60,5 @@ do_qa_configure() {
}
do_compile() {
- ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple
+ ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
}
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [meta-browser][PATCH 2/2] chromium: use PARALLEL_MAKE to control build parallelism 2015-11-11 4:48 [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism Andre McCurdy @ 2015-11-11 4:48 ` Andre McCurdy 2015-11-11 4:55 ` Khem Raj 2015-11-14 14:04 ` Nikolay Dimitrov 2015-11-11 4:54 ` [meta-browser][PATCH 1/2] cef3: " Khem Raj 2015-11-11 5:48 ` Zoltan Kuscsik 2 siblings, 2 replies; 14+ messages in thread From: Andre McCurdy @ 2015-11-11 4:48 UTC (permalink / raw) To: openembedded-devel Signed-off-by: Andre McCurdy <armccurdy@gmail.com> --- recipes-browser/chromium/chromium_40.0.2214.91.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-browser/chromium/chromium_40.0.2214.91.bb b/recipes-browser/chromium/chromium_40.0.2214.91.bb index a9635cd..f20610c 100644 --- a/recipes-browser/chromium/chromium_40.0.2214.91.bb +++ b/recipes-browser/chromium/chromium_40.0.2214.91.bb @@ -196,7 +196,7 @@ do_configure_append() { do_compile() { # build with ninja - ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} chrome chrome_sandbox + ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} chrome chrome_sandbox } -- 1.9.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 2/2] chromium: use PARALLEL_MAKE to control build parallelism 2015-11-11 4:48 ` [meta-browser][PATCH 2/2] chromium: " Andre McCurdy @ 2015-11-11 4:55 ` Khem Raj 2015-11-14 14:04 ` Nikolay Dimitrov 1 sibling, 0 replies; 14+ messages in thread From: Khem Raj @ 2015-11-11 4:55 UTC (permalink / raw) To: openembeded-devel this is ok On Tue, Nov 10, 2015 at 8:48 PM, Andre McCurdy <armccurdy@gmail.com> wrote: > Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > --- > recipes-browser/chromium/chromium_40.0.2214.91.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-browser/chromium/chromium_40.0.2214.91.bb b/recipes-browser/chromium/chromium_40.0.2214.91.bb > index a9635cd..f20610c 100644 > --- a/recipes-browser/chromium/chromium_40.0.2214.91.bb > +++ b/recipes-browser/chromium/chromium_40.0.2214.91.bb > @@ -196,7 +196,7 @@ do_configure_append() { > > do_compile() { > # build with ninja > - ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} chrome chrome_sandbox > + ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} chrome chrome_sandbox > } > > > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 2/2] chromium: use PARALLEL_MAKE to control build parallelism 2015-11-11 4:48 ` [meta-browser][PATCH 2/2] chromium: " Andre McCurdy 2015-11-11 4:55 ` Khem Raj @ 2015-11-14 14:04 ` Nikolay Dimitrov 2015-11-16 18:15 ` Andre McCurdy 1 sibling, 1 reply; 14+ messages in thread From: Nikolay Dimitrov @ 2015-11-14 14:04 UTC (permalink / raw) To: armccurdy; +Cc: openembedded-devel Hi Andre, On 11/11/2015 06:48 AM, Andre McCurdy wrote: > Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > --- > recipes-browser/chromium/chromium_40.0.2214.91.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-browser/chromium/chromium_40.0.2214.91.bb b/recipes-browser/chromium/chromium_40.0.2214.91.bb > index a9635cd..f20610c 100644 > --- a/recipes-browser/chromium/chromium_40.0.2214.91.bb > +++ b/recipes-browser/chromium/chromium_40.0.2214.91.bb > @@ -196,7 +196,7 @@ do_configure_append() { > > do_compile() { > # build with ninja > - ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} chrome chrome_sandbox > + ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} chrome chrome_sandbox > } Can you please share the chromium build times on your build-box with and without this patch? I'm just curious how well this worked for you. Thanks and regards, Nikolay ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 2/2] chromium: use PARALLEL_MAKE to control build parallelism 2015-11-14 14:04 ` Nikolay Dimitrov @ 2015-11-16 18:15 ` Andre McCurdy 2015-11-17 12:32 ` Nikolay Dimitrov 0 siblings, 1 reply; 14+ messages in thread From: Andre McCurdy @ 2015-11-16 18:15 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: openembedded-devel Hi Nikolay, On Sat, Nov 14, 2015 at 6:04 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > Hi Andre, > > On 11/11/2015 06:48 AM, Andre McCurdy wrote: >> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >> --- >> recipes-browser/chromium/chromium_40.0.2214.91.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/recipes-browser/chromium/chromium_40.0.2214.91.bb >> b/recipes-browser/chromium/chromium_40.0.2214.91.bb >> index a9635cd..f20610c 100644 >> --- a/recipes-browser/chromium/chromium_40.0.2214.91.bb >> +++ b/recipes-browser/chromium/chromium_40.0.2214.91.bb >> @@ -196,7 +196,7 @@ do_configure_append() { >> >> do_compile() { >> # build with ninja >> - ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} >> chrome chrome_sandbox >> + ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} chrome >> chrome_sandbox >> } > > > Can you please share the chromium build times on your build-box with > and without this patch? I'm just curious how well this worked for you. By default BB_NUMBER_THREADS and PARALLEL_MAKE are both derived from the number of logical CPU cores (as detected by oe.utils.cpu_count()), so the patch should not have any effect on build times. The patch is about correctness - it's not really right to use BB_NUMBER_THREADS for anything other than setting the maximum number of BitBake threads. > Thanks and regards, > Nikolay ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 2/2] chromium: use PARALLEL_MAKE to control build parallelism 2015-11-16 18:15 ` Andre McCurdy @ 2015-11-17 12:32 ` Nikolay Dimitrov 0 siblings, 0 replies; 14+ messages in thread From: Nikolay Dimitrov @ 2015-11-17 12:32 UTC (permalink / raw) To: Andre McCurdy; +Cc: openembedded-devel Hi Andre, On 11/16/2015 08:15 PM, Andre McCurdy wrote: > Hi Nikolay, > > On Sat, Nov 14, 2015 at 6:04 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote: >> Hi Andre, >> >> On 11/11/2015 06:48 AM, Andre McCurdy wrote: >>> >>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >>> --- >>> recipes-browser/chromium/chromium_40.0.2214.91.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/recipes-browser/chromium/chromium_40.0.2214.91.bb >>> b/recipes-browser/chromium/chromium_40.0.2214.91.bb >>> index a9635cd..f20610c 100644 >>> --- a/recipes-browser/chromium/chromium_40.0.2214.91.bb >>> +++ b/recipes-browser/chromium/chromium_40.0.2214.91.bb >>> @@ -196,7 +196,7 @@ do_configure_append() { >>> >>> do_compile() { >>> # build with ninja >>> - ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} >>> chrome chrome_sandbox >>> + ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} chrome >>> chrome_sandbox >>> } >> >> >> Can you please share the chromium build times on your build-box with >> and without this patch? I'm just curious how well this worked for you. > > By default BB_NUMBER_THREADS and PARALLEL_MAKE are both derived from > the number of logical CPU cores (as detected by oe.utils.cpu_count()), > so the patch should not have any effect on build times. > > The patch is about correctness - it's not really right to use > BB_NUMBER_THREADS for anything other than setting the maximum number > of BitBake threads. Ahh, I see. Thanks. Regards, Nikolay ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-11 4:48 [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism Andre McCurdy 2015-11-11 4:48 ` [meta-browser][PATCH 2/2] chromium: " Andre McCurdy @ 2015-11-11 4:54 ` Khem Raj 2015-11-11 5:48 ` Zoltan Kuscsik 2 siblings, 0 replies; 14+ messages in thread From: Khem Raj @ 2015-11-11 4:54 UTC (permalink / raw) To: openembeded-devel On Tue, Nov 10, 2015 at 8:48 PM, Andre McCurdy <armccurdy@gmail.com> wrote: > Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > --- > recipes-browser/chromium/cef3_280796.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-browser/chromium/cef3_280796.bb b/recipes-browser/chromium/cef3_280796.bb > index d827b8e..6872e5b 100644 > --- a/recipes-browser/chromium/cef3_280796.bb > +++ b/recipes-browser/chromium/cef3_280796.bb > @@ -60,5 +60,5 @@ do_qa_configure() { > } > > do_compile() { > - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple > + ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple > } this is ok > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-11 4:48 [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism Andre McCurdy 2015-11-11 4:48 ` [meta-browser][PATCH 2/2] chromium: " Andre McCurdy 2015-11-11 4:54 ` [meta-browser][PATCH 1/2] cef3: " Khem Raj @ 2015-11-11 5:48 ` Zoltan Kuscsik 2015-11-11 6:32 ` Khem Raj 2015-11-11 7:22 ` Andre McCurdy 2 siblings, 2 replies; 14+ messages in thread From: Zoltan Kuscsik @ 2015-11-11 5:48 UTC (permalink / raw) To: openembedded-devel Hi, isn't ninja picking up the number of cores separately? I'm not sure why this is needed. Z On 11 November 2015 at 05:48, Andre McCurdy <armccurdy@gmail.com> wrote: > Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > --- > recipes-browser/chromium/cef3_280796.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-browser/chromium/cef3_280796.bb > b/recipes-browser/chromium/cef3_280796.bb > index d827b8e..6872e5b 100644 > --- a/recipes-browser/chromium/cef3_280796.bb > +++ b/recipes-browser/chromium/cef3_280796.bb > @@ -60,5 +60,5 @@ do_qa_configure() { > } > > do_compile() { > - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple > + ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple > } > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- Zoltan Kuscsik Senior Software Developer, Linaro Digital Home Group email: zoltan.kuscsik@linaro.org IRC: zoli_ on irc.linaro.org ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-11 5:48 ` Zoltan Kuscsik @ 2015-11-11 6:32 ` Khem Raj 2015-11-11 7:22 ` Andre McCurdy 1 sibling, 0 replies; 14+ messages in thread From: Khem Raj @ 2015-11-11 6:32 UTC (permalink / raw) To: openembeded-devel On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik <zoltan.kuscsik@linaro.org> wrote: > Hi, > > isn't ninja picking up the number of cores separately? I'm not sure why > this is needed. > thats another issue. This one atleast improves the current usage a nit. > > Z > > On 11 November 2015 at 05:48, Andre McCurdy <armccurdy@gmail.com> wrote: > >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >> --- >> recipes-browser/chromium/cef3_280796.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/recipes-browser/chromium/cef3_280796.bb >> b/recipes-browser/chromium/cef3_280796.bb >> index d827b8e..6872e5b 100644 >> --- a/recipes-browser/chromium/cef3_280796.bb >> +++ b/recipes-browser/chromium/cef3_280796.bb >> @@ -60,5 +60,5 @@ do_qa_configure() { >> } >> >> do_compile() { >> - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple >> + ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple >> } >> -- >> 1.9.1 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> > > > > -- > Zoltan Kuscsik > > Senior Software Developer, Linaro Digital Home Group > email: zoltan.kuscsik@linaro.org > IRC: zoli_ on irc.linaro.org > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-11 5:48 ` Zoltan Kuscsik 2015-11-11 6:32 ` Khem Raj @ 2015-11-11 7:22 ` Andre McCurdy 2015-11-12 6:07 ` Zoltan Kuscsik 1 sibling, 1 reply; 14+ messages in thread From: Andre McCurdy @ 2015-11-11 7:22 UTC (permalink / raw) To: openembedded-devel On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik <zoltan.kuscsik@linaro.org> wrote: > Hi, > > isn't ninja picking up the number of cores separately? I'm not sure why > this is needed. Without any -j option, ninja will default to "-j (logical_cores + 2)". The PARALLEL_MAKE value configured in OE isn't just about maximising parallelism though (although that's it's common usage), it's also useful to limit parallelism and reduce the load on the CPU. If PARALLEL_MAKE isn't passed to ninja builds then they will always fully load the CPU. > Z > > On 11 November 2015 at 05:48, Andre McCurdy <armccurdy@gmail.com> wrote: > >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> >> --- >> recipes-browser/chromium/cef3_280796.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/recipes-browser/chromium/cef3_280796.bb >> b/recipes-browser/chromium/cef3_280796.bb >> index d827b8e..6872e5b 100644 >> --- a/recipes-browser/chromium/cef3_280796.bb >> +++ b/recipes-browser/chromium/cef3_280796.bb >> @@ -60,5 +60,5 @@ do_qa_configure() { >> } >> >> do_compile() { >> - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple >> + ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple >> } >> -- >> 1.9.1 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> > > > > -- > Zoltan Kuscsik > > Senior Software Developer, Linaro Digital Home Group > email: zoltan.kuscsik@linaro.org > IRC: zoli_ on irc.linaro.org > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-11 7:22 ` Andre McCurdy @ 2015-11-12 6:07 ` Zoltan Kuscsik 2015-11-12 9:26 ` Julien Brianceau (jbriance) 0 siblings, 1 reply; 14+ messages in thread From: Zoltan Kuscsik @ 2015-11-12 6:07 UTC (permalink / raw) To: openembedded-devel Fair enough. Z On 11 November 2015 at 08:22, Andre McCurdy <armccurdy@gmail.com> wrote: > On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik > <zoltan.kuscsik@linaro.org> wrote: > > Hi, > > > > isn't ninja picking up the number of cores separately? I'm not sure why > > this is needed. > > Without any -j option, ninja will default to "-j (logical_cores + 2)". > > The PARALLEL_MAKE value configured in OE isn't just about maximising > parallelism though (although that's it's common usage), it's also > useful to limit parallelism and reduce the load on the CPU. If > PARALLEL_MAKE isn't passed to ninja builds then they will always fully > load the CPU. > > > Z > > > > On 11 November 2015 at 05:48, Andre McCurdy <armccurdy@gmail.com> wrote: > > > >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > >> --- > >> recipes-browser/chromium/cef3_280796.bb | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/recipes-browser/chromium/cef3_280796.bb > >> b/recipes-browser/chromium/cef3_280796.bb > >> index d827b8e..6872e5b 100644 > >> --- a/recipes-browser/chromium/cef3_280796.bb > >> +++ b/recipes-browser/chromium/cef3_280796.bb > >> @@ -60,5 +60,5 @@ do_qa_configure() { > >> } > >> > >> do_compile() { > >> - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} > cefsimple > >> + ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple > >> } > >> -- > >> 1.9.1 > >> > >> -- > >> _______________________________________________ > >> Openembedded-devel mailing list > >> Openembedded-devel@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > >> > > > > > > > > -- > > Zoltan Kuscsik > > > > Senior Software Developer, Linaro Digital Home Group > > email: zoltan.kuscsik@linaro.org > > IRC: zoli_ on irc.linaro.org > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- Zoltan Kuscsik Senior Software Developer, Linaro Digital Home Group email: zoltan.kuscsik@linaro.org IRC: zoli_ on irc.linaro.org ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-12 6:07 ` Zoltan Kuscsik @ 2015-11-12 9:26 ` Julien Brianceau (jbriance) 2015-11-12 9:34 ` Andreas Müller 0 siblings, 1 reply; 14+ messages in thread From: Julien Brianceau (jbriance) @ 2015-11-12 9:26 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org I've added -j in http://patches.openembedded.org/patch/100133/, because chromium recipe wasn't fair to other recipes. For instance, if bitbake is processing 8 compile tasks (incl. chromium) in parallel on a 24 cores machine, 7 recipes will be compiled with -j${BB_NUMBER_THREADS} whereas chromium will use something like -j24 Just out of my curiosity, what "${PARALLEL_MAKE}" brings compared to "-j${BB_NUMBER_THREADS}" ? -----Original Message----- From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Zoltan Kuscsik Sent: jeudi 12 novembre 2015 07:08 To: openembedded-devel <openembedded-devel@lists.openembedded.org> Subject: Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism Fair enough. Z On 11 November 2015 at 08:22, Andre McCurdy <armccurdy@gmail.com> wrote: > On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik > <zoltan.kuscsik@linaro.org> wrote: > > Hi, > > > > isn't ninja picking up the number of cores separately? I'm not sure why > > this is needed. > > Without any -j option, ninja will default to "-j (logical_cores + 2)". > > The PARALLEL_MAKE value configured in OE isn't just about maximising > parallelism though (although that's it's common usage), it's also > useful to limit parallelism and reduce the load on the CPU. If > PARALLEL_MAKE isn't passed to ninja builds then they will always fully > load the CPU. > > > Z > > > > On 11 November 2015 at 05:48, Andre McCurdy <armccurdy@gmail.com> wrote: > > > >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com> > >> --- > >> recipes-browser/chromium/cef3_280796.bb | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/recipes-browser/chromium/cef3_280796.bb > >> b/recipes-browser/chromium/cef3_280796.bb > >> index d827b8e..6872e5b 100644 > >> --- a/recipes-browser/chromium/cef3_280796.bb > >> +++ b/recipes-browser/chromium/cef3_280796.bb > >> @@ -60,5 +60,5 @@ do_qa_configure() { > >> } > >> > >> do_compile() { > >> - ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} > cefsimple > >> + ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple > >> } > >> -- > >> 1.9.1 > >> > >> -- > >> _______________________________________________ > >> Openembedded-devel mailing list > >> Openembedded-devel@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > >> > > > > > > > > -- > > Zoltan Kuscsik > > > > Senior Software Developer, Linaro Digital Home Group > > email: zoltan.kuscsik@linaro.org > > IRC: zoli_ on irc.linaro.org > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- Zoltan Kuscsik Senior Software Developer, Linaro Digital Home Group email: zoltan.kuscsik@linaro.org IRC: zoli_ on irc.linaro.org -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-12 9:26 ` Julien Brianceau (jbriance) @ 2015-11-12 9:34 ` Andreas Müller 2015-11-12 9:44 ` Julien Brianceau (jbriance) 0 siblings, 1 reply; 14+ messages in thread From: Andreas Müller @ 2015-11-12 9:34 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org On Thu, Nov 12, 2015 at 10:26 AM, Julien Brianceau (jbriance) <jbriance@cisco.com> wrote: > I've added -j in http://patches.openembedded.org/patch/100133/, because chromium recipe wasn't fair to other recipes. > For instance, if bitbake is processing 8 compile tasks (incl. chromium) in parallel on a 24 cores machine, 7 recipes will > be compiled with -j${BB_NUMBER_THREADS} whereas chromium will use something like -j24 > > Just out of my curiosity, what "${PARALLEL_MAKE}" brings compared to "-j${BB_NUMBER_THREADS}" ? BB_NUMBER_THREADS -> max bitbake tasks run at the same time PARALLEL_MAKE -> make tasks (gcc) at the same time Andrease ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism 2015-11-12 9:34 ` Andreas Müller @ 2015-11-12 9:44 ` Julien Brianceau (jbriance) 0 siblings, 0 replies; 14+ messages in thread From: Julien Brianceau (jbriance) @ 2015-11-12 9:44 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org That makes sense, thanks for the clarification. -----Original Message----- From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Andreas Müller Sent: jeudi 12 novembre 2015 10:34 To: openembedded-devel@lists.openembedded.org Subject: Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism On Thu, Nov 12, 2015 at 10:26 AM, Julien Brianceau (jbriance) <jbriance@cisco.com> wrote: > I've added -j in http://patches.openembedded.org/patch/100133/, because chromium recipe wasn't fair to other recipes. > For instance, if bitbake is processing 8 compile tasks (incl. chromium) in parallel on a 24 cores machine, 7 recipes will > be compiled with -j${BB_NUMBER_THREADS} whereas chromium will use something like -j24 > > Just out of my curiosity, what "${PARALLEL_MAKE}" brings compared to "-j${BB_NUMBER_THREADS}" ? BB_NUMBER_THREADS -> max bitbake tasks run at the same time PARALLEL_MAKE -> make tasks (gcc) at the same time Andrease -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-11-17 13:19 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-11 4:48 [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism Andre McCurdy 2015-11-11 4:48 ` [meta-browser][PATCH 2/2] chromium: " Andre McCurdy 2015-11-11 4:55 ` Khem Raj 2015-11-14 14:04 ` Nikolay Dimitrov 2015-11-16 18:15 ` Andre McCurdy 2015-11-17 12:32 ` Nikolay Dimitrov 2015-11-11 4:54 ` [meta-browser][PATCH 1/2] cef3: " Khem Raj 2015-11-11 5:48 ` Zoltan Kuscsik 2015-11-11 6:32 ` Khem Raj 2015-11-11 7:22 ` Andre McCurdy 2015-11-12 6:07 ` Zoltan Kuscsik 2015-11-12 9:26 ` Julien Brianceau (jbriance) 2015-11-12 9:34 ` Andreas Müller 2015-11-12 9:44 ` Julien Brianceau (jbriance)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.