Re: [PATCH] efinet: check for broken firmware

[Josef Bacik <jbacik@fb.com>]

On 11/14/2015 09:13 AM, Vladimir 'phcoder' Serbinenko wrote:
> Le 14 nov. 2015 5:08 AM, "Josef Bacik" <jbacik@fb.com
> <mailto:jbacik@fb.com>> a écrit :
>
>  >
>
>  >
>
>  > > On Nov 13, 2015, at 10:19 PM, Andrei Borzenkov <arvidjaar@gmail.com
> <mailto:arvidjaar@gmail.com>> wrote:
>
>  > >
>
>  > > 13.11.2015 22:34, Josef Bacik пишет:
>
>  > >>> On 11/13/2015 09:38 AM, Vladimir 'phcoder' Serbinenko wrote:
>
>  > >>> Please try the patch currently used in Solaris flavour of GRUB. I
> think
>
>  > >>> of upstreaming their mnp driver
>
>  > >>
>
>  > >> This driver doesn't work at all for me.  I may have done a bad job
>
>  > >> porting it, or the firmware is even crappier with MNP, either way it's
>
>  > >> completely unusable.  I'll fix up this patch and send it along.
> Thanks,
>
>  > >
>
>  > > So that I understand. You have a system where a) there is MNP
> Binding Protocol on network device and b) this does not work? Or your
> system does not offer MNP Binding Protocol for device?
>
>  >
>
>  > There is a MNP binding and the driver does not work. It sets
> everything up right but doesn't transmit or receive properly.
>
>  >
>
> Are you sure that the driver itself works? Could you have introduced
> bugs when adapting it?
>

I could have, the only thing I had to do was add the definitions for the 
efi api's that we are missing, so the trigger stuff basically.  It was 
just copy and pasting, it's not like I changed any functionality, I 
didn't touch the driver at all.  Their grub2 version seems to be a 
little older.  If somebody gets a driver into the git tree then I'll 
happily test it, but this port definitely didn't work and I have little 
interest in trying to adapt somebody else's code and trying to debug it. 
  Thanks,

Josef