From: Marc Zyngier <marc.zyngier@arm.com>
To: Steve Capper <steve.capper@linaro.org>
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 04/21] arm64: KVM: Implement vgic-v3 save/restore
Date: Fri, 20 Nov 2015 17:41:53 +0000 [thread overview]
Message-ID: <564F5B61.8000701@arm.com> (raw)
In-Reply-To: <20151120164851.GB24960@linaro.org>
On 20/11/15 16:48, Steve Capper wrote:
> On Mon, Nov 16, 2015 at 01:11:42PM +0000, Marc Zyngier wrote:
>> Implement the vgic-v3 save restore as a direct translation of
>> the assembly code version.
>
> I think there's a couple of typos below Marc.
[...]
>> + case 10:
>> + cpu_if->vgic_lr[LR_OFFSET(19)] = read_gicreg(ICH_LR10_EL2);
>
> LR_OFFSET(10) ?
Memory corruption, here we come!!!! ;-)
Thanks, I'll fix those!
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/21] arm64: KVM: Implement vgic-v3 save/restore
Date: Fri, 20 Nov 2015 17:41:53 +0000 [thread overview]
Message-ID: <564F5B61.8000701@arm.com> (raw)
In-Reply-To: <20151120164851.GB24960@linaro.org>
On 20/11/15 16:48, Steve Capper wrote:
> On Mon, Nov 16, 2015 at 01:11:42PM +0000, Marc Zyngier wrote:
>> Implement the vgic-v3 save restore as a direct translation of
>> the assembly code version.
>
> I think there's a couple of typos below Marc.
[...]
>> + case 10:
>> + cpu_if->vgic_lr[LR_OFFSET(19)] = read_gicreg(ICH_LR10_EL2);
>
> LR_OFFSET(10) ?
Memory corruption, here we come!!!! ;-)
Thanks, I'll fix those!
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-11-20 17:41 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 13:11 [PATCH 00/21] arm64: KVM: world switch in C Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 01/21] arm64: add macros to read/write system registers Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 02/21] arm64: KVM: Add a HYP-specific header file Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 03/21] arm64: KVM: Implement vgic-v2 save/restore Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-20 15:22 ` Steve Capper
2015-11-20 15:22 ` Steve Capper
2015-11-20 15:54 ` Marc Zyngier
2015-11-20 15:54 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 04/21] arm64: KVM: Implement vgic-v3 save/restore Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-20 16:48 ` Steve Capper
2015-11-20 16:48 ` Steve Capper
2015-11-20 17:41 ` Marc Zyngier [this message]
2015-11-20 17:41 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 05/21] arm64: KVM: Implement timer save/restore Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-23 10:47 ` Steve Capper
2015-11-23 10:47 ` Steve Capper
2015-11-25 8:23 ` Marc Zyngier
2015-11-25 8:23 ` Marc Zyngier
2015-11-25 8:23 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 06/21] arm64: KVM: Implement system register save/restore Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 07/21] arm64: KVM: Implement 32bit " Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 08/21] arm64: KVM: Implement debug save/restore Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 09/21] arm64: KVM: Implement guest entry Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 10/21] arm64: KVM: Add patchable function selector Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 11/21] arm64: KVM: Implement the core world switch Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-24 17:29 ` Alex Bennée
2015-11-24 17:29 ` Alex Bennée
2015-11-24 17:40 ` Marc Zyngier
2015-11-24 17:40 ` Marc Zyngier
2015-11-24 17:40 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 12/21] arm64: KVM: Implement fpsimd save/restore Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-17 11:13 ` Steve Capper
2015-11-17 11:13 ` Steve Capper
2015-11-17 11:25 ` Marc Zyngier
2015-11-17 11:25 ` Marc Zyngier
2015-11-17 11:49 ` Steve Capper
2015-11-17 11:49 ` Steve Capper
2015-11-17 11:56 ` Marc Zyngier
2015-11-17 11:56 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 13/21] arm64: KVM: Implement TLB handling Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 14/21] arm64: KVM: HYP mode entry points Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 15/21] arm64: KVM: Add panic handling Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 14:16 ` Mark Rutland
2015-11-16 14:16 ` Mark Rutland
2015-11-16 14:26 ` Marc Zyngier
2015-11-16 14:26 ` Marc Zyngier
2015-11-16 14:32 ` Mark Rutland
2015-11-16 14:32 ` Mark Rutland
2015-11-16 14:44 ` Marc Zyngier
2015-11-16 14:44 ` Marc Zyngier
2015-11-16 15:53 ` Ard Biesheuvel
2015-11-16 15:53 ` Ard Biesheuvel
2015-11-16 16:57 ` Marc Zyngier
2015-11-16 16:57 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 16/21] arm64: KVM: Add compatibility aliases Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 17/21] arm64: KVM: Map the kernel RO section into HYP Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 14:27 ` Mark Rutland
2015-11-16 14:27 ` Mark Rutland
2015-11-16 14:43 ` Marc Zyngier
2015-11-16 14:43 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 18/21] arm64: KVM: Move away from the assembly version of the world switch Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 19/21] arm64: KVM: Turn system register numbers to an enum Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 20/21] arm64: KVM: Cleanup asm-offset.c Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
2015-11-16 13:11 ` [PATCH 21/21] arm64: KVM: Remove weak attributes Marc Zyngier
2015-11-16 13:11 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F5B61.8000701@arm.com \
--to=marc.zyngier@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=steve.capper@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.