still seems to be a pile of "_append +=" stuff in oe-core

still seems to be a pile of "_append +=" stuff in oe-core

[Robert P. J. Day]

  i mentioned this a while back, and it *seems* that there's even more
of this now -- the use of "_append" in conjunction with "+=", which is
clearly(?) redundant.

  one simply needs to run:

$ grep -r "_append.*+=" *

to see how much of that there is. sure, it doesn't hurt, but it's
definitely not good programming practice.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: still seems to be a pile of "_append +=" stuff in oe-core

[Robert Yang]

The _append and += are different, so we need either:

var_append = " foo"
or
var_append += "foo"

for example:

var += "foo"
var = "A"

Then var will be "A".

But:
var_append += "foo"
var = "A"

Then var will be "A foo"

On 11/22/2015 08:04 PM, Robert P. J. Day wrote:
>
>    i mentioned this a while back, and it *seems* that there's even more
> of this now -- the use of "_append" in conjunction with "+=", which is
> clearly(?) redundant.
>
>    one simply needs to run:
>
> $ grep -r "_append.*+=" *
>
> to see how much of that there is. sure, it doesn't hurt, but it's
> definitely not good programming practice.
>
> rday
>

Re: still seems to be a pile of "_append +=" stuff in oe-core

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Sun, Nov 22, 2015 at 8:24 PM, Robert Yang <liezhi.yang@windriver.com>
wrote:

> The _append and += are different, so we need either:
>
> var_append = " foo"
> or
> var_append += "foo"
>
> for example:
>
> var += "foo"
> var = "A"
>
> Then var will be "A".
>
> But:
> var_append += "foo"
> var = "A"
>
> Then var will be "A foo"
>

Yes, but _append += is not preferred by convention, it just adds confusion.
When using _append, make the separator explicit.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1157 bytes --]