All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Covington <cov@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>, Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Måns Rullgård" <mans@mansr.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Stephen Boyd" <sboyd@codeaurora.org>,
	"lkml - Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions
Date: Mon, 23 Nov 2015 09:14:39 -0500	[thread overview]
Message-ID: <56531F4F.9010100@codeaurora.org> (raw)
In-Reply-To: <8472808.1HUuK2O5nn@wuerfel>

On 11/23/2015 03:15 AM, Arnd Bergmann wrote:
> On Sunday 22 November 2015 21:36:45 Nicolas Pitre wrote:
>> On Sun, 22 Nov 2015, Arnd Bergmann wrote:
>>
>>> I've also found some /proc/cpuinfo output to cross-reference SoCs
>>> to their core names.
>>>
>>>               variant part    revision        name            features
>>> dove:         0       0x581   5               PJ4             idivt
>>
>> I just managed to boot my dusty Dove DB and ran a quick test programon 
>> it. Its cpuinfo corresponds to the above.
>>
>> $ cat m.c
>> #include <stdio.h>
>> int mydiv(int, int);
>> int main()
>> {
>>         printf("div test\n");
>>         printf("%d\n", mydiv(12345678, 37));
>>         return 0;
>> }
>> $ cat d.c
>> int mydiv(int x, int y)
>> {
>>         return x/y;
>> }
>> $ gcc -o test m.c d.c
>> $ ./test
>> div test
>> 333666
>> $ gcc -o test m.c d.c -march=armv7ve -mthumb
>> $ ./test
>> div test
>> 333666
>> $ gcc -o test m.c d.c -march=armv7ve -marm
>> $ ./test
>> div test
>> Illegal instruction (core dumped)
>> $
> 
> Ok, thanks a lot! So the reporting in /proc/cpuinfo clearly matches
> the actual features, and we can just treat this as no LPAE / no IDIV
> for kernel compilation, as nobody ever seems to use THUMB2_KERNEL
> in practice.
> 
> PJ4-MP is like Cortex-A15/A7/A12/A17 and supports both IDIV and LPAE,
> which leaves the question whether Scorpion or Krait do the same as
> well, or whether they are outliers and need a special configuration.

LPAE is only supported in the Krait 450.

http://www.anandtech.com/show/7537/qualcomms-snapdragon-805-25ghz-128bit-memory-interface-d3d11class-graphics-more

I'm pretty sure idiv support came earlier, but I don't have the
specifics on hand.

Regards,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: cov@codeaurora.org (Christopher Covington)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions
Date: Mon, 23 Nov 2015 09:14:39 -0500	[thread overview]
Message-ID: <56531F4F.9010100@codeaurora.org> (raw)
In-Reply-To: <8472808.1HUuK2O5nn@wuerfel>

On 11/23/2015 03:15 AM, Arnd Bergmann wrote:
> On Sunday 22 November 2015 21:36:45 Nicolas Pitre wrote:
>> On Sun, 22 Nov 2015, Arnd Bergmann wrote:
>>
>>> I've also found some /proc/cpuinfo output to cross-reference SoCs
>>> to their core names.
>>>
>>>               variant part    revision        name            features
>>> dove:         0       0x581   5               PJ4             idivt
>>
>> I just managed to boot my dusty Dove DB and ran a quick test programon 
>> it. Its cpuinfo corresponds to the above.
>>
>> $ cat m.c
>> #include <stdio.h>
>> int mydiv(int, int);
>> int main()
>> {
>>         printf("div test\n");
>>         printf("%d\n", mydiv(12345678, 37));
>>         return 0;
>> }
>> $ cat d.c
>> int mydiv(int x, int y)
>> {
>>         return x/y;
>> }
>> $ gcc -o test m.c d.c
>> $ ./test
>> div test
>> 333666
>> $ gcc -o test m.c d.c -march=armv7ve -mthumb
>> $ ./test
>> div test
>> 333666
>> $ gcc -o test m.c d.c -march=armv7ve -marm
>> $ ./test
>> div test
>> Illegal instruction (core dumped)
>> $
> 
> Ok, thanks a lot! So the reporting in /proc/cpuinfo clearly matches
> the actual features, and we can just treat this as no LPAE / no IDIV
> for kernel compilation, as nobody ever seems to use THUMB2_KERNEL
> in practice.
> 
> PJ4-MP is like Cortex-A15/A7/A12/A17 and supports both IDIV and LPAE,
> which leaves the question whether Scorpion or Krait do the same as
> well, or whether they are outliers and need a special configuration.

LPAE is only supported in the Krait 450.

http://www.anandtech.com/show/7537/qualcomms-snapdragon-805-25ghz-128bit-memory-interface-d3d11class-graphics-more

I'm pretty sure idiv support came earlier, but I don't have the
specifics on hand.

Regards,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project

  reply	other threads:[~2015-11-23 14:14 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21  1:23 [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions Stephen Boyd
2015-11-21  1:23 ` Stephen Boyd
2015-11-21  1:23 ` [RFC/PATCH 1/3] scripts: Allow recordmcount to be used without tracing enabled Stephen Boyd
2015-11-21  1:23   ` Stephen Boyd
2015-11-21  1:23 ` [RFC/PATCH 2/3] recordmcount: Record locations of __aeabi_{u}idiv() calls on ARM Stephen Boyd
2015-11-21  1:23   ` Stephen Boyd
2015-11-21 10:13   ` Russell King - ARM Linux
2015-11-21 10:13     ` Russell King - ARM Linux
2015-11-23 20:53     ` Stephen Boyd
2015-11-23 20:53       ` Stephen Boyd
2015-11-23 20:58       ` Steven Rostedt
2015-11-23 20:58         ` Steven Rostedt
2015-11-23 21:03       ` Russell King - ARM Linux
2015-11-23 21:03         ` Russell King - ARM Linux
2015-11-23 21:16         ` Stephen Boyd
2015-11-23 21:16           ` Stephen Boyd
2015-11-23 21:33           ` Russell King - ARM Linux
2015-11-23 21:33             ` Russell King - ARM Linux
2015-11-24  1:04             ` Stephen Boyd
2015-11-24  1:04               ` Stephen Boyd
2015-11-21  1:23 ` [RFC/PATCH 3/3] ARM: Replace calls to __aeabi_{u}idiv with udiv/sdiv instructions Stephen Boyd
2015-11-21  1:23   ` Stephen Boyd
2015-11-21 11:50   ` Måns Rullgård
2015-11-21 11:50     ` Måns Rullgård
2015-11-23 20:49     ` Stephen Boyd
2015-11-23 20:49       ` Stephen Boyd
2015-11-23 20:54       ` Måns Rullgård
2015-11-23 20:54         ` Måns Rullgård
2015-11-23 21:16         ` Stephen Boyd
2015-11-23 21:16           ` Stephen Boyd
2015-11-21 20:39 ` [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions Arnd Bergmann
2015-11-21 20:39   ` Arnd Bergmann
2015-11-21 20:45   ` Måns Rullgård
2015-11-21 20:45     ` Måns Rullgård
2015-11-21 21:00     ` Arnd Bergmann
2015-11-21 21:00       ` Arnd Bergmann
2015-11-21 22:11       ` Måns Rullgård
2015-11-21 22:11         ` Måns Rullgård
2015-11-21 23:14         ` Arnd Bergmann
2015-11-21 23:14           ` Arnd Bergmann
2015-11-21 23:21           ` Arnd Bergmann
2015-11-21 23:21             ` Arnd Bergmann
2015-11-22 13:29             ` Peter Maydell
2015-11-22 13:29               ` Peter Maydell
2015-11-22 19:25               ` Arnd Bergmann
2015-11-22 19:25                 ` Arnd Bergmann
2015-11-22 19:30                 ` Måns Rullgård
2015-11-22 19:30                   ` Måns Rullgård
2015-11-22 19:30                   ` Måns Rullgård
2015-11-22 19:47                 ` Russell King - ARM Linux
2015-11-22 19:47                   ` Russell King - ARM Linux
2015-11-22 19:58                   ` Arnd Bergmann
2015-11-22 19:58                     ` Arnd Bergmann
2015-11-22 20:03                     ` Russell King - ARM Linux
2015-11-22 20:03                       ` Russell King - ARM Linux
2015-11-22 20:37                       ` Arnd Bergmann
2015-11-22 20:37                         ` Arnd Bergmann
2015-11-22 20:39                         ` Måns Rullgård
2015-11-22 20:39                           ` Måns Rullgård
2015-11-22 20:39                           ` Måns Rullgård
2015-11-22 21:18                           ` Arnd Bergmann
2015-11-22 21:18                             ` Arnd Bergmann
2015-11-23  2:36                     ` Nicolas Pitre
2015-11-23  2:36                       ` Nicolas Pitre
2015-11-23  8:15                       ` Arnd Bergmann
2015-11-23  8:15                         ` Arnd Bergmann
2015-11-23 14:14                         ` Christopher Covington [this message]
2015-11-23 14:14                           ` Christopher Covington
2015-11-23 15:32                           ` Arnd Bergmann
2015-11-23 15:32                             ` Arnd Bergmann
2015-11-23 20:38                             ` Stephen Boyd
2015-11-23 20:38                               ` Stephen Boyd
2015-11-23 21:19                               ` Arnd Bergmann
2015-11-23 21:19                                 ` Arnd Bergmann
2015-11-23 21:32                                 ` Stephen Boyd
2015-11-23 21:32                                   ` Stephen Boyd
2015-11-23 21:57                                   ` Arnd Bergmann
2015-11-23 21:57                                     ` Arnd Bergmann
2015-11-23 23:13                                     ` Stephen Boyd
2015-11-23 23:13                                       ` Stephen Boyd
2015-11-24 10:17                                       ` Arnd Bergmann
2015-11-24 10:17                                         ` Arnd Bergmann
2015-11-24 12:15                                         ` Måns Rullgård
2015-11-24 12:15                                           ` Måns Rullgård
2015-11-24 12:15                                           ` Måns Rullgård
2015-11-24 13:45                                           ` Arnd Bergmann
2015-11-24 13:45                                             ` Arnd Bergmann
2015-11-25  1:51                                         ` Stephen Boyd
2015-11-25  1:51                                           ` Stephen Boyd
2015-11-25  7:21                                           ` Arnd Bergmann
2015-11-25  7:21                                             ` Arnd Bergmann
2015-11-24  0:13                                     ` Stephen Boyd
2015-11-24  0:13                                       ` Stephen Boyd
2015-11-24  8:53                                       ` Stephen Boyd
2015-11-24  8:53                                         ` Stephen Boyd
2015-11-24 10:38                                         ` Arnd Bergmann
2015-11-24 10:38                                           ` Arnd Bergmann
2015-11-24 10:42                                           ` Russell King - ARM Linux
2015-11-24 10:42                                             ` Russell King - ARM Linux
2015-11-24 10:42                                             ` Russell King - ARM Linux
2015-11-24 12:10                                             ` Måns Rullgård
2015-11-24 12:10                                               ` Måns Rullgård
2015-11-24 12:10                                               ` Måns Rullgård
2015-11-24 12:23                                               ` Russell King - ARM Linux
2015-11-24 12:23                                                 ` Russell King - ARM Linux
2015-11-24 12:29                                                 ` Måns Rullgård
2015-11-24 12:29                                                   ` Måns Rullgård
2015-11-24 12:29                                                   ` Måns Rullgård
2015-11-24 14:00                                                   ` Russell King - ARM Linux
2015-11-24 14:00                                                     ` Russell King - ARM Linux
2015-11-24 14:03                                                     ` Måns Rullgård
2015-11-24 14:03                                                       ` Måns Rullgård
2015-11-24 14:03                                                       ` Måns Rullgård
2015-11-24 10:39                                         ` Russell King - ARM Linux
2015-11-24 10:39                                           ` Russell King - ARM Linux
2015-11-24 20:07                                           ` Stephen Boyd
2015-11-24 20:07                                             ` Stephen Boyd
2015-11-24 20:35                                             ` Russell King - ARM Linux
2015-11-24 20:35                                               ` Russell King - ARM Linux
2015-11-24 21:11                                               ` Arnd Bergmann
2015-11-24 21:11                                                 ` Arnd Bergmann
2016-01-13  1:51                                               ` Stephen Boyd
2016-01-13  1:51                                                 ` Stephen Boyd
2015-11-24 10:37                                       ` Russell King - ARM Linux
2015-11-24 10:37                                         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56531F4F.9010100@codeaurora.org \
    --to=cov@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mans@mansr.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=rostedt@goodmis.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.