From: Tero Kristo <t-kristo@ti.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: <linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] ti/fapll: fix wrong do_div() usage
Date: Tue, 24 Nov 2015 11:35:48 +0200 [thread overview]
Message-ID: <56542F74.3080200@ti.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1511032314240.630@knanqh.ubzr>
On 11/04/2015 06:17 AM, Nicolas Pitre wrote:
> do_div() is meant to be used with an unsigned dividend.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Fixed Subject locally to format "clk: ti: %s".
Queued for 4.4-rc-fixes, thanks.
-Tero
>
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index f4b2e9888b..66a0d0ed8b 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -168,7 +168,7 @@ static unsigned long ti_fapll_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_data *fd = to_fapll(hw);
> u32 fapll_n, fapll_p, v;
> - long long rate;
> + u64 rate;
>
> if (ti_fapll_clock_is_bypass(fd))
> return parent_rate;
> @@ -314,7 +314,7 @@ static unsigned long ti_fapll_synth_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_synth *synth = to_synth(hw);
> u32 synth_div_m;
> - long long rate;
> + u64 rate;
>
> /* The audio_pll_clk1 is hardwired to produce 32.768KiHz clock */
> if (!synth->div)
>
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-omap@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] ti/fapll: fix wrong do_div() usage
Date: Tue, 24 Nov 2015 11:35:48 +0200 [thread overview]
Message-ID: <56542F74.3080200@ti.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1511032314240.630@knanqh.ubzr>
On 11/04/2015 06:17 AM, Nicolas Pitre wrote:
> do_div() is meant to be used with an unsigned dividend.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Fixed Subject locally to format "clk: ti: %s".
Queued for 4.4-rc-fixes, thanks.
-Tero
>
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index f4b2e9888b..66a0d0ed8b 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -168,7 +168,7 @@ static unsigned long ti_fapll_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_data *fd = to_fapll(hw);
> u32 fapll_n, fapll_p, v;
> - long long rate;
> + u64 rate;
>
> if (ti_fapll_clock_is_bypass(fd))
> return parent_rate;
> @@ -314,7 +314,7 @@ static unsigned long ti_fapll_synth_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_synth *synth = to_synth(hw);
> u32 synth_div_m;
> - long long rate;
> + u64 rate;
>
> /* The audio_pll_clk1 is hardwired to produce 32.768KiHz clock */
> if (!synth->div)
>
next prev parent reply other threads:[~2015-11-24 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 4:17 [PATCH] ti/fapll: fix wrong do_div() usage Nicolas Pitre
2015-11-24 9:35 ` Tero Kristo [this message]
2015-11-24 9:35 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56542F74.3080200@ti.com \
--to=t-kristo@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.pitre@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.