* [PATCH] ti/fapll: fix wrong do_div() usage
@ 2015-11-04 4:17 Nicolas Pitre
2015-11-24 9:35 ` Tero Kristo
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Pitre @ 2015-11-04 4:17 UTC (permalink / raw)
To: Tero Kristo, Michael Turquette; +Cc: linux-omap, linux-clk
do_div() is meant to be used with an unsigned dividend.
Signed-off-by: Nicolas Pitre <nico@linaro.org>
diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
index f4b2e9888b..66a0d0ed8b 100644
--- a/drivers/clk/ti/fapll.c
+++ b/drivers/clk/ti/fapll.c
@@ -168,7 +168,7 @@ static unsigned long ti_fapll_recalc_rate(struct clk_hw *hw,
{
struct fapll_data *fd = to_fapll(hw);
u32 fapll_n, fapll_p, v;
- long long rate;
+ u64 rate;
if (ti_fapll_clock_is_bypass(fd))
return parent_rate;
@@ -314,7 +314,7 @@ static unsigned long ti_fapll_synth_recalc_rate(struct clk_hw *hw,
{
struct fapll_synth *synth = to_synth(hw);
u32 synth_div_m;
- long long rate;
+ u64 rate;
/* The audio_pll_clk1 is hardwired to produce 32.768KiHz clock */
if (!synth->div)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ti/fapll: fix wrong do_div() usage
2015-11-04 4:17 [PATCH] ti/fapll: fix wrong do_div() usage Nicolas Pitre
@ 2015-11-24 9:35 ` Tero Kristo
0 siblings, 0 replies; 3+ messages in thread
From: Tero Kristo @ 2015-11-24 9:35 UTC (permalink / raw)
To: Nicolas Pitre, Michael Turquette; +Cc: linux-omap, linux-clk
On 11/04/2015 06:17 AM, Nicolas Pitre wrote:
> do_div() is meant to be used with an unsigned dividend.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Fixed Subject locally to format "clk: ti: %s".
Queued for 4.4-rc-fixes, thanks.
-Tero
>
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index f4b2e9888b..66a0d0ed8b 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -168,7 +168,7 @@ static unsigned long ti_fapll_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_data *fd = to_fapll(hw);
> u32 fapll_n, fapll_p, v;
> - long long rate;
> + u64 rate;
>
> if (ti_fapll_clock_is_bypass(fd))
> return parent_rate;
> @@ -314,7 +314,7 @@ static unsigned long ti_fapll_synth_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_synth *synth = to_synth(hw);
> u32 synth_div_m;
> - long long rate;
> + u64 rate;
>
> /* The audio_pll_clk1 is hardwired to produce 32.768KiHz clock */
> if (!synth->div)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ti/fapll: fix wrong do_div() usage
@ 2015-11-24 9:35 ` Tero Kristo
0 siblings, 0 replies; 3+ messages in thread
From: Tero Kristo @ 2015-11-24 9:35 UTC (permalink / raw)
To: Nicolas Pitre, Michael Turquette; +Cc: linux-omap, linux-clk
On 11/04/2015 06:17 AM, Nicolas Pitre wrote:
> do_div() is meant to be used with an unsigned dividend.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Fixed Subject locally to format "clk: ti: %s".
Queued for 4.4-rc-fixes, thanks.
-Tero
>
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index f4b2e9888b..66a0d0ed8b 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -168,7 +168,7 @@ static unsigned long ti_fapll_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_data *fd = to_fapll(hw);
> u32 fapll_n, fapll_p, v;
> - long long rate;
> + u64 rate;
>
> if (ti_fapll_clock_is_bypass(fd))
> return parent_rate;
> @@ -314,7 +314,7 @@ static unsigned long ti_fapll_synth_recalc_rate(struct clk_hw *hw,
> {
> struct fapll_synth *synth = to_synth(hw);
> u32 synth_div_m;
> - long long rate;
> + u64 rate;
>
> /* The audio_pll_clk1 is hardwired to produce 32.768KiHz clock */
> if (!synth->div)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-24 9:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-04 4:17 [PATCH] ti/fapll: fix wrong do_div() usage Nicolas Pitre
2015-11-24 9:35 ` Tero Kristo
2015-11-24 9:35 ` Tero Kristo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.