From: salil.mehta@huawei.com (Salil Mehta)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver
Date: Thu, 26 Nov 2015 08:19:26 +0000 [thread overview]
Message-ID: <5656C08E.2010105@huawei.com> (raw)
In-Reply-To: <CO2PR11MB00885067453FB6462178765497180@CO2PR11MB0088.namprd11.prod.outlook.com>
On 11/22/2015 8:49 AM, Yuval Mintz wrote:
>> +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int
>> +enable) {
>> + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle);
>> +
>> + hns_ppe_set_tso_enable(ppe_cb, enable); }
> Style issues?
I could not see the code style issue menioned above in earlier submitted
patch. Looks like I am misssing something here!
+static void hns_ae_set_tso_stats(struct hnae_handle *handle, int enable)
+{
+ struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle);
+
+ hns_ppe_set_tso_enable(ppe_cb, enable);
+}
+
>
>> +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) {
>> + dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value); }
>> +
> Likewise
Same in above case. Hope I am not missing anything.
#include "hns_dsaf_ppe.h"
+void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value)
+{
+ dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value);
+}
+
WARNING: multiple messages have this Message-ID (diff)
From: Salil Mehta <salil.mehta@huawei.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>,
David Miller <davem@davemloft.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"liguozhu@hisilicon.com" <liguozhu@hisilicon.com>,
"yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
"dingtianhong@huawei.com" <dingtianhong@huawei.com>,
"zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
"huangdaode@hisilicon.com" <huangdaode@hisilicon.com>,
"kenneth-lee-2012@foxmail.com" <kenneth-lee-2012@foxmail.com>,
"mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
"xuwei5@hisilicon.com" <xuwei5@hisilicon.com>,
"lisheng011@huawei.com" <lisheng011@huawei.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: Re: [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver
Date: Thu, 26 Nov 2015 08:19:26 +0000 [thread overview]
Message-ID: <5656C08E.2010105@huawei.com> (raw)
In-Reply-To: <CO2PR11MB00885067453FB6462178765497180@CO2PR11MB0088.namprd11.prod.outlook.com>
On 11/22/2015 8:49 AM, Yuval Mintz wrote:
>> +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int
>> +enable) {
>> + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle);
>> +
>> + hns_ppe_set_tso_enable(ppe_cb, enable); }
> Style issues?
I could not see the code style issue menioned above in earlier submitted
patch. Looks like I am misssing something here!
+static void hns_ae_set_tso_stats(struct hnae_handle *handle, int enable)
+{
+ struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle);
+
+ hns_ppe_set_tso_enable(ppe_cb, enable);
+}
+
>
>> +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) {
>> + dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value); }
>> +
> Likewise
Same in above case. Hope I am not missing anything.
#include "hns_dsaf_ppe.h"
+void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value)
+{
+ dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value);
+}
+
next prev parent reply other threads:[~2015-11-26 8:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 20:58 [PATCH V3 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 1/5] " Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
[not found] ` <1447966706-16219-2-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-22 9:19 ` Yuval Mintz
2015-11-22 9:19 ` Yuval Mintz
2015-11-22 9:19 ` Yuval Mintz
2015-11-22 9:19 ` Yuval Mintz
2015-11-26 7:44 ` Salil Mehta
2015-11-26 7:44 ` Salil Mehta
2015-11-26 7:44 ` Salil Mehta
2015-11-26 7:44 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-22 9:30 ` Yuval Mintz
2015-11-22 9:30 ` Yuval Mintz
2015-11-26 7:31 ` Salil Mehta
2015-11-26 7:31 ` Salil Mehta
2015-11-26 7:31 ` Salil Mehta
2015-11-26 7:31 ` Salil Mehta
2015-11-22 9:30 ` Yuval Mintz
[not found] ` <1447966706-16219-3-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-22 9:30 ` Yuval Mintz
2015-11-19 20:58 ` [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support " Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
[not found] ` <1447966706-16219-4-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-22 8:49 ` Yuval Mintz
2015-11-22 8:49 ` Yuval Mintz
2015-11-22 8:49 ` Yuval Mintz
2015-11-22 8:49 ` Yuval Mintz
2015-11-26 8:19 ` Salil Mehta
2015-11-26 8:19 ` Salil Mehta [this message]
2015-11-26 8:19 ` Salil Mehta
[not found] ` <CO2PR11MB00885067453FB6462178765497180-aWXWhCNu7Z/c7AgKY82GyJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-11-26 8:19 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-20 14:07 ` Sergei Shtylyov
2015-11-20 14:07 ` Sergei Shtylyov
2015-11-23 12:05 ` Salil Mehta
2015-11-23 12:05 ` Salil Mehta
2015-11-19 20:58 ` [PATCH V3 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist" Salil Mehta
2015-11-19 20:58 ` Salil Mehta
2015-11-19 20:58 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656C08E.2010105@huawei.com \
--to=salil.mehta@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.