From: "Mickaël Salaün" <mic@digikod.net>
To: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Cc: Jeff Dike <jdike@addtoit.com>,
Tristan Schmelcher <tschmelcher@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/2] um: Use race-free temporary file creation
Date: Sun, 29 Nov 2015 00:02:07 +0100 [thread overview]
Message-ID: <565A326F.4050005@digikod.net> (raw)
In-Reply-To: <565A31B6.5050802@nod.at>
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
>>>> + errno != EOPNOTSUPP))
>>>> + return fd;
>>>> + errno = 0;
>>>
>>> Why are you resetting errno?
>>
>> It's to ignore/reset the error code from open, but it may not be needed because of the next call to malloc?
>
> But then you'd have to reset errno after every syscall. :-)
OK, I will remove it then :)
Mickaël
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2015-11-28 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 21:32 [PATCH 0/2] um: Protect memory mapped file Mickaël Salaün
2015-11-28 21:32 ` Mickaël Salaün
2015-11-28 21:32 ` [PATCH 1/2] um: Set secure access mode for temporary file Mickaël Salaün
2015-11-28 21:32 ` Mickaël Salaün
2015-11-28 21:40 ` [uml-devel] " Richard Weinberger
2015-11-28 21:40 ` Richard Weinberger
2015-11-28 22:52 ` Mickaël Salaün
2015-11-28 22:55 ` Richard Weinberger
2015-11-28 22:55 ` Richard Weinberger
2015-11-28 23:00 ` Mickaël Salaün
2015-11-28 23:11 ` Richard Weinberger
2015-11-28 23:11 ` Richard Weinberger
2015-11-28 21:32 ` [PATCH 2/2] um: Use race-free temporary file creation Mickaël Salaün
2015-11-28 21:32 ` Mickaël Salaün
2015-11-28 22:07 ` [uml-devel] " Richard Weinberger
2015-11-28 22:07 ` Richard Weinberger
2015-11-28 22:56 ` Mickaël Salaün
2015-11-28 22:59 ` Richard Weinberger
2015-11-28 22:59 ` Richard Weinberger
2015-11-28 23:02 ` Mickaël Salaün [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565A326F.4050005@digikod.net \
--to=mic@digikod.net \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tschmelcher@google.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.