From: Richard Weinberger <richard@nod.at>
To: "Mickaël Salaün" <mic@digikod.net>, linux-kernel@vger.kernel.org
Cc: user-mode-linux-user@lists.sourceforge.net,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 2/2] um: Use race-free temporary file creation
Date: Sat, 28 Nov 2015 23:07:09 +0100 [thread overview]
Message-ID: <565A258D.4040206@nod.at> (raw)
In-Reply-To: <1448746350-19998-3-git-send-email-mic@digikod.net>
Am 28.11.2015 um 22:32 schrieb Mickaël Salaün:
> Open the memory mapped file with the O_TMPFILE flag when available.
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> ---
> arch/um/os-Linux/mem.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
> index 798aeb4..fe52e2d 100644
> --- a/arch/um/os-Linux/mem.c
> +++ b/arch/um/os-Linux/mem.c
> @@ -106,6 +106,18 @@ static int __init make_tempfile(const char *template)
> }
> }
>
> +#ifdef O_TMPFILE
> + fd = open(tempdir, O_CLOEXEC | O_RDWR | O_EXCL | O_TMPFILE, 0700);
> + /*
> + * If the running system does not support O_TMPFILE flag then retry
> + * without it.
> + */
> + if (fd != -1 || (errno != EINVAL && errno != EISDIR &&
Why are you handling EISDIR?
> + errno != EOPNOTSUPP))
> + return fd;
> + errno = 0;
Why are you resetting errno?
Thanks,
//richard
------------------------------------------------------------------------------
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: "Mickaël Salaün" <mic@digikod.net>, linux-kernel@vger.kernel.org
Cc: Jeff Dike <jdike@addtoit.com>,
Tristan Schmelcher <tschmelcher@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net
Subject: Re: [PATCH 2/2] um: Use race-free temporary file creation
Date: Sat, 28 Nov 2015 23:07:09 +0100 [thread overview]
Message-ID: <565A258D.4040206@nod.at> (raw)
In-Reply-To: <1448746350-19998-3-git-send-email-mic@digikod.net>
Am 28.11.2015 um 22:32 schrieb Mickaël Salaün:
> Open the memory mapped file with the O_TMPFILE flag when available.
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> ---
> arch/um/os-Linux/mem.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
> index 798aeb4..fe52e2d 100644
> --- a/arch/um/os-Linux/mem.c
> +++ b/arch/um/os-Linux/mem.c
> @@ -106,6 +106,18 @@ static int __init make_tempfile(const char *template)
> }
> }
>
> +#ifdef O_TMPFILE
> + fd = open(tempdir, O_CLOEXEC | O_RDWR | O_EXCL | O_TMPFILE, 0700);
> + /*
> + * If the running system does not support O_TMPFILE flag then retry
> + * without it.
> + */
> + if (fd != -1 || (errno != EINVAL && errno != EISDIR &&
Why are you handling EISDIR?
> + errno != EOPNOTSUPP))
> + return fd;
> + errno = 0;
Why are you resetting errno?
Thanks,
//richard
next prev parent reply other threads:[~2015-11-28 22:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 21:32 [PATCH 0/2] um: Protect memory mapped file Mickaël Salaün
2015-11-28 21:32 ` Mickaël Salaün
2015-11-28 21:32 ` [PATCH 1/2] um: Set secure access mode for temporary file Mickaël Salaün
2015-11-28 21:32 ` Mickaël Salaün
2015-11-28 21:40 ` [uml-devel] " Richard Weinberger
2015-11-28 21:40 ` Richard Weinberger
2015-11-28 22:52 ` Mickaël Salaün
2015-11-28 22:55 ` Richard Weinberger
2015-11-28 22:55 ` Richard Weinberger
2015-11-28 23:00 ` Mickaël Salaün
2015-11-28 23:11 ` Richard Weinberger
2015-11-28 23:11 ` Richard Weinberger
2015-11-28 21:32 ` [PATCH 2/2] um: Use race-free temporary file creation Mickaël Salaün
2015-11-28 21:32 ` Mickaël Salaün
2015-11-28 22:07 ` Richard Weinberger [this message]
2015-11-28 22:07 ` Richard Weinberger
2015-11-28 22:56 ` Mickaël Salaün
2015-11-28 22:59 ` Richard Weinberger
2015-11-28 22:59 ` Richard Weinberger
2015-11-28 23:02 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565A258D.4040206@nod.at \
--to=richard@nod.at \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.