From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: EXT Wolfram Sang <wsa@the-dreams.de>
Cc: Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-i2c@vger.kernel.org, Murali Karicheri <m-karicheri2@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: Re: [PATCH] i2c: davinci: Increase module clock frequency
Date: Mon, 30 Nov 2015 15:00:12 +0100 [thread overview]
Message-ID: <565C566C.7000809@nokia.com> (raw)
In-Reply-To: <20151130135504.GE1513@katana>
Hi!
On 30.11.2015 14:55, EXT Wolfram Sang wrote:
>> /* get minimum of 7 MHz clock, but max of 12 MHz */
>> > - psc = (input_clock / 7000000) - 1;
>> > + psc = (input_clock / 12000000) - 1;
> Doesn't make this the above comment invalid?
The comment refers to datasheet, not really to the code. And eventual changes to the datasheet
that's what can make it invalid (though I don't know TI's plans on it). Nevertheless, yes, I
think, it's better to drop the comment. Should I re-spin the patch with comment removal in it?
--
Best regards,
Alexander Sverdlin.
Sent from my pdp-11
next prev parent reply other threads:[~2015-11-30 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 12:21 [PATCH] i2c: davinci: Increase module clock frequency Alexander Sverdlin
2015-11-20 0:22 ` santosh shilimkar
2015-11-30 13:55 ` Wolfram Sang
2015-11-30 14:00 ` Alexander Sverdlin [this message]
2015-11-30 14:10 ` Wolfram Sang
2015-11-30 14:51 ` [PATCH v2] " Alexander Sverdlin
2015-11-30 14:56 ` Wolfram Sang
2015-11-30 15:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565C566C.7000809@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.