From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Huaitong Han <huaitong.han@intel.com>
Subject: Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes
Date: Tue, 1 Dec 2015 16:09:44 +0100 [thread overview]
Message-ID: <565DB838.5010005@redhat.com> (raw)
In-Reply-To: <1448904887-4977-1-git-send-email-ehabkost@redhat.com>
On 30/11/2015 18:34, Eduardo Habkost wrote:
> target-i386/cpu.c:ext_save_area uses magic numbers for the xsave
> area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave()
> uses offset macros and bit manipulation to access the xsave area.
> This series changes both to use C structs for those operations.
>
> I still need to figure out a way to write unit tests for the new
> code. Maybe I will just copy and paste the new and old functions,
> and test them locally (checking if they give the same results
> when translating blobs of random bytes).
I think it's easier to use small guests (i.e. kvm-unit-tests) to test
this code.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Huaitong Han <huaitong.han@intel.com>, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes
Date: Tue, 1 Dec 2015 16:09:44 +0100 [thread overview]
Message-ID: <565DB838.5010005@redhat.com> (raw)
In-Reply-To: <1448904887-4977-1-git-send-email-ehabkost@redhat.com>
On 30/11/2015 18:34, Eduardo Habkost wrote:
> target-i386/cpu.c:ext_save_area uses magic numbers for the xsave
> area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave()
> uses offset macros and bit manipulation to access the xsave area.
> This series changes both to use C structs for those operations.
>
> I still need to figure out a way to write unit tests for the new
> code. Maybe I will just copy and paste the new and old functions,
> and test them locally (checking if they give the same results
> when translating blobs of random bytes).
I think it's easier to use small guests (i.e. kvm-unit-tests) to test
this code.
Paolo
next prev parent reply other threads:[~2015-12-01 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 17:34 [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 17:34 ` [PATCH v2 1/3] target-i386: Define structs for layout of xsave area Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 17:34 ` [PATCH v2 2/3] target-i386: Use xsave structs for ext_save_area Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 17:34 ` [PATCH v2 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 10:22 ` [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Paolo Bonzini
2015-12-01 10:22 ` [Qemu-devel] " Paolo Bonzini
2015-12-01 15:27 ` Eduardo Habkost
2015-12-01 15:27 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 15:09 ` Paolo Bonzini [this message]
2015-12-01 15:09 ` Paolo Bonzini
2015-12-01 15:25 ` Eduardo Habkost
2015-12-01 15:25 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 15:28 ` Paolo Bonzini
2015-12-01 15:28 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DB838.5010005@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.