From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Huaitong Han <huaitong.han@intel.com>
Subject: Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes
Date: Tue, 1 Dec 2015 16:28:19 +0100 [thread overview]
Message-ID: <565DBC93.8000001@redhat.com> (raw)
In-Reply-To: <20151201152535.GK23717@thinpad.lan.raisama.net>
On 01/12/2015 16:25, Eduardo Habkost wrote:
> > I think it's easier to use small guests (i.e. kvm-unit-tests) to test
> > this code.
>
> I agree it's easier, but how likely it is to catch bugs in the
> save/load code? If the code corrupts a register, we need to
> trigger a save/load cycle at the exact moment the guest code is
> using that register. Do we have something that helps us
> repeatedly save/load CPU state while kvm-unit-tests is running?
A vmware magic port read should do that. Put VMPORT_MAGIC in EAX and
VMPORT_CMD_GETVERSION in ECX, then do a 32-bit in from port 0x5658.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Huaitong Han <huaitong.han@intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes
Date: Tue, 1 Dec 2015 16:28:19 +0100 [thread overview]
Message-ID: <565DBC93.8000001@redhat.com> (raw)
In-Reply-To: <20151201152535.GK23717@thinpad.lan.raisama.net>
On 01/12/2015 16:25, Eduardo Habkost wrote:
> > I think it's easier to use small guests (i.e. kvm-unit-tests) to test
> > this code.
>
> I agree it's easier, but how likely it is to catch bugs in the
> save/load code? If the code corrupts a register, we need to
> trigger a save/load cycle at the exact moment the guest code is
> using that register. Do we have something that helps us
> repeatedly save/load CPU state while kvm-unit-tests is running?
A vmware magic port read should do that. Put VMPORT_MAGIC in EAX and
VMPORT_CMD_GETVERSION in ECX, then do a 32-bit in from port 0x5658.
Paolo
next prev parent reply other threads:[~2015-12-01 15:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 17:34 [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 17:34 ` [PATCH v2 1/3] target-i386: Define structs for layout of xsave area Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 17:34 ` [PATCH v2 2/3] target-i386: Use xsave structs for ext_save_area Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 17:34 ` [PATCH v2 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load Eduardo Habkost
2015-11-30 17:34 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 10:22 ` [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Paolo Bonzini
2015-12-01 10:22 ` [Qemu-devel] " Paolo Bonzini
2015-12-01 15:27 ` Eduardo Habkost
2015-12-01 15:27 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 15:09 ` Paolo Bonzini
2015-12-01 15:09 ` [Qemu-devel] " Paolo Bonzini
2015-12-01 15:25 ` Eduardo Habkost
2015-12-01 15:25 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 15:28 ` Paolo Bonzini [this message]
2015-12-01 15:28 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DBC93.8000001@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.