All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark yao <mark.yao@rock-chips.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, akpm@linux-foundation.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Fix module autoload for OF platform driver
Date: Wed, 02 Dec 2015 08:57:08 +0800	[thread overview]
Message-ID: <565E41E4.4060606@rock-chips.com> (raw)
In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com>

On 2015年11月30日 22:56, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> This is a Resend of a patch from October 20th [0]
>
> I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
> Forum.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> A multitude of similar patches have been merged for other drivers, search
> the git log for "module autoload for OF platform driver".
>
> Thanks,
> Luis
>
> [0] https://lkml.org/lkml/2015/10/20/485
>
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 5d8ae5e..5897851 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -374,6 +374,7 @@ static const struct of_device_id vop_driver_dt_match[] = {
>   	  .data = &rk3288_vop },
>   	{},
>   };
> +MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>   
>   static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
>   {
Applied to my drm-fixes, Thanks for this fix.

-- 
Ｍark Yao


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: Fix module autoload for OF platform driver
Date: Wed, 02 Dec 2015 08:57:08 +0800	[thread overview]
Message-ID: <565E41E4.4060606@rock-chips.com> (raw)
In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com>

On 2015?11?30? 22:56, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> This is a Resend of a patch from October 20th [0]
>
> I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
> Forum.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> A multitude of similar patches have been merged for other drivers, search
> the git log for "module autoload for OF platform driver".
>
> Thanks,
> Luis
>
> [0] https://lkml.org/lkml/2015/10/20/485
>
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 5d8ae5e..5897851 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -374,6 +374,7 @@ static const struct of_device_id vop_driver_dt_match[] = {
>   	  .data = &rk3288_vop },
>   	{},
>   };
> +MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>   
>   static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
>   {
Applied to my drm-fixes, Thanks for this fix.

-- 
?ark Yao

WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: airlied@linux.ie, heiko@sntech.de,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH] drm/rockchip: Fix module autoload for OF platform driver
Date: Wed, 02 Dec 2015 08:57:08 +0800	[thread overview]
Message-ID: <565E41E4.4060606@rock-chips.com> (raw)
In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com>

On 2015年11月30日 22:56, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> This is a Resend of a patch from October 20th [0]
>
> I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
> Forum.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> A multitude of similar patches have been merged for other drivers, search
> the git log for "module autoload for OF platform driver".
>
> Thanks,
> Luis
>
> [0] https://lkml.org/lkml/2015/10/20/485
>
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 5d8ae5e..5897851 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -374,6 +374,7 @@ static const struct of_device_id vop_driver_dt_match[] = {
>   	  .data = &rk3288_vop },
>   	{},
>   };
> +MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
>   
>   static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
>   {
Applied to my drm-fixes, Thanks for this fix.

-- 
Ｍark Yao



  reply	other threads:[~2015-12-02  0:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 14:56 [PATCH] drm/rockchip: Fix module autoload for OF platform driver Luis de Bethencourt
2015-11-30 14:56 ` Luis de Bethencourt
2015-12-02  0:57 ` Mark yao [this message]
2015-12-02  0:57   ` Mark yao
2015-12-02  0:57   ` Mark yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565E41E4.4060606@rock-chips.com \
    --to=mark.yao@rock-chips.com \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=luisbg@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.