All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH net] ravb: Add disable 10base
Date: Sun, 13 Dec 2015 17:17:48 +0000	[thread overview]
Message-ID: <566DA83C.9080801@cogentembedded.com> (raw)
In-Reply-To: <1450019758-32710-1-git-send-email-ykaneko0929@gmail.com>

Hello.

On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Ethernet AVB does not support 10 Mbps transfer speed.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the master branch of David Miller's networking
> tree.
>
>   drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index b69e0c2..467d416 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
>   		netdev_info(ndev, "limited PHY to 100Mbit/s\n");
>   	}
>
> +	/* 10BASE is not supported */
> +	phydev->supported &= ~PHY_10BT_FEATURES;
> +

    Perhaps we need phy_set_min_speed() in addition to phy_set_max_speed()?

MBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH net] ravb: Add disable 10base
Date: Sun, 13 Dec 2015 20:17:48 +0300	[thread overview]
Message-ID: <566DA83C.9080801@cogentembedded.com> (raw)
In-Reply-To: <1450019758-32710-1-git-send-email-ykaneko0929@gmail.com>

Hello.

On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Ethernet AVB does not support 10 Mbps transfer speed.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the master branch of David Miller's networking
> tree.
>
>   drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index b69e0c2..467d416 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
>   		netdev_info(ndev, "limited PHY to 100Mbit/s\n");
>   	}
>
> +	/* 10BASE is not supported */
> +	phydev->supported &= ~PHY_10BT_FEATURES;
> +

    Perhaps we need phy_set_min_speed() in addition to phy_set_max_speed()?

MBR, Sergei

  reply	other threads:[~2015-12-13 17:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-13 15:15 [PATCH net] ravb: Add disable 10base Yoshihiro Kaneko
2015-12-13 15:15 ` Yoshihiro Kaneko
2015-12-13 17:17 ` Sergei Shtylyov [this message]
2015-12-13 17:17   ` Sergei Shtylyov
2015-12-14  4:53   ` Simon Horman
2015-12-14  4:53     ` Simon Horman
2015-12-14 18:49     ` Florian Fainelli
2015-12-14 18:49       ` Florian Fainelli
2015-12-14 17:31 ` Sergei Shtylyov
2015-12-14 17:31   ` Sergei Shtylyov
2015-12-14 18:49   ` Florian Fainelli
2015-12-14 18:49     ` Florian Fainelli
2015-12-15 11:41     ` Sergei Shtylyov
2015-12-15 11:41       ` Sergei Shtylyov
2015-12-15  5:26 ` David Miller
2015-12-15  5:26   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566DA83C.9080801@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.