Re: [PATCH net] ravb: Add disable 10base

[Florian Fainelli <f.fainelli@gmail.com>]

On 14/12/15 09:31, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:
> 
>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>
>> Ethernet AVB does not support 10 Mbps transfer speed.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on the master branch of David Miller's networking
>> tree.
>>
>>   drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>> b/drivers/net/ethernet/renesas/ravb_main.c
>> index b69e0c2..467d416 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
>>           netdev_info(ndev, "limited PHY to 100Mbit/s\n");
>>       }
>>
>> +    /* 10BASE is not supported */
>> +    phydev->supported &= ~PHY_10BT_FEATURES;
> 
>    I wonder if we should also modify 'phydev->advertising' like
> phy_set_max_speed() does...

Yes, this is a good idea. If your PHY driver uses genphy_config_advert()
this is taken care of for you, but in case you have a buggy PHY driver,
you should just do this yourself here.
-- 
Florian