From: vz@mleia.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator
Date: Sun, 20 Dec 2015 04:14:19 +0200 [thread overview]
Message-ID: <56760EFB.9070406@mleia.com> (raw)
In-Reply-To: <20151219234848.GT8644@n2100.arm.linux.org.uk>
On 20.12.2015 01:48, Russell King - ARM Linux wrote:
> On Sun, Dec 20, 2015 at 01:32:11AM +0200, Vladimir Zapolskiy wrote:
>> @@ -162,6 +171,7 @@
>> cd-gpios = <&gpio 3 1 0>;
>> cd-inverted;
>> bus-width = <4>;
>> + vqmmc-supply = <&sd_reg>;
>
> This looks wrong. ios->power_mode controls the _card_ power (which is
> vmmc-supply), not the signalling power (which is vqmmc-supply):
>From drivers/mmc/host/mmci.c mmci_set_ios() manages both regulators,
mmc->supply.vmmc is changed on MMC_POWER_OFF and MMC_POWER_UP,
mmc->supply.vqmmc is changed on MMC_POWER_OFF and MMC_POWER_ON.
But I agree that vmmc-supply is the right choice here, GPIO regulator
controls an SD card power here, thanks for the finding.
> - vmmc-supply : phandle to the regulator device tree node, mentioned
> as the VCC/VDD supply in the eMMC/SD specs.
>
> - vqmmc-supply : phandle to the regulator device tree node, mentioned
> as the VCCQ/VDD_IO supply in the eMMC/SD specs.
>
>
--
With best wishes,
Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Roland Stigge <stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator
Date: Sun, 20 Dec 2015 04:14:19 +0200 [thread overview]
Message-ID: <56760EFB.9070406@mleia.com> (raw)
In-Reply-To: <20151219234848.GT8644-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On 20.12.2015 01:48, Russell King - ARM Linux wrote:
> On Sun, Dec 20, 2015 at 01:32:11AM +0200, Vladimir Zapolskiy wrote:
>> @@ -162,6 +171,7 @@
>> cd-gpios = <&gpio 3 1 0>;
>> cd-inverted;
>> bus-width = <4>;
>> + vqmmc-supply = <&sd_reg>;
>
> This looks wrong. ios->power_mode controls the _card_ power (which is
> vmmc-supply), not the signalling power (which is vqmmc-supply):
>From drivers/mmc/host/mmci.c mmci_set_ios() manages both regulators,
mmc->supply.vmmc is changed on MMC_POWER_OFF and MMC_POWER_UP,
mmc->supply.vqmmc is changed on MMC_POWER_OFF and MMC_POWER_ON.
But I agree that vmmc-supply is the right choice here, GPIO regulator
controls an SD card power here, thanks for the finding.
> - vmmc-supply : phandle to the regulator device tree node, mentioned
> as the VCC/VDD supply in the eMMC/SD specs.
>
> - vqmmc-supply : phandle to the regulator device tree node, mentioned
> as the VCCQ/VDD_IO supply in the eMMC/SD specs.
>
>
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-20 2:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 23:32 [PATCH 0/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
2015-12-19 23:32 ` Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 1/3] arm: dts: phy3250: add lcd and backlight fixed regulators Vladimir Zapolskiy
2015-12-19 23:32 ` Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator Vladimir Zapolskiy
2015-12-19 23:32 ` Vladimir Zapolskiy
2015-12-19 23:48 ` Russell King - ARM Linux
2015-12-19 23:48 ` Russell King - ARM Linux
2015-12-20 2:14 ` Vladimir Zapolskiy [this message]
2015-12-20 2:14 ` Vladimir Zapolskiy
2015-12-20 2:22 ` [PATCH v2 " Vladimir Zapolskiy
2015-12-20 2:22 ` Vladimir Zapolskiy
2015-12-21 12:43 ` [PATCH " Sergei Shtylyov
2015-12-21 12:43 ` Sergei Shtylyov
2015-12-21 16:58 ` Vladimir Zapolskiy
2015-12-21 16:58 ` Vladimir Zapolskiy
2015-12-21 17:04 ` Sergei Shtylyov
2015-12-21 17:04 ` Sergei Shtylyov
2015-12-19 23:32 ` [PATCH 3/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
2015-12-19 23:32 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56760EFB.9070406@mleia.com \
--to=vz@mleia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.