All of lore.kernel.org
 help / color / mirror / Atom feed
From: vz@mleia.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator
Date: Mon, 21 Dec 2015 18:58:50 +0200	[thread overview]
Message-ID: <56782FCA.2050504@mleia.com> (raw)
In-Reply-To: <5677F3DC.6070402@cogentembedded.com>

Hell Sergei,

On 21.12.2015 14:43, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/20/2015 2:32 AM, Vladimir Zapolskiy wrote:
> 
>> The change adds fixed voltage regulator for SD controller, ARM MMCI
>> controller driver uses it to control card power management.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>>   arch/arm/boot/dts/phy3250.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/phy3250.dts b/arch/arm/boot/dts/phy3250.dts
>> index 34e15fd..5465b9e 100644
>> --- a/arch/arm/boot/dts/phy3250.dts
>> +++ b/arch/arm/boot/dts/phy3250.dts
>> @@ -45,6 +45,15 @@
>>   			enable-active-high;
>>   			regulator-boot-on;
>>   		};
>> +
>> +		sd_reg: fixed-regulator at 2 {
> 
>     Please just "regulator at 2", to comply with the ePAPR standard.

thanks for review, just for my information, do I understand correctly
that you reference to "Generic Names Recommendation" ?

I have no objection to generalize device tree node name as you
suggested, will do it.

With best wishes,
Vladimir

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
To: Sergei Shtylyov
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Roland Stigge <stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator
Date: Mon, 21 Dec 2015 18:58:50 +0200	[thread overview]
Message-ID: <56782FCA.2050504@mleia.com> (raw)
In-Reply-To: <5677F3DC.6070402-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Hell Sergei,

On 21.12.2015 14:43, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/20/2015 2:32 AM, Vladimir Zapolskiy wrote:
> 
>> The change adds fixed voltage regulator for SD controller, ARM MMCI
>> controller driver uses it to control card power management.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/phy3250.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/phy3250.dts b/arch/arm/boot/dts/phy3250.dts
>> index 34e15fd..5465b9e 100644
>> --- a/arch/arm/boot/dts/phy3250.dts
>> +++ b/arch/arm/boot/dts/phy3250.dts
>> @@ -45,6 +45,15 @@
>>   			enable-active-high;
>>   			regulator-boot-on;
>>   		};
>> +
>> +		sd_reg: fixed-regulator@2 {
> 
>     Please just "regulator@2", to comply with the ePAPR standard.

thanks for review, just for my information, do I understand correctly
that you reference to "Generic Names Recommendation" ?

I have no objection to generalize device tree node name as you
suggested, will do it.

With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-12-21 16:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 23:32 [PATCH 0/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
2015-12-19 23:32 ` Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 1/3] arm: dts: phy3250: add lcd and backlight fixed regulators Vladimir Zapolskiy
2015-12-19 23:32   ` Vladimir Zapolskiy
2015-12-19 23:32 ` [PATCH 2/3] arm: dts: phy3250: add SD fixed regulator Vladimir Zapolskiy
2015-12-19 23:32   ` Vladimir Zapolskiy
2015-12-19 23:48   ` Russell King - ARM Linux
2015-12-19 23:48     ` Russell King - ARM Linux
2015-12-20  2:14     ` Vladimir Zapolskiy
2015-12-20  2:14       ` Vladimir Zapolskiy
2015-12-20  2:22   ` [PATCH v2 " Vladimir Zapolskiy
2015-12-20  2:22     ` Vladimir Zapolskiy
2015-12-21 12:43   ` [PATCH " Sergei Shtylyov
2015-12-21 12:43     ` Sergei Shtylyov
2015-12-21 16:58     ` Vladimir Zapolskiy [this message]
2015-12-21 16:58       ` Vladimir Zapolskiy
2015-12-21 17:04       ` Sergei Shtylyov
2015-12-21 17:04         ` Sergei Shtylyov
2015-12-19 23:32 ` [PATCH 3/3] arm: lpc32xx: remove direct control of GPIOs from shared mach file Vladimir Zapolskiy
2015-12-19 23:32   ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56782FCA.2050504@mleia.com \
    --to=vz@mleia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.